Re: Question about 'RegexDefaultOptions'

2018-03-23 Thread Marion et Christophe JAILLET
Le 23/03/2018 à 22:14, Yann Ylavic a écrit : So I propose that we don't document EXTENDED for RegexDefaultOptions for now (and definitely never in 2.4.x), AP_REG_EXTENDED needs more work in trunk before it becomes meaningful. +1 Thanks Christophe for noticing and trying to take care of this

Re: Question about 'RegexDefaultOptions'

2018-03-23 Thread Yann Ylavic
Hi Christophe, On Fri, Mar 23, 2018 at 8:04 PM, Christophe Jaillet wrote: > > I've just noticed that 'RegexDefaultOptions' introduced in 2.4.30 was > un-documented. While fixing it, I had a question. > > I'm puzzled by the 'EXTENDED' option. Does it have any

Question about 'RegexDefaultOptions'

2018-03-23 Thread Christophe Jaillet
Hi, I've just noticed that 'RegexDefaultOptions' introduced in 2.4.30 was un-documented. While fixing it, I had a question. I'm puzzled by the 'EXTENDED' option. Does it have any impact? AP_DECLARE(int) ap_regcomp_default_cflag_by_name(const char *name) { [...] else if

Re: svn commit: r1826279 - /httpd/httpd/branches/2.4.x/STATUS

2018-03-23 Thread Joe Orton
On Fri, Mar 16, 2018 at 11:50:17AM +0100, Luca Toscano wrote: > From my point of view, adding a comment nearby a directive (except in some > cases like you explained above) should be totally safe and transparent to > the user. I haven't ever thought about the possibility that having a inline >

Re: [RESULT] [VOTE] Release httpd-2.4.33

2018-03-23 Thread William A Rowe Jr
On Fri, Mar 23, 2018 at 10:50 AM, Alain Toussaint wrote: > Le mercredi 21 mars 2018 à 15:38 +, Daniel Ruggeri a écrit : >> Hi, all; >>I am pleased to report that the vote to release httpd-2.4.33 has PASSED >> with 7 binding votes >> and 2 non-binding votes. I will

Re: [RESULT] [VOTE] Release httpd-2.4.33

2018-03-23 Thread Alain Toussaint
Le mercredi 21 mars 2018 à 15:38 +, Daniel Ruggeri a écrit : > Hi, all; >    I am pleased to report that the vote to release httpd-2.4.33 has PASSED > with 7 binding votes > and 2 non-binding votes. I will begin the process of pushing the release out > to the mirrors today. > > Cheers! > >

Re: [PATCH] ap_str[case]cmp_match() made tail-recursive

2018-03-23 Thread William A Rowe Jr
On Fri, Mar 23, 2018 at 10:39 AM, Yann Ylavic wrote: > On Fri, Mar 23, 2018 at 4:37 PM, William A Rowe Jr > wrote: >> On Fri, Mar 23, 2018 at 8:18 AM, Yann Ylavic wrote: >>> Not sure it helps its readability (not worse though),

Re: [PATCH] ap_str[case]cmp_match() made tail-recursive

2018-03-23 Thread Yann Ylavic
On Fri, Mar 23, 2018 at 4:37 PM, William A Rowe Jr wrote: > On Fri, Mar 23, 2018 at 8:18 AM, Yann Ylavic wrote: >> Not sure it helps its readability (not worse though), at least it >> helps performances. >> >> For now the patches uses a big "goto" to

Re: [PATCH] ap_str[case]cmp_match() made tail-recursive

2018-03-23 Thread William A Rowe Jr
On Fri, Mar 23, 2018 at 8:18 AM, Yann Ylavic wrote: > Not sure it helps its readability (not worse though), at least it > helps performances. > > For now the patches uses a big "goto" to preserve code (AFAP), that > could easily be turned into a do {} while. > > WDYT? Did

Re: svn commit: r1826995 - in /httpd/httpd/trunk: docs/manual/mod/mod_ssl.xml modules/ssl/mod_ssl.c modules/ssl/ssl_engine_config.c modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c module

2018-03-23 Thread Joe Orton
On Fri, Mar 16, 2018 at 03:25:08PM -, ic...@apache.org wrote: > Author: icing > Date: Fri Mar 16 15:25:08 2018 > New Revision: 1826995 > > URL: http://svn.apache.org/viewvc?rev=1826995=rev > Log: > Extend SSLOCSPEnable with mode 'leaf' that only checks the leaf of a > certificate chain.

[PATCH] ap_str[case]cmp_match() made tail-recursive

2018-03-23 Thread Yann Ylavic
Not sure it helps its readability (not worse though), at least it helps performances. For now the patches uses a big "goto" to preserve code (AFAP), that could easily be turned into a do {} while. WDYT? Index: server/util.c === ---

Re: trunk crash on graceful

2018-03-23 Thread Stefan Eissing
> Am 23.03.2018 um 13:19 schrieb Yann Ylavic : > > On Fri, Mar 23, 2018 at 1:07 PM, Stefan Eissing > wrote:> >> >> In case someone gets bored or the weather is dull and cloudy in >> southern France, > > How so? The sun shines here (as

Re: trunk crash on graceful

2018-03-23 Thread Yann Ylavic
On Fri, Mar 23, 2018 at 1:07 PM, Stefan Eissing wrote:> > > In case someone gets bored or the weather is dull and cloudy in > southern France, How so? The sun shines here (as always), do you want a picture or it might hurt? :) > someone might have a look at this:

trunk crash on graceful

2018-03-23 Thread Stefan Eissing
Hi, when I run the mod_http2 tests on trunk, I get a crash when they do a graceful restart during a h2 download. This is relatively new and it does not happen on 2.4.x. In case someone gets bored or the weather is dull and cloudy in southern France, someone might have a look at this: Cheers,