Re: Patches related to HTML output by Apache httpd itself

2018-12-06 Thread Andras Farkas
On Thu, Dec 6, 2018 at 7:04 AM Nick Kew  wrote:
> These would be better submitted to bugzilla at issues.apache.org, where 
> someone
> might adopt them.
Ah, thank you for this info!  I'll do that soon.
> However, I should point out that there's nothing wrong with the existing 
> stuff.
> If I were to refactor the error messages, I'd be looking to take all remaining
> actual HTML out of the server itself, and into documents (or templates) under
> the control of the sysop.
Invalid HTML is inherently wrong, and there's also no need to tell
browsers to render in quirks mode by intentionally using an old
doctype.
Good idea though, to move the HTML into their own documents.
> (And I wouldn't touch your indexhtml with a bargepole)!
I'll make a new diff with less drastic changes.


Re: Patches related to HTML output by Apache httpd itself

2018-12-06 Thread Nick Kew


> On 6 Dec 2018, at 11:34, Andras Farkas  wrote:
> 
> Ping.
> On Mon, Nov 26, 2018 at 4:08 AM Andras Farkas  
> wrote:
>> 
>> Evening!
>> 
>> I noticed that most of the time, when Apache httpd itself generates
>> HTML output (like for 404 pages and autoindex pages) it uses ancient
>> HTML 2.0 and HTML 3.2 doctypes.
>> These 11 attached diffs update those.  The most important of the diffs
>> is httpdh.diff

These would be better submitted to bugzilla at issues.apache.org, where someone
might adopt them.

However, I should point out that there's nothing wrong with the existing stuff.
If I were to refactor the error messages, I'd be looking to take all remaining
actual HTML out of the server itself, and into documents (or templates) under
the control of the sysop.

(And I wouldn't touch your indexhtml with a bargepole)!

-- 
Nick Kew

Re: Patches related to HTML output by Apache httpd itself

2018-12-06 Thread Andras Farkas
Ping.
On Mon, Nov 26, 2018 at 4:08 AM Andras Farkas  wrote:
>
> Evening!
>
> I noticed that most of the time, when Apache httpd itself generates
> HTML output (like for 404 pages and autoindex pages) it uses ancient
> HTML 2.0 and HTML 3.2 doctypes.
> These 11 attached diffs update those.  The most important of the diffs
> is httpdh.diff
> I compiled and tested these diffs, and everything I tested works fine!
>  Browsers now render those pages in standards mode rather than quirks
> mode.
> While I made these patches for httpd 2.4.37 these patches would likely
> also be useful for trunk.
> This could be the first step in making sure all the HTML output is more valid.
>
> Thank you for reading this email.