Re: svn commit: r1864735 - /httpd/httpd/branches/2.4.x/modules/http2/h2_stream.c

2019-08-08 Thread Marion & Christophe JAILLET

Thx for spotting and fixing it Eric.

The comma has been automagically removed by 'make update-log-msg-tags'
Will have a look to see if i tweak the script in order to avoid that in 
the future.


CJ


Le 08/08/2019 à 23:23, cove...@apache.org a écrit :

Author: covener
Date: Thu Aug  8 21:23:29 2019
New Revision: 1864735

URL: http://svn.apache.org/viewvc?rev=1864735&view=rev
Log:
followup to r1864734

Modified:
 httpd/httpd/branches/2.4.x/modules/http2/h2_stream.c

Modified: httpd/httpd/branches/2.4.x/modules/http2/h2_stream.c
URL: 
http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/http2/h2_stream.c?rev=1864735&r1=1864734&r2=1864735&view=diff
==
--- httpd/httpd/branches/2.4.x/modules/http2/h2_stream.c (original)
+++ httpd/httpd/branches/2.4.x/modules/http2/h2_stream.c Thu Aug  8 21:23:29 
2019
@@ -783,7 +783,7 @@ apr_status_t h2_stream_end_headers(h2_st
  apr_table_do(table_check_val_len, &ctx, stream->request->headers, 
NULL);
  if (ctx.failed_key) {
  ap_log_cerror(APLOG_MARK, APLOG_INFO, 0, stream->session->c,
-  H2_STRM_LOG(APLOGNO(10190) stream,"Request header exceeds 
"
+  H2_STRM_LOG(APLOGNO(10190), stream,"Request header 
exceeds "
"LimitRequestFieldSize: %.*s"),
(int)H2MIN(strlen(ctx.failed_key), 80), 
ctx.failed_key);
  set_error_response(stream, HTTP_REQUEST_HEADER_FIELDS_TOO_LARGE);





Re: svn commit: r1864701 - /httpd/httpd/branches/2.4.x/STATUS

2019-08-08 Thread Jan Ehrhardt
Steffen in gmane.comp.apache.devel (Thu, 8 Aug 2019 15:43:46 +0200):
>Are the reported APLOGNO all going to be solved in  .41:
>
>mod_proxy mod_http2 mod_ssl

In mod_md.c I se no APLOGNO() without argument anymore, so they must be
gone. For instance, 2 out of three directly after line 600 were without
argument in .40 and generated the warning. Now they have an argument:
http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/md/mod_md.c?diff_format=h&view=markup#l600

FWIW: +1
-- 
Jan



Re: [NOTICE] Intent to T&R 2.4.41 in ~24 hrs

2019-08-08 Thread Dennis Clarke
On 8/8/19 4:47 PM, Daniel Ruggeri wrote:
> Yessir. I'll send a notification when ready.
> -- 

Regarding the usual text : Announcement2.4.txt

Seems a little confusing to the average user that we may say this is the
best version of httpd and it will need apr 1.5.x minimum and then says
"features may require the 1.6.x version of both APR and APR-Util".  Well
at the same time the apr project claims "recommended releases" are newer
apr 1.7.0.  Perhaps it would be more clear to just say we recommend that
you use Apache Portable Runtime 1.7.0 as well as Apache Portable Runtime
Utility 1.6.1 and that solves the version mystery.

-- 
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional



Re: [VOTE] Release httpd-2.4.40

2019-08-08 Thread Eric Covener
> Can the backport I tested and suggested on May 13th 2019, about
> mod_session_crypto be considered for this release? Or if it's too late
> for me to ask again, for the next one?
>
I proposed it just now


Re: [VOTE] Release httpd-2.4.40

2019-08-08 Thread Vincent Deffontaines
Le Sat, 3 Aug 2019 08:51:07 -0500,
Daniel Ruggeri  a écrit :

> Hi, all;
>    Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.40:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> 
> The computed digests of the tarball up for vote are:
> sha1: 31bc6f87ac209010b8b364abc1c80dfaee53cc64 *httpd-2.4.40.tar.gz
> sha256:
> 451e6cf6caa09119900b74652266427f70050de5c51948acd4aaaf60d0d3cad0
> *httpd-2.4.40.tar.gz
> 

Hi,

Can the backport I tested and suggested on May 13th 2019, about
mod_session_crypto be considered for this release? Or if it's too late
for me to ask again, for the next one?

email subject was :
Subject: Re: [2.4.39] [mod_auth_form]
[mod_session_crypto] Cookie management performance

Cheers,

Vincent Deffontaines
(alternate email address : gry...@apache.org)


-- 
Notre liberté repose sur ce que les autres ignorent de notre existence
Alexandre Soljenitsyne


Re: svn commit: r1864701 - /httpd/httpd/branches/2.4.x/STATUS

2019-08-08 Thread Christophe JAILLET

+1

Le 08/08/2019 à 15:09, Eric Covener a écrit :

CC dev@ I assumed this was safe to just assert.

On Thu, Aug 8, 2019 at 9:08 AM  wrote:

Author: covener
Date: Thu Aug  8 13:08:33 2019
New Revision: 1864701

URL: http://svn.apache.org/viewvc?rev=1864701&view=rev
Log:
no votes for APLOGNO commits.

99% sure but please reply


Modified:
 httpd/httpd/branches/2.4.x/STATUS

Modified: httpd/httpd/branches/2.4.x/STATUS
URL: 
http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1864701&r1=1864700&r2=1864701&view=diff
==
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Thu Aug  8 13:08:33 2019
@@ -122,6 +122,7 @@ CURRENT RELEASE NOTES:
  . documentation
  . non-Unix build
  . non-Unix, single-platform code
+. routine APLOGNO() backports

  RELEASE SHOWSTOPPERS:









Re: [NOTICE] Intent to T&R 2.4.41 in ~24 hrs

2019-08-08 Thread Daniel Ruggeri
Yessir. I'll send a notification when ready.
-- 
Daniel Ruggeri

On August 8, 2019 11:54:18 AM CDT, Dennis Clarke  wrote:
>On 8/8/19 7:41 AM, Daniel Ruggeri wrote:
>> Hi, all;
>> As the subject says, I'd like to get on with our 2.4.new release now
>> that we're good to go. Will kick things off in about 24 hours
>
>Tarballs will be in the usual places ??
>
>
>
>-- 
>Dennis Clarke
>RISC-V/SPARC/PPC/ARM/CISC
>UNIX and Linux spoken
>GreyBeard and suspenders optional


Re: [NOTICE] Intent to T&R 2.4.41 in ~24 hrs

2019-08-08 Thread Dennis Clarke
On 8/8/19 7:41 AM, Daniel Ruggeri wrote:
> Hi, all;
> As the subject says, I'd like to get on with our 2.4.new release now
> that we're good to go. Will kick things off in about 24 hours

Tarballs will be in the usual places ??



-- 
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional


Re: svn commit: r1864701 - /httpd/httpd/branches/2.4.x/STATUS

2019-08-08 Thread Joe Orton
On Thu, Aug 08, 2019 at 09:09:57AM -0400, Eric Covener wrote:
> CC dev@ I assumed this was safe to just assert.
> 
> On Thu, Aug 8, 2019 at 9:08 AM  wrote:
> >
> > Author: covener
> > Date: Thu Aug  8 13:08:33 2019
> > New Revision: 1864701
> >
> > URL: http://svn.apache.org/viewvc?rev=1864701&view=rev
> > Log:
> > no votes for APLOGNO commits.
> >
> > 99% sure but please reply

+1



Re: svn commit: r1864701 - /httpd/httpd/branches/2.4.x/STATUS

2019-08-08 Thread Steffen
Are the reported APLOGNO all going to be solved in  .41:

mod_proxy mod_http2 mod_ssl


> Op 8 aug. 2019 om 15:09 heeft Eric Covener  het volgende 
> geschreven:
> 
> CC dev@ I assumed this was safe to just assert.
> 
>> On Thu, Aug 8, 2019 at 9:08 AM  wrote:
>> 
>> Author: covener
>> Date: Thu Aug  8 13:08:33 2019
>> New Revision: 1864701
>> 
>> URL: http://svn.apache.org/viewvc?rev=1864701&view=rev
>> Log:
>> no votes for APLOGNO commits.
>> 
>> 99% sure but please reply
>> 
>> 
>> Modified:
>>httpd/httpd/branches/2.4.x/STATUS
>> 
>> Modified: httpd/httpd/branches/2.4.x/STATUS
>> URL: 
>> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1864701&r1=1864700&r2=1864701&view=diff
>> ==
>> --- httpd/httpd/branches/2.4.x/STATUS (original)
>> +++ httpd/httpd/branches/2.4.x/STATUS Thu Aug  8 13:08:33 2019
>> @@ -122,6 +122,7 @@ CURRENT RELEASE NOTES:
>> . documentation
>> . non-Unix build
>> . non-Unix, single-platform code
>> +. routine APLOGNO() backports
>> 
>> RELEASE SHOWSTOPPERS:
>> 
>> 
>> 
> 
> 
> -- 
> Eric Covener
> cove...@gmail.com



Re: svn commit: r1864701 - /httpd/httpd/branches/2.4.x/STATUS

2019-08-08 Thread Daniel Ruggeri
+1
-- 
Daniel Ruggeri

On August 8, 2019 8:09:57 AM CDT, Eric Covener  wrote:
>CC dev@ I assumed this was safe to just assert.
>
>On Thu, Aug 8, 2019 at 9:08 AM  wrote:
>>
>> Author: covener
>> Date: Thu Aug  8 13:08:33 2019
>> New Revision: 1864701
>>
>> URL: http://svn.apache.org/viewvc?rev=1864701&view=rev
>> Log:
>> no votes for APLOGNO commits.
>>
>> 99% sure but please reply
>>
>>
>> Modified:
>> httpd/httpd/branches/2.4.x/STATUS
>>
>> Modified: httpd/httpd/branches/2.4.x/STATUS
>> URL:
>http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1864701&r1=1864700&r2=1864701&view=diff
>>
>==
>> --- httpd/httpd/branches/2.4.x/STATUS (original)
>> +++ httpd/httpd/branches/2.4.x/STATUS Thu Aug  8 13:08:33 2019
>> @@ -122,6 +122,7 @@ CURRENT RELEASE NOTES:
>>  . documentation
>>  . non-Unix build
>>  . non-Unix, single-platform code
>> +. routine APLOGNO() backports
>>
>>  RELEASE SHOWSTOPPERS:
>>
>>
>>
>
>
>-- 
>Eric Covener
>cove...@gmail.com


Re: svn commit: r1864701 - /httpd/httpd/branches/2.4.x/STATUS

2019-08-08 Thread Eric Covener
CC dev@ I assumed this was safe to just assert.

On Thu, Aug 8, 2019 at 9:08 AM  wrote:
>
> Author: covener
> Date: Thu Aug  8 13:08:33 2019
> New Revision: 1864701
>
> URL: http://svn.apache.org/viewvc?rev=1864701&view=rev
> Log:
> no votes for APLOGNO commits.
>
> 99% sure but please reply
>
>
> Modified:
> httpd/httpd/branches/2.4.x/STATUS
>
> Modified: httpd/httpd/branches/2.4.x/STATUS
> URL: 
> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1864701&r1=1864700&r2=1864701&view=diff
> ==
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Thu Aug  8 13:08:33 2019
> @@ -122,6 +122,7 @@ CURRENT RELEASE NOTES:
>  . documentation
>  . non-Unix build
>  . non-Unix, single-platform code
> +. routine APLOGNO() backports
>
>  RELEASE SHOWSTOPPERS:
>
>
>


-- 
Eric Covener
cove...@gmail.com


[NOTICE] Intent to T&R 2.4.41 in ~24 hrs

2019-08-08 Thread Daniel Ruggeri
Hi, all;
   As the subject says, I'd like to get on with our 2.4.new release now that 
we're good to go. Will kick things off in about 24 hours
-- 
Daniel Ruggeri