Re: Trying to compile httpd trunk

[Mike Rumph]

I don't have a way to try this out at the moment,
but if I remember correctly you may want to try ./buildconf inside the
srclib/apr
and srclib/apr-util directories to generate the make files.

On Thu, Dec 19, 2019 at 10:08 AM Stéphane Blondon <
stephane.blon...@gmail.com> wrote:

> Le mar. 17 déc. 2019 à 19:05, Michal Karm Babacek
>  a écrit :
> >
> > The last time I did this (a week or so ago on RHEL 7.6),
> > I had to checkout both apr and apr-util, their 1.x branches, not trunk.
> >
>
> Thanks for your help!
>
> I tried with branches 1.x but it fails with the same error:
>
> $ rm -rf srclib/
> $ make clean
> $ svn co http://svn.apache.org/repos/asf/apr/apr/branches/1.7.x srclib/apr
> $ svn co http://svn.apache.org/repos/asf/apr/apr-util/branches/1.6.x
> srclib/apr-util
> 
> $ ./buildconf
> $ ./configure --prefix=/home/stephane/bin/http --with-included-apr
> $ LANG=C make
>
> Output of `make` command:
> Making all in srclib
> make[1]: Entering directory '/home/stephane/src/httpd-trunk/srclib'
> make[1]: *** No rule to make target 'all'.  Stop.
> make[1]: Leaving directory '/home/stephane/src/httpd-trunk/srclib'
> make: *** [/home/stephane/src/httpd-trunk/build/rules.mk:75:
> all-recursive] Error 1
>
>
> Regards
> --
> Stéphane
>

Re: t/modules/{brotli,deflate}.t: handle the case < 2.4.42

[Eric Covener]

On Thu, Dec 19, 2019 at 4:32 PM Marion & Christophe JAILLET <
christophe.jail...@wanadoo.fr> wrote:

> Hi,
>
> I've received the attached patch against the test framework.
> This is not the first time Petr propose such patches and most (or maybe
> even all) have been merged.
>
> The goal is to avoid new warnings on suse tests when a recent test
> framework is used on an older version of httpd.
>
> However, this particular case puzzles me.
> I see r1868313 as a fix on a non-RFC compliant behavior. So I'm not sure
> this should be "hidden" only because older versions are known to fail.
>
> In other word, what is the "semantic" behind the test framework?
>- Testing against regression only? (in this case including Petr's patch
> makes sense to me)   - or -
>- Checking that the behavior is correct (in this case, I'm not fan of
> "hiding" things that are known to fail. A failure would mean: "you should
> upgrade to have this fixed")
>
I think the tests should either skip or have changed expectations when run
against an old build, not fail.   In other words the tests are for us, not
end users curious how correct what they have is.

Re: Trying to compile httpd trunk

[Christophe JAILLET]

Hi,

see https://httpd.apache.org/lists.html#http-dev
You have to send a mail to dev-unsubscr...@httpd.apache.org 
.


CJ




Le 19/12/2019 à 19:11, Yevgeny Pats a écrit :

Sorry for spamming. How to unsubscribe?

On Thu, Dec 19, 2019, 8:08 PM Stéphane Blondon 
mailto:stephane.blon...@gmail.com>> wrote:


Le mar. 17 déc. 2019 à 19:05, Michal Karm Babacek
mailto:karm.baba...@gmail.com>> a écrit :
>
> The last time I did this (a week or so ago on RHEL 7.6),
> I had to checkout both apr and apr-util, their 1.x branches, not
trunk.
>

Thanks for your help!

I tried with branches 1.x but it fails with the same error:

$ rm -rf srclib/
$ make clean
$ svn co http://svn.apache.org/repos/asf/apr/apr/branches/1.7.x
srclib/apr
$ svn co http://svn.apache.org/repos/asf/apr/apr-util/branches/1.6.x
srclib/apr-util

$ ./buildconf
$ ./configure --prefix=/home/stephane/bin/http --with-included-apr
$ LANG=C make

Output of `make` command:
Making all in srclib
make[1]: Entering directory '/home/stephane/src/httpd-trunk/srclib'
make[1]: *** No rule to make target 'all'.  Stop.
make[1]: Leaving directory '/home/stephane/src/httpd-trunk/srclib'
make: *** [/home/stephane/src/httpd-trunk/build/rules.mk:75
:
all-recursive] Error 1


Regards
-- 
Stéphane

Fwd: t/modules/{brotli,deflate}.t: handle the case < 2.4.42

[Marion & Christophe JAILLET]

Hi,

I've received the attached patch against the test framework.
This is not the first time Petr propose such patches and most (or maybe 
even all) have been merged.


The goal is to avoid new warnings on suse tests when a recent test 
framework is used on an older version of httpd.


However, this particular case puzzles me.
I see r1868313 as a fix on a non-RFC compliant behavior. So I'm not sure 
this should be "hidden" only because older versions are known to fail.


In other word, what is the "semantic" behind the test framework?
   - Testing against regression only? (in this case including Petr's 
patch makes sense to me)   - or -
   - Checking that the behavior is correct (in this case, I'm not fan 
of "hiding" things that are known to fail. A failure would mean: "you 
should upgrade to have this fixed")


What is your opinion?

CJ

 Message transféré 
Sujet : t/modules/{brotli,deflate}.t: handle the case < 2.4.42
Date :  Tue, 17 Dec 2019 13:52:08 +0100
De :pgajdos 
Pour :  christophe.jail...@wanadoo.fr



Hello Christophe,

I just updated to httpd-framework r1870094 and it is failing for me in
brotli.t and deflate.t and it is because of r1868312 which assumes
that httpd-trunk r1868313 is included in the httpd (2.4.42 and on).

I tried to do something in the patch attached, but not sure it is
satisfactory for inclusion.

Bye,
Petr

--
Have a lot of fun!

Index: httpd-framework/t/modules/brotli.t
===
--- httpd-framework.orig/t/modules/brotli.t	2019-12-16 10:22:18.570687529 +0100
+++ httpd-framework/t/modules/brotli.t	2019-12-16 15:04:43.043442458 +0100
@@ -5,16 +5,22 @@ use Apache::Test;
 use Apache::TestUtil;
 use Apache::TestRequest;
 
+my $with_contenc=1;
+if (have_min_apache_version('2.4.42')) {
+  # httpd-trunk r1868313 not included
+  $with_contenc=0;
+}
+
 my @qvalue = (
 [ ''  , 1],
 [ ' ' , 1],
 [ ';' , 1],
 [';q=', 1],
-[';q=0'   , 0],
-[';q=0.'  , 0],
-[';q=0.0' , 0],
-[';q=0.00', 0],
-[';q=0.000'   , 0],
+[';q=0'   , $with_contenc],
+[';q=0.'  , $with_contenc],
+[';q=0.0' , $with_contenc],
+[';q=0.00', $with_contenc],
+[';q=0.000'   , $with_contenc],
 [';q=0.'  , 1],   # invalid qvalue format
 );
 
Index: httpd-framework/t/modules/deflate.t
===
--- httpd-framework.orig/t/modules/deflate.t	2019-12-16 10:22:18.570687529 +0100
+++ httpd-framework/t/modules/deflate.t	2019-12-16 15:04:43.043442458 +0100
@@ -56,7 +56,12 @@ for my $server_deflate_uri (@server_defl
  content => $deflated_str);
 
 ok $original_str eq $inflated_str;
-ok $original_str eq $deflated_str_q0;
+if (have_min_apache_version("2.4.42")) {
+  ok $original_str eq $deflated_str_q0;
+} else {
+  # httpd-trunk r1868313 not included
+  ok $deflated_str eq $deflated_str_q0;
+}
 my $resp = POST($server_inflate_uri, @inflate_headers,
 content => "foo123456789012346");
 if (have_min_apache_version("2.5")) {

Re: Trying to compile httpd trunk

[Yevgeny Pats]

Sorry for spamming. How to unsubscribe?

On Thu, Dec 19, 2019, 8:08 PM Stéphane Blondon 
wrote:

> Le mar. 17 déc. 2019 à 19:05, Michal Karm Babacek
>  a écrit :
> >
> > The last time I did this (a week or so ago on RHEL 7.6),
> > I had to checkout both apr and apr-util, their 1.x branches, not trunk.
> >
>
> Thanks for your help!
>
> I tried with branches 1.x but it fails with the same error:
>
> $ rm -rf srclib/
> $ make clean
> $ svn co http://svn.apache.org/repos/asf/apr/apr/branches/1.7.x srclib/apr
> $ svn co http://svn.apache.org/repos/asf/apr/apr-util/branches/1.6.x
> srclib/apr-util
> 
> $ ./buildconf
> $ ./configure --prefix=/home/stephane/bin/http --with-included-apr
> $ LANG=C make
>
> Output of `make` command:
> Making all in srclib
> make[1]: Entering directory '/home/stephane/src/httpd-trunk/srclib'
> make[1]: *** No rule to make target 'all'.  Stop.
> make[1]: Leaving directory '/home/stephane/src/httpd-trunk/srclib'
> make: *** [/home/stephane/src/httpd-trunk/build/rules.mk:75:
> all-recursive] Error 1
>
>
> Regards
> --
> Stéphane
>

Re: Trying to compile httpd trunk

[Stéphane Blondon]

Le mar. 17 déc. 2019 à 19:05, Michal Karm Babacek
 a écrit :
>
> The last time I did this (a week or so ago on RHEL 7.6),
> I had to checkout both apr and apr-util, their 1.x branches, not trunk.
>

Thanks for your help!

I tried with branches 1.x but it fails with the same error:

$ rm -rf srclib/
$ make clean
$ svn co http://svn.apache.org/repos/asf/apr/apr/branches/1.7.x srclib/apr
$ svn co http://svn.apache.org/repos/asf/apr/apr-util/branches/1.6.x
srclib/apr-util
$ ./buildconf
$ ./configure --prefix=/home/stephane/bin/http --with-included-apr
$ LANG=C make

Output of `make` command:
Making all in srclib
make[1]: Entering directory '/home/stephane/src/httpd-trunk/srclib'
make[1]: *** No rule to make target 'all'.  Stop.
make[1]: Leaving directory '/home/stephane/src/httpd-trunk/srclib'
make: *** [/home/stephane/src/httpd-trunk/build/rules.mk:75:
all-recursive] Error 1


Regards
-- 
Stéphane

Re: Errored: apache/httpd#124 (2.4.x - 29129a5)

[Luca Toscano]

Hi!

Seems unrelated to you commit from the build's logs, I think we'd need to
make some changes to the build scripts to make them more tolerant to
temporary network blips or similar.

Luca

Il giorno gio 19 dic 2019 alle ore 15:12 Steffen  ha
scritto:

> Do not know why I get this.
>
> What to do ?
>
> Steffen
>
> On Thursday 19/12/2019 at 14:53, Travis CI wrote:
>
> apache
>
> /
>
> httpd
>
> 
>
> [ Image ] 2.4.x 
> [ Image ]
> Build #124 has errored
> 
> [ Image ]
> [ Image ] 11 mins and 41 secs
>
> [ Image ] Steffen Land
> 29129a5 CHANGESET →
> 
>
> vote mod_http2
>
>
> git-svn-id:
> https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1871824
> 13f79535-47bb-0310-9956-ffa450edef68
>
> Want to know about upcoming build environment updates?
>
> Would you like to stay up-to-date with the upcoming Travis CI build
> environment updates? We set up a mailing list for you!
> SIGN UP HERE 
>
> [ Image ]
>
> Documentation  about Travis CI
> Have any questions? We're here to help. 
> Unsubscribe
> 
> from build emails from the apache/httpd repository.
> To unsubscribe from *all* build emails, please update your settings
> .
>
> [ Image ] 
>
> Travis CI GmbH, Rigaer Str. 8, 10427 Berlin, Germany | GF/CEO: Randy
> Jacops | Contact: cont...@travis-ci.com | Amtsgericht Charlottenburg,
> Berlin, HRB 140133 B | Umsatzsteuer-ID gemäß §27 a Umsatzsteuergesetz:
> DE282002648
>
>
>

Re: Errored: apache/httpd#124 (2.4.x - 29129a5)

[Stefan Eissing]

> Am 19.12.2019 um 15:12 schrieb Steffen :
> 
> Do not know why I get this.

I think the Travis build jobs are not yet 100% bullet proof. You did nothing 
wrong.

> What to do ?
> 
> Steffen
>  
> On Thursday 19/12/2019 at 14:53, Travis CI wrote:
>> apache / httpd
>> [ Image ] 2.4.x
>> [ Image ] Build #124 has errored[ Image ][ Image ] 11 mins and 41 secs
>> [ Image ] Steffen Land 29129a5 CHANGESET →
>> vote mod_http2
>> 
>> 
>> git-svn-id: 
>> https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@187182413f79535-47bb-0310-9956-ffa450edef68
>> Want to know about upcoming build environment updates?
>> 
>> Would you like to stay up-to-date with the upcoming Travis CI build 
>> environment updates? We set up a mailing list for you!
>> 
>> SIGN UP HERE
>> [ Image ]  Documentation about Travis CI 
>> Have any questions?  We're here to help.
>> Unsubscribe from build emails from the apache/httpd repository. 
>> To unsubscribe from all build emails, please update your settings. 
>> [ Image ] 
>> Travis CI GmbH, Rigaer Str. 8, 10427 Berlin, Germany | GF/CEO: Randy Jacops 
>> |  Contact: cont...@travis-ci.com | Amtsgericht Charlottenburg, Berlin, HRB 
>> 140133 B | Umsatzsteuer-ID gemäß §27 a Umsatzsteuergesetz: DE282002648
> 
> 

Errored: apache/httpd#124 (2.4.x - 29129a5)

[Travis CI]

Build Update for apache/httpd
-

Build: #124
Status: Errored

Duration: 11 mins and 41 secs
Commit: 29129a5 (2.4.x)
Author: Steffen Land
Message: vote mod_http2


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1871824 
13f79535-47bb-0310-9956-ffa450edef68

View the changeset: 
https://github.com/apache/httpd/compare/15abd86f899b...29129a58943a

View the full build log and details: 
https://travis-ci.org/apache/httpd/builds/627231981?utm_medium=notification_source=email

--

You can unsubscribe from build emails from the apache/httpd repository going to 
https://travis-ci.org/account/preferences/unsubscribe?repository=69847_medium=notification_source=email.
Or unsubscribe from *all* email updating your settings at 
https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.

Re: svn commit: r1871810 - in /httpd/httpd/trunk: CHANGES modules/http2/h2_mplx.c modules/http2/h2_session.c modules/http2/h2_util.c modules/http2/h2_util.h modules/http2/h2_version.h modules/http2/h2

[Stefan Eissing]

> Am 19.12.2019 um 13:19 schrieb Yann Ylavic :
> 
> On Thu, Dec 19, 2019 at 1:04 PM Stefan Eissing
>  wrote:
>> 
>> Where do you see this callback invoked when the mplx is locked?
> 
> As I said, h2_mplx_out_open() takes the lock, calls out_open() which
> calls h2_beam_on_produced(stream->output, output_produced, stream).
> But actually it seems that h2_beam_on_produced() only sets the
> callback, it does not run it, so it was a too simplistic analysis of
> mine probably... Sorry for the noise.

No, please make noise! There is always something wrong with my assumptions. 
Someone needs to shake them!

;-)

Re: svn commit: r1871810 - in /httpd/httpd/trunk: CHANGES modules/http2/h2_mplx.c modules/http2/h2_session.c modules/http2/h2_util.c modules/http2/h2_util.h modules/http2/h2_version.h modules/http2/h2

[Yann Ylavic]

On Thu, Dec 19, 2019 at 1:04 PM Stefan Eissing
 wrote:
>
> Where do you see this callback invoked when the mplx is locked?

As I said, h2_mplx_out_open() takes the lock, calls out_open() which
calls h2_beam_on_produced(stream->output, output_produced, stream).
But actually it seems that h2_beam_on_produced() only sets the
callback, it does not run it, so it was a too simplistic analysis of
mine probably... Sorry for the noise.

Re: svn commit: r1871810 - in /httpd/httpd/trunk: CHANGES modules/http2/h2_mplx.c modules/http2/h2_session.c modules/http2/h2_util.c modules/http2/h2_util.h modules/http2/h2_version.h modules/http2/h2

[Stefan Eissing]

> Am 19.12.2019 um 12:59 schrieb Yann Ylavic :
> 
> On Thu, Dec 19, 2019 at 10:39 AM  wrote:
> []
>> 
>> Modified: httpd/httpd/trunk/modules/http2/h2_mplx.c
>> URL: 
>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_mplx.c?rev=1871810=1871809=1871810=diff
>> ==
>> --- httpd/httpd/trunk/modules/http2/h2_mplx.c (original)
>> +++ httpd/httpd/trunk/modules/http2/h2_mplx.c Thu Dec 19 09:39:22 2019
> []
>> 
>> @@ -508,12 +511,11 @@ static void output_produced(void *ctx, h
>> h2_stream *stream = ctx;
>> h2_mplx *m = stream->session->mplx;
>> 
>> -check_data_for(m, stream, 1);
>> +check_data_for(m, stream, 0);
>> }
> 
> This should be mplx_is_locked=1, no? It seems that h2_mplx_out_open()
> takes the lock, then calls out_open() => output_produced().

Hmm. The output_produced is a callback in the h2_task output beam. The idea is 
that when the h2 request writes to its output brigade, which ends up in the 
output beam, this callback notifies the h2_mplx that there is data to be 
handled.

Where do you see this callback invoked when the mplx is locked?

Passed: apache/httpd#120 (trunk - 1f4ec79)

[Travis CI]

Build Update for apache/httpd
-

Build: #120
Status: Passed

Duration: 8 mins and 38 secs
Commit: 1f4ec79 (trunk)
Author: Stefan Eissing
Message:   *) mod_http2: Fixed rare cases where a h2 worker could deadlock the 
main connection. 



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1871810 
13f79535-47bb-0310-9956-ffa450edef68

View the changeset: 
https://github.com/apache/httpd/compare/17fcbba49d99...1f4ec799b142

View the full build log and details: 
https://travis-ci.org/apache/httpd/builds/627135453?utm_medium=notification_source=email

--

You can unsubscribe from build emails from the apache/httpd repository going to 
https://travis-ci.org/account/preferences/unsubscribe?repository=69847_medium=notification_source=email.
Or unsubscribe from *all* email updating your settings at 
https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.