Re: async filters still borked (was Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis)
On 3/20/20 2:46 PM, Joe Orton wrote: > On Fri, Mar 06, 2020 at 09:30:41AM +0100, Ruediger Pluem wrote: >> On 3/4/20 9:23 AM, jor...@apache.org wrote: >>> Author: jorton >>> Date: Wed Mar 4 08:23:55 2020 >>> New Revision: 1874775 >>> >>> URL: http://svn.apache.org/viewvc?rev=1874775=rev >>> Log: >>> Update docs. The expr_string.t failure has not been seen since >>> the workaround was added AFAICT. The async filter bug >>> is still breaking the tests regularly. [skip ci]. >> >> Anyone found time to check >> >> https://github.com/apache/httpd/pull/88 >> >> regarding the async filter bug? > > [crickets] > > We are two months on since discussing this first. It seems quite > worrying that the async filters stuff was introduced with apparently > nasty bugs and yet is already bitrotting on trunk with not enough people > to review and fix it. Can we move the code to a branch until it is > ready? Maybe better, yes. So +1. Regards Rüdiger
Re: async filters still borked (was Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis)
+1 from me. > On Mar 20, 2020, at 9:46 AM, Joe Orton wrote: > > On Fri, Mar 06, 2020 at 09:30:41AM +0100, Ruediger Pluem wrote: >> On 3/4/20 9:23 AM, jor...@apache.org wrote: >>> Author: jorton >>> Date: Wed Mar 4 08:23:55 2020 >>> New Revision: 1874775 >>> >>> URL: http://svn.apache.org/viewvc?rev=1874775=rev >>> Log: >>> Update docs. The expr_string.t failure has not been seen since >>> the workaround was added AFAICT. The async filter bug >>> is still breaking the tests regularly. [skip ci]. >> >> Anyone found time to check >> >> https://github.com/apache/httpd/pull/88 >> >> regarding the async filter bug? > > [crickets] > > We are two months on since discussing this first. It seems quite > worrying that the async filters stuff was introduced with apparently > nasty bugs and yet is already bitrotting on trunk with not enough people > to review and fix it. Can we move the code to a branch until it is > ready? > > Regards, Joe >
async filters still borked (was Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis)
On Fri, Mar 06, 2020 at 09:30:41AM +0100, Ruediger Pluem wrote: > On 3/4/20 9:23 AM, jor...@apache.org wrote: > > Author: jorton > > Date: Wed Mar 4 08:23:55 2020 > > New Revision: 1874775 > > > > URL: http://svn.apache.org/viewvc?rev=1874775=rev > > Log: > > Update docs. The expr_string.t failure has not been seen since > > the workaround was added AFAICT. The async filter bug > > is still breaking the tests regularly. [skip ci]. > > Anyone found time to check > > https://github.com/apache/httpd/pull/88 > > regarding the async filter bug? [crickets] We are two months on since discussing this first. It seems quite worrying that the async filters stuff was introduced with apparently nasty bugs and yet is already bitrotting on trunk with not enough people to review and fix it. Can we move the code to a branch until it is ready? Regards, Joe
Fixed: apache/httpd#501 (2.4.x - d58a763)
Build Update for apache/httpd - Build: #501 Status: Fixed Duration: 14 mins and 11 secs Commit: d58a763 (2.4.x) Author: Eric Covener Message: Merge r1875429 from trunk: fix apxs for non-destdir builds subtr(...,0, -1) chops off a character and leaves relative path. (you will need to re-run configure) Reviewed By: +1: covener, gbechis, rpluem git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1875475 13f79535-47bb-0310-9956-ffa450edef68 View the changeset: https://github.com/apache/httpd/compare/462a0bc7c86e...d58a763f8f99 View the full build log and details: https://travis-ci.org/github/apache/httpd/builds/664835735?utm_medium=notification_source=email -- You can unsubscribe from build emails from the apache/httpd repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=69847_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
Re: [VOTE] Release httpd-2.4.42
On Thu, Mar 19, 2020 at 11:19 AM Eric Covener wrote: > > On Thu, Mar 19, 2020 at 10:45 AM Daniel Ruggeri wrote: > > > > Hi, all; > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > > > I would like to call a VOTE over the next few days to release this > > candidate tarball as 2.4.42: > > [ ] +1: It's not just good, it's good enough! > > [ ] +0: Let's have a talk. > > [ ] -1: There's trouble in paradise. Here's what's wrong. > > > > The computed digests of the tarball up for vote are: > > sha1: 2e4505796dfaebcceab6ba22e5fa221e07ad488e *httpd-2.4.42.tar.gz > > sha256: cbac6f8211744a74f798db792b74da9f6fb5a4fbee94234cf2b01aeb9ffe57ed > > *httpd-2.4.42.tar.gz > > sha512: > > 09d0f3bd9266907eea91ac9129a3c41658929b9fd88d627c1fccceaf952548d2c3ad62099b9bcd1ae4822402c1dbda90b8bfb9f64cd5eac9f84ed249faffb837 > > *httpd-2.4.42.tar.gz > > > > The SVN tag is '2.4.42' at r1875427. > > > > Looks like r1874288 broke my basic apxs usage w/o DESTDIR in use. > Seems broken in my trunk sandbox too. -1 from me, now fixed in 2.4.x. -- Eric Covener cove...@gmail.com
Re: Still Failing: apache/httpd#500 (2.4.x - 462a0bc)
On Fri, Mar 20, 2020 at 12:28:31PM +, Travis CI wrote: > Build Update for apache/httpd > - > > Build: #500 > Status: Still Failing This is now only failing because of the apxs bug so I'll give Eric the pleasure of making it pass by merging the fix.
Still Failing: apache/httpd#500 (2.4.x - 462a0bc)
Build Update for apache/httpd - Build: #500 Status: Still Failing Duration: 12 mins and 13 secs Commit: 462a0bc (2.4.x) Author: Joe Orton Message: Merge r1875471, r1875472 from trunk: Fix Travis trunk/master confusion, and make the i386 build trunk-only, it has not been adjusted to find PCRE "v1" i386 packages. Fix the travis syntax (should have done it in a PR...). git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1875474 13f79535-47bb-0310-9956-ffa450edef68 View the changeset: https://github.com/apache/httpd/compare/c8b2b80e62f8...462a0bc7c86e View the full build log and details: https://travis-ci.org/github/apache/httpd/builds/664821781?utm_medium=notification_source=email -- You can unsubscribe from build emails from the apache/httpd repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=69847_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
Re: [VOTE] Release httpd-2.4.42
+1: macOS 10.14.6, Xcode 11.3.1: No regressions - Perl test framework Will try to test on CentOS 6-8 today > On Mar 19, 2020, at 10:45 AM, Daniel Ruggeri wrote: > > Hi, all; > Please find below the proposed release tarball and signatures: > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release this candidate > tarball as 2.4.42: > [ ] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. > > The computed digests of the tarball up for vote are: > sha1: 2e4505796dfaebcceab6ba22e5fa221e07ad488e *httpd-2.4.42.tar.gz > sha256: cbac6f8211744a74f798db792b74da9f6fb5a4fbee94234cf2b01aeb9ffe57ed > *httpd-2.4.42.tar.gz > sha512: > 09d0f3bd9266907eea91ac9129a3c41658929b9fd88d627c1fccceaf952548d2c3ad62099b9bcd1ae4822402c1dbda90b8bfb9f64cd5eac9f84ed249faffb837 > *httpd-2.4.42.tar.gz > > The SVN tag is '2.4.42' at r1875427. > > -- > Daniel Ruggeri
Broken: apache/httpd#497 (2.4.x - c8b2b80)
Build Update for apache/httpd - Build: #497 Status: Broken Duration: 12 mins and 34 secs Commit: c8b2b80 (2.4.x) Author: Joe Orton Message: Merge r1875469 from trunk: Test exclsion doesn't work since "tag !~" matches when tag is undefined. Exclude tests from 2.4.x by explicitly matching against master. Will have to revisit this for 2.5.x. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1875470 13f79535-47bb-0310-9956-ffa450edef68 View the changeset: https://github.com/apache/httpd/compare/7b64be8d9bfe...c8b2b80e62f8 View the full build log and details: https://travis-ci.org/github/apache/httpd/builds/664809613?utm_medium=notification_source=email -- You can unsubscribe from build emails from the apache/httpd repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=69847_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
Re: Failed: apache/httpd#484 (2.4.42 - 5ad7f90)
On Thu, Mar 19, 2020 at 04:27:06PM +, Joe Orton wrote:
> On Thu, Mar 19, 2020 at 08:32:25AM -0700, Mike Rumph wrote:
> > Build #484 fails on test #484.13, Linux Ubuntu, Regenerate ap_expr
> > +./buildconf --with-apr=/usr/bin/apr-1-config --with-regen-expr
> > unknown option --with-regen-expr
> > The command "./test/travis run_${TRAVIS_OS_NAME}.sh" exited with 1.
>
> It's something screwy with the conditional on the test, which should not
> run for 2.4.x and is described as:
>
> - if: branch != 2.4.x
> name: Linux Ubuntu, Regenerate ap_expr
>
> but this build is special because it's a tag. Could adjust those tests
> to be "if: branch = master" but then that's wrong when we branch 2.5.x.
> Not obvious how to fix it right now.
>
> Anyway, ignore the failure, everything else passed and it's good ;)
Urghh, apologies for the commit/build spam while I try to fix this.
I think the right way is probably:
if: (branch IS present AND branch != 2.4.x) OR (tag IS present AND tag !~
/^2.4)
and
if: (branch IS present AND branch = 2.4.x) OR (tag IS present AND tag =~
/^2.4)
but I did it the simpler match-against-trunk away. And of course it
should be "trunk" not "master" so r1875469 is also wrong but it's not
giving false negatives for 2.4.x.
Broken: apache/httpd#495 (2.4.x - 7b64be8)
Build Update for apache/httpd - Build: #495 Status: Broken Duration: 14 mins and 38 secs Commit: 7b64be8 (2.4.x) Author: Joe Orton Message: Merge r1875467 from trunk: Match Travis jobs for 2.4.x by tag as well as branch. Ignore failures for s390x which is flaky in apt-get again. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1875468 13f79535-47bb-0310-9956-ffa450edef68 View the changeset: https://github.com/apache/httpd/compare/87b9749a99c8...7b64be8d9bfe View the full build log and details: https://travis-ci.org/github/apache/httpd/builds/664805500?utm_medium=notification_source=email -- You can unsubscribe from build emails from the apache/httpd repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=69847_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
