Re: APR version of support/logresolve.c

2005-10-24 Thread Colm MacCarthaigh
On Mon, Oct 24, 2005 at 06:16:14PM +0200, Joost de Heer wrote: Looks good; some nits: - odd style in places, some if(/while( without enough whitespace and declarations with too much whitespace: apr_file_t * etc; Is there an indent command line overview for 'ASF approved coding'?

Re: svn commit: r327872 - in /httpd/httpd/trunk: CHANGES include/httpd.h server/core_filters.c

2005-10-23 Thread Colm MacCarthaigh
On Sun, Oct 23, 2005 at 10:38:41PM -, [EMAIL PROTECTED] wrote: Modified: httpd/httpd/trunk/server/core_filters.c URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/server/core_filters.c?rev=327872r1=327871r2=327872view=diff

APR version of support/logresolve.c

2005-10-21 Thread Colm MacCarthaigh
support/logresolve doesn't support IPv6 addresses, which is a pain, because while logresolve is not a brilliant log resolver, it's useful for putting at the end of brief command lines, grepping things and so on. Anyway; http://people.apache.org/~colm/logresolve.c is an APR version,

Re: svn commit: r327601 - /httpd/httpd/branches/2.0.x/STATUS

2005-10-21 Thread Colm MacCarthaigh
On Fri, Oct 21, 2005 at 10:48:23PM -, [EMAIL PROTECTED] wrote: Author: rpluem Date: Fri Oct 21 15:48:18 2005 New Revision: 327601 URL: http://svn.apache.org/viewcvs?rev=327601view=rev Log: * Move two backports from proposed to accepted, as they have enough votes now. I don't think

Re: svn commit: r327601 - /httpd/httpd/branches/2.0.x/STATUS

2005-10-21 Thread Colm MacCarthaigh
On Fri, Oct 21, 2005 at 07:40:04PM -0400, Jeff Trawick wrote: I don't think this should be done until the actual code is backported too :-) (someone more clued-in than I can confirm though). Move from proposed to accepted when there are sufficient votes. Remove from STATUS when code is

Re: Win32 binary distributions 2.1.9-beta and onwards

2005-10-11 Thread Colm MacCarthaigh
On Tue, Oct 11, 2005 at 02:07:56AM -0500, William A. Rowe, Jr. wrote: I'm looking for input what version of visual c++ we should build apr 1.x and httpd 2.1.x and onwards with. As most are aware, discrepancies in the clib mean that mismatched posix open()/close(), malloc()/free() can all

Re: [pre-release] 2.0.55 *candidate* available for testing

2005-10-11 Thread Colm MacCarthaigh
On Tue, Oct 11, 2005 at 01:34:16PM +0200, Graham Leggett wrote: We provide SRPMs for building, which contain fixed httpd.spec files. I see people downloading them a fair ammount ( 400 per day, which is actually quite a lot for the binaries section), and I don't see why these would discontinue.

Re: [PATCH] Re: Pluggable mod_log_config

2005-10-06 Thread Colm MacCarthaigh
On Thu, Oct 06, 2005 at 02:06:24PM -0400, Brian Akins wrote: My problem with piped loggers is there is no fast way to make sure you have a complete line. This is especially hard when you buffer the logs. If httpd writes a complete line, to any kind of a file descriptor, anything beyond that

Re: DO NOT REPLY [Bug 36937] New: - mod_cache not respecting mod_access

2005-10-06 Thread Colm MacCarthaigh
I propose that we fix this bug by documenting, very very loudly, that using mod_cache simply breaks mod_authz_host. A Large warning in the mod_cache documentation, the Caching User Guide, the output of configure when mod_cache is enabled, and the error log when mod_cache is loaded is what I'm

Re: DO NOT REPLY [Bug 36937] New: - mod_cache not respecting mod_access

2005-10-06 Thread Colm MacCarthaigh
On Thu, Oct 06, 2005 at 02:00:35PM -0700, Paul Querna wrote: No :) We'd have to have two handlers in order to do that, and it should be noted that creating a non-quick handler for mod_cache is itself a reasonable amount of effort. No it isn't. I should pay more attention. Here is the

Re: httpd-trunk - autoconf garbage

2005-10-05 Thread Colm MacCarthaigh
On Wed, Oct 05, 2005 at 03:04:52PM -0500, William A. Rowe, Jr. wrote: Could whoever introduced this determine how to properly fix it? My bad, fixed now. -- Colm MacCárthaighPublic Key: [EMAIL PROTECTED]

Re: svn commit: r293305 - in /httpd/httpd/branches/2.2.x/modules: dav/fs/dbm.c

2005-10-04 Thread Colm MacCarthaigh
On Mon, Oct 03, 2005 at 08:38:02AM -0400, Jim Jagielski wrote: At the very last, if we are assuming behavior which is specifically implementation dependent, then a test during configure time that ensures sizeof(void *) = sizeof(long) makes sense. There is no room, IMO, for silent hidden

Re: svn commit: r293305 - in /httpd/httpd/branches/2.2.x/modules: dav/fs/dbm.c

2005-10-04 Thread Colm MacCarthaigh
On Tue, Oct 04, 2005 at 08:11:46AM -0400, Jim Jagielski wrote: I do think the error message is wrong though :) *bangs head off of table* Thanks :) -- Colm MacCárthaighPublic Key: [EMAIL PROTECTED]

Re: [PATCH] Re: Pluggable mod_log_config

2005-10-04 Thread Colm MacCarthaigh
On Tue, Oct 04, 2005 at 08:37:08AM -0400, Brian Akins wrote: In this case, from my patches: LogFormat INSERT INTO foo VALUES ('%h', '%l'); foo-sql CustomLog mysql://user:[EMAIL PROTECTED]/database foo-sql and the mysql module would get the arrays of strings and lengths. at init time,

Re: [PATCH] Re: Pluggable mod_log_config

2005-10-04 Thread Colm MacCarthaigh
On Tue, Oct 04, 2005 at 02:59:40PM +0200, Ondrej Sury wrote: No, it cannot be implemented with two netcat commands (just tried it). Sure, it can, use my Multicast Netcat; http://people.heanet.ie/~colmmacc/mnc/ (version 1.3 is experimental and not working right now, avoid that, and I'm

Re: [PATCH] Re: Pluggable mod_log_config

2005-10-04 Thread Colm MacCarthaigh
On Tue, Oct 04, 2005 at 09:15:32AM -0400, Brian Akins wrote: Why not just replace mod_log_config rather than plug into it. Because mod_log_config handles a bunch of stuff for us. May be a better solution would be to use the standard log_config way of replacing init and writer and replace

Re: svn commit: r294809 - in /httpd/httpd/trunk: acinclude.m4 configure.in

2005-10-04 Thread Colm MacCarthaigh
On Tue, Oct 04, 2005 at 02:16:16PM -0500, William A. Rowe, Jr. wrote: Actually I'm also confused, not by the fact that we resolve this test, but exactly what it nets us. It makes sure that a void * container can store the largest of the types we ocasionally place in such a container. It

Re: svn commit: r294902 - /httpd/httpd/trunk/acinclude.m4

2005-10-04 Thread Colm MacCarthaigh
On Tue, Oct 04, 2005 at 03:35:29PM -0400, Jim Jagielski wrote: -if test $ap_void_ptr_lt_long = no; then +if test $ap_void_ptr_lt_long = yes; then AC_MSG_ERROR([Size of void * is less than size of long]) Don't shoot me :) The problem is whether or not a pointer will fit in a

Re: svn commit: r291914 - /httpd/httpd/trunk/server/request.c

2005-10-03 Thread Colm MacCarthaigh
On Mon, Oct 03, 2005 at 03:50:34PM +0100, Joe Orton wrote: gcc 4 is giving a warning: request.c: In function `ap_sub_req_method_uri': request.c:1584: warning: 'res' might be used uninitialized in this function Bah, stupid compilers and their invalid warnings :) I'll fix that. -- Colm

Re: [PATCH] Re: Pluggable mod_log_config

2005-10-03 Thread Colm MacCarthaigh
On Mon, Oct 03, 2005 at 11:40:27AM -0400, Brian Akins wrote: CustomLog mysql://something common env=images CustomLog file:///logs/my.log combined CustomLog spread://somegroup refere CustomLog buffer:///logs/other.log common This patch implements the above. Within mod_log_config two

Re: [PATCH] Re: Pluggable mod_log_config

2005-10-03 Thread Colm MacCarthaigh
On Mon, Oct 03, 2005 at 11:40:27AM -0400, Brian Akins wrote: Akins, Brian wrote: CustomLog mysql://something common env=images CustomLog file:///logs/my.log combined CustomLog spread://somegroup refere CustomLog buffer:///logs/other.log common I've been looking more at this, and I'm kind

Re: [PATCH] Use rsync to install manual

2005-09-30 Thread Colm MacCarthaigh
On Thu, Sep 29, 2005 at 10:03:32PM -0700, Justin Erenkrantz wrote: This greatly speeds up installation. =) So, any objections to committing? -- justin Yes :) Please don't use the -a option for rsync. use -rlptDv instead; we shouldn't be trouncing the ownership of the destination files, cp

Re: [PATCH] Use rsync to install manual

2005-09-30 Thread Colm MacCarthaigh
On Fri, Sep 30, 2005 at 10:07:28AM +0100, Nick Kew wrote: Sounds sensible in principle. Excuse my autofoo ignorance, but how does it handle the case where, for example, rsync is available but fails due to a local firewall? rsync won't use sockets, or any kind of networking when doing local

Re: new/update mod_smtpd modules

2005-09-30 Thread Colm MacCarthaigh
On Fri, Sep 30, 2005 at 08:54:05AM -0500, Brian J. France wrote: mod_smtpd_clamd.tar.gz This is a module that sends the mail to clamd on the data_post hook. It only works with TCP connections to clamd because apr doesn't support unix domain sockets. Unix Domain sockets are not

2.3.0 CHANGES

2005-09-29 Thread Colm MacCarthaigh
*) Teach mod_ssl to use arbitrary OIDs in an SSLRequire directive, allowing string-valued client certificate attributes to be used for access control, as in: SSLRequire value in OID(1.3.6.1.4.1.18060.1) [Martin Kraemer, David Reid] Should that be PeerExtList rather than OID, in the

Re: 2.3.0 CHANGES

2005-09-29 Thread Colm MacCarthaigh
On Thu, Sep 29, 2005 at 07:32:39PM +0100, David Reid wrote: Colm MacCarthaigh wrote: *) Teach mod_ssl to use arbitrary OIDs in an SSLRequire directive, allowing string-valued client certificate attributes to be used for access control, as in: SSLRequire value in OID(1.3.6.1.4.1.18060.1

Re: mod_cache brokenness test

2005-09-27 Thread Colm MacCarthaigh
On Tue, Sep 27, 2005 at 11:10:29AM +0100, Joe Orton wrote: Is it vaguely right? And can I commit it? Some nits but otherwise go ahead, great! 1. use VirtualHost mod_cache - the _default_: is not necessary AFAIK 2. use just need 'cache', 'disk_cache' for the requirements Excellent, even

Re: which apr(-util) versions for 2.2.x?

2005-09-27 Thread Colm MacCarthaigh
On Tue, Sep 27, 2005 at 04:39:19PM +0200, Graham Leggett wrote: Joe Orton said: I think it would actually be sensible at this point to require apr/apr-util = 1.2.0 across the board. +1. +1 I might be adding = 1.3.0 dependencies to trunk soon too, in the form of configurable buffer

Re: 2.1.8-beta available for Testing and Voting

2005-09-27 Thread Colm MacCarthaigh
On Sun, Sep 25, 2005 at 05:15:43PM -0700, Paul Querna wrote: Please report on testing experiences and (if applicable) vote on releasing httpd 2.1.8-BETA. +1, tested on Ubuntu and Debian, with 3 days of usage on ftp.heanet.ie. -- Colm MacCárthaighPublic Key: [EMAIL

Re: 2.1.8-beta available for Testing and Voting

2005-09-27 Thread Colm MacCarthaigh
On Tue, Sep 27, 2005 at 11:16:18AM -0500, William A. Rowe, Jr. wrote: The 2.1.8 tarball no longer includes the XML Files for generating the documentation. Only the generated HTML Files are packaged. -1 - this doesn't help folks contribute patches to docs. We were already removing the .xml$

Re: mod_dir + caching brokenness

2005-09-26 Thread Colm MacCarthaigh
On Wed, Sep 21, 2005 at 05:52:46PM +0100, Colm MacCarthaigh wrote: On Wed, Sep 21, 2005 at 05:27:49PM +0100, Colm MacCarthaigh wrote: I'd like to apply this patch, but I have a feeling there must be some undocumented reason it's not like this already. Any thoughts? Hmmm, some more testing

Re: 2.1.8-beta available for Testing and Voting

2005-09-26 Thread Colm MacCarthaigh
On Sun, Sep 25, 2005 at 05:15:43PM -0700, Paul Querna wrote: Please report on testing experiences and (if applicable) vote on releasing httpd 2.1.8-BETA. We really want both positive and all negative experiences with this release. The more bugs we find now, the better the 2.2.0 GA release

Re: Issues for 2.1.8

2005-09-21 Thread Colm MacCarthaigh
On Tue, Sep 20, 2005 at 10:58:16PM -0500, William A. Rowe, Jr. wrote: Because --with-foo / --without-foo syntax gives **NO** indication to the user, or indication from the user, that they are willing to use experimental code. That's easy to fix, we can do the same thing we do for the

mod_dir + caching brokenness

2005-09-21 Thread Colm MacCarthaigh
mod_dir insists on the indeces being regular files, which breaks with mod_cache in a particularly nasty way. mod_cache doesn't fill out rr-finfo for speed reasons, and because it's not always a file that the cached entity is coming from. The result is; make request for / -

Re: mod_dir + caching brokenness

2005-09-21 Thread Colm MacCarthaigh
On Wed, Sep 21, 2005 at 05:27:49PM +0100, Colm MacCarthaigh wrote: I'd like to apply this patch, but I have a feeling there must be some undocumented reason it's not like this already. Any thoughts? Hmmm, some more testing shows that what's going on isn't nearly so simple. I'll come back

Re: Issues for 2.1.8

2005-09-20 Thread Colm MacCarthaigh
On Tue, Sep 20, 2005 at 10:07:04PM +0200, [EMAIL PROTECTED] wrote: Especially for mod_filter I think we should ensure that it is contained in 2.2 as it was announced as one of the new features of 2.2 at the ApacheCon. Same goes for the event MPM, which is marked experimental. We shouldn't lose

Re: Issues for 2.1.8

2005-09-20 Thread Colm MacCarthaigh
On Tue, Sep 20, 2005 at 03:58:36PM -0500, William A. Rowe, Jr. wrote: And best yet, the developers *should* encourage other devs and power users to try out snapshots until they are beta quality. Drop them into httpd.apache.org/dev/dist/ - that's where unstable/unproven code really belongs.

Re: Issues for 2.1.8

2005-09-20 Thread Colm MacCarthaigh
On Tue, Sep 20, 2005 at 02:01:07PM -0700, Paul Querna wrote: So, lets change the VERSIONING file/policy. Experimental Modules will be included in the stable branch. Majority Agree? +1 -- Colm MacCárthaighPublic Key: [EMAIL PROTECTED]

Re: Issues for 2.1.8

2005-09-20 Thread Colm MacCarthaigh
On Tue, Sep 20, 2005 at 04:58:05PM -0500, William A. Rowe, Jr. wrote: And all the more reason they can't exist in stable. You *CAN'T* change the API of any shipped module, because you are forced to bump the module major if the resulting change is ABI-incompatible. That hurts every third

Re: [PATCH] mod_smtpd_queue_smtp

2005-09-18 Thread Colm MacCarthaigh
On Sat, Sep 17, 2005 at 04:40:14PM -0700, Garrett Rooney wrote: +static const command_rec smtpd_queue_smtp_cmds[] = { +AP_INIT_FLAG(SmtpQueueSmtp, enable_queue_smtp, NULL, RSRC_CONF, + Enable queuing to another SMTP server. Default: Off), + +

Re: Bandwidth Limit on Windows

2005-09-15 Thread Colm MacCarthaigh
On Thu, Sep 15, 2005 at 03:26:49PM -0500, William A. Rowe, Jr. wrote: So how to figure out if we are making progress? I'm unsure and this all deserves another look at the current state of the Win32 sockets API, I haven't fallen down that well in a good long time :) I have, it's painful ;)

Re: svn commit: r280393 - /httpd/httpd/branches/2.0.x/STATUS

2005-09-12 Thread Colm MacCarthaigh
Anyone object to me removing line 124 in server/listen.c in trunk ? 117if (receive_buffer_size) { 118stat = apr_socket_opt_set(s, APR_SO_RCVBUF, receive_buffer_size); 119if (stat != APR_SUCCESS stat != APR_ENOTIMPL) { 120ap_log_perror(APLOG_MARK, APLOG_WARNING,

Re: How long until 2.2

2005-09-09 Thread Colm MacCarthaigh
On Fri, Sep 09, 2005 at 04:18:34PM -0400, Bill Stoddard wrote: I guess for some definition of much I am not suprised. I would expect the event MPM to consume more CPU than worker under 'low' workloads (low number of concurrent clients) because it's making more system calls to do the same

Re: svn commit: r264788 - /httpd/httpd/trunk/modules/generators/mod_cgid.c

2005-08-31 Thread Colm MacCarthaigh
On Tue, Aug 30, 2005 at 07:58:01PM -0700, Paul Querna wrote: [EMAIL PROTECTED] wrote: Author: colm Date: Tue Aug 30 07:28:48 2005 New Revision: 264788 URL: http://svn.apache.org/viewcvs?rev=264788view=rev Log: If uid_t and gid_t are unsigned on a platform (hurd, for example),

Re: svn commit: r264737 - /httpd/httpd/trunk/docs/manual/stopping.xml

2005-08-31 Thread Colm MacCarthaigh
On Wed, Aug 31, 2005 at 10:24:49AM +0100, Joe Orton wrote: Apologies for the previous empty mail ;) If the performance difference is that small then mod_cgi is definitely a better default IMO: it has much better stderr handling (the CGI bucket stuff) and it will log to the correct

Re: svn commit: r265523 - in /httpd/httpd/trunk/server/mpm: experimental/event/event.c experimental/leader/leader.c experimental/threadpool/threadpool.c prefork/prefork.c

2005-08-31 Thread Colm MacCarthaigh
On Wed, Aug 31, 2005 at 01:02:55PM -0400, Jeff Trawick wrote: Initiliase all of the first_*_limit variables to zero, so that we can actually raise limits beyond their defaults reliably. How can a C-language global variable not be initialized to zero? A gcc ia64 bug, possibly. I can't

Re: svn commit: r265523 - in /httpd/httpd/trunk/server/mpm: experimental/event/event.c experimental/leader/leader.c experimental/threadpool/threadpool.c prefork/prefork.c

2005-08-31 Thread Colm MacCarthaigh
On Wed, Aug 31, 2005 at 06:11:21PM +0100, Colm MacCarthaigh wrote: On Wed, Aug 31, 2005 at 01:02:55PM -0400, Jeff Trawick wrote: Initiliase all of the first_*_limit variables to zero, so that we can actually raise limits beyond their defaults reliably. How can a C-language global

Re: Status of 2.1.7g

2005-08-30 Thread Colm MacCarthaigh
On Mon, Aug 29, 2005 at 09:58:12PM -0700, Paul Querna wrote: We did find several non-showstopper issues with this tag. If anyone has a few spare minutes, it would be good to start back porting these from trunk to the 2.2.x branch. http://people.apache.org/~colm/2.1.7-non-showstoppers.patch

Re: svn commit: r264737 - /httpd/httpd/trunk/docs/manual/stopping.xml

2005-08-30 Thread Colm MacCarthaigh
On Tue, Aug 30, 2005 at 08:24:17AM -, [EMAIL PROTECTED] wrote: Modified: httpd/httpd/trunk/docs/manual/stopping.xml URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/docs/manual/stopping.xml?rev=264737r1=264736r2=264737view=diff

Re: svn commit: r264737 - /httpd/httpd/trunk/docs/manual/stopping.xml

2005-08-30 Thread Colm MacCarthaigh
On Tue, Aug 30, 2005 at 05:25:07PM +0100, Joe Orton wrote: This has all sorts of consequences, the most annoying of which is that both stop and graceful-stop actually won't kill CGI processes when using a threaded MPM/cgid. So is mod_cgid still the default CGI module for worker because

Re: svn commit: r264737 - /httpd/httpd/trunk/docs/manual/stopping.xml

2005-08-30 Thread Colm MacCarthaigh
On Tue, Aug 30, 2005 at 06:00:47PM +0100, Colm MacCarthaigh wrote: On Tue, Aug 30, 2005 at 05:25:07PM +0100, Joe Orton wrote: This has all sorts of consequences, the most annoying of which is that both stop and graceful-stop actually won't kill CGI processes when using a threaded MPM

Re: Status of 2.1.7

2005-08-30 Thread Colm MacCarthaigh
On Tue, Aug 30, 2005 at 04:22:33PM -0500, William A. Rowe, Jr. wrote: I'm concerned about a number of significant instability reports on 2.0.x, never mind 2.1.x, in bugzilla, and don't think this is quite ready to ship. For what it's worth I consider the trunk branch more stable than 2.0.x.

Re: Status of 2.1.7g

2005-08-30 Thread Colm MacCarthaigh
On Tue, Aug 30, 2005 at 02:47:05PM -0700, Justin Erenkrantz wrote: --On August 30, 2005 8:54:57 AM -0400 Jeff Trawick [EMAIL PROTECTED] wrote: http://people.apache.org/~colm/2.1.7-non-showstoppers.patch +1 on all that for the 2.2.x branch in any case. +1 here as well +1 too on that

Re: Status of 2.1.7

2005-08-30 Thread Colm MacCarthaigh
On Tue, Aug 30, 2005 at 11:54:04PM +0200, [EMAIL PROTECTED] wrote: Since Apachecon EU, it's also been running the worker MPM (on IA64). and performance is up by around 9% in our benchmarks. In trunk's STATUS Just curious. So you switched from your prefork configuration that was presented

Re: Status of 2.1.7

2005-08-30 Thread Colm MacCarthaigh
On Wed, Aug 31, 2005 at 12:10:33AM +0200, [EMAIL PROTECTED] wrote: Yep, and it's faster, by about 9%. We've also done some other crazy things; What is the ThreadsPerChild setting you use? currently using; IfModule worker.c ServerLimit 900 StartServers200 MaxClients

XML docs in release tarballs

2005-08-28 Thread Colm MacCarthaigh
dist/tools/roll.sh currently has; echo echo Removing Manual Files. echo find $dirname/docs/manual -name \*.xml -print | xargs rm -rf Which is incompatible with the current layout of docs, but which is the right way to fix it? Just remove the rm entirely, or remove all of the

Re: PATCH PR-36368 DisallowPost

2005-08-27 Thread Colm MacCarthaigh
On Fri, Aug 26, 2005 at 02:56:21PM -0700, Russell Miller wrote: We wanted to disallow the POST method, because for our purposes we wanted the arguments to said calls to be logged in the access log. We considered using LimitExcept, but upon trying it, I saw that a 403 error was returned, and

Re: PATCH PR-36368 DisallowPost

2005-08-27 Thread Colm MacCarthaigh
On Sat, Aug 27, 2005 at 04:19:45PM +0100, Nick Kew wrote: httpd can't predict what methods the resource will accept. If it's rejecting a request based on Limit(Except), it can infer a list of allowed methods from that. I guess, but there's no knowing the the CGI itself would then accept is

Re: PATCH PR-36368 DisallowPost

2005-08-27 Thread Colm MacCarthaigh
On Sat, Aug 27, 2005 at 08:41:30PM +0100, Colm MacCarthaigh wrote: I think we have our wires crossed, I'm mean it's a bug My fault too, stupid missing carriage-return, hmmm, Status: probably shouldn't be picked up either though. -- Colm MacCárthaighPublic Key: [EMAIL

Re: svn commit: r240270 - in /httpd/httpd/trunk: CHANGES server/mpm/prefork/mpm.h server/mpm/prefork/prefork.c

2005-08-26 Thread Colm MacCarthaigh
I decided to do prefork first, since it seems the more complicated out of the MPM's to stop gracefully. I've tested locally, using #!/bin/sh echo Content-type: text/plain echo while true; do sleep 1 date done as my

Graceful stop implementation nits

2005-08-25 Thread Colm MacCarthaigh
Now that the ap_close_listeners() code is committed, implementing a graceful stop is relatively trivial, I already have it working here for me. However there are some complicated nits which I thought I'd solicit feedback on. One of the main benefits of a graceful stop is to allow for upgrading

Re: Graceful stop implementation nits

2005-08-25 Thread Colm MacCarthaigh
On Thu, Aug 25, 2005 at 11:17:29AM +0100, Joe Orton wrote: apachectl graceful-stop apachectl start and have it work as the admin would expect, but this leads to some complications. Files like the ScriptSock, ScoreBoardFile, SSLSessionCache, LockFile, LDAPSharedCacheFile and so

Re: 2.1.7 Available for Testing Voting

2005-08-25 Thread Colm MacCarthaigh
On Thu, Aug 25, 2005 at 09:09:18AM -0400, Jeff Trawick wrote: Apache may fail to initialize on AIX with a generic Listen directive e.g. Listen 10101 - (67)Address already in use: make_sock: could not bind to address [::]:10101 I don't know why this would be AIX-specific. Server

Re: svn commit: r240044 - in /httpd/httpd/trunk: CHANGES

2005-08-25 Thread Colm MacCarthaigh
On Thu, Aug 25, 2005 at 09:14:55AM -0400, Jim Jagielski wrote: +1... The 2.1/2.2 docs should be updated to note that I think :) You know, we'll be doing this enough that it really should be an ap_call... ap_append_pid() ;) I think I'll add this in, I have some free cycles opening up...

Re: 2.1.7 Available for Testing Voting

2005-08-25 Thread Colm MacCarthaigh
On Thu, Aug 25, 2005 at 10:11:01AM -0400, Jeff Trawick wrote: first entry: AF_INET; 0.0.0.0:8080 second (last) entry: AF_INET6; [::]:8080 Yuck, We'll have to re-order the list so, or change the listen.c logic. But if it is the other way around: Get AF_INET6 socket first and set

Re: 2.1.7 Available for Testing Voting

2005-08-25 Thread Colm MacCarthaigh
On Thu, Aug 25, 2005 at 03:17:37PM +0100, Colm MacCarthaigh wrote: On Thu, Aug 25, 2005 at 10:11:01AM -0400, Jeff Trawick wrote: first entry: AF_INET; 0.0.0.0:8080 second (last) entry: AF_INET6; [::]:8080 Yuck, We'll have to re-order the list so, or change the listen.c logic. O.k

Re: 2.1.7 Available for Testing Voting

2005-08-25 Thread Colm MacCarthaigh
On Thu, Aug 25, 2005 at 03:31:18PM +0100, Colm MacCarthaigh wrote: On Thu, Aug 25, 2005 at 03:17:37PM +0100, Colm MacCarthaigh wrote: On Thu, Aug 25, 2005 at 10:11:01AM -0400, Jeff Trawick wrote: first entry: AF_INET; 0.0.0.0:8080 second (last) entry: AF_INET6; [::]:8080 Yuck

Re: 2.1.7 Available for Testing Voting

2005-08-25 Thread Colm MacCarthaigh
On Thu, Aug 25, 2005 at 03:33:59PM +0100, Colm MacCarthaigh wrote: O.k., does this fix it; Eh, it doesn't, never mind. This on the other hand, might ; Index: server/listen.c === --- server/listen.c (revision 239742

Re: 2.1.7 Available for Testing Voting

2005-08-25 Thread Colm MacCarthaigh
On Thu, Aug 25, 2005 at 11:29:17AM -0400, Jeff Trawick wrote: With this patch I can tell from syscall trace that we only get one socket now. But server dies mysteriously later. The mysterious death doesn't occur with Listen 0.0.0.0:8080 so it is apparently related to this socket management.

Re: mod_cache wishlist

2005-08-24 Thread Colm MacCarthaigh
On Wed, Aug 24, 2005 at 09:18:54AM -0500, Parin Shah wrote: I have fixed that memory leak problem. also added script to include libcurl whenever this module is included. I hope that it doesn't mean that libcurl is going to be a permanent solution, when subrequests (with minor changes)

Re: svn commit: r239711 - /httpd/httpd/trunk/server/mpm/prefork/prefork.c

2005-08-24 Thread Colm MacCarthaigh
On Wed, Aug 24, 2005 at 08:08:51PM +0100, Joe Orton wrote: On Wed, Aug 24, 2005 at 12:02:37PM -0700, Justin Erenkrantz wrote: --On August 24, 2005 4:58:14 PM + [EMAIL PROTECTED] wrote: This means that the listening sockets are freed for re-use. In the ordinary case, this makes no

Re: svn commit: r239711 - /httpd/httpd/trunk/server/mpm/prefork/prefork.c

2005-08-24 Thread Colm MacCarthaigh
On Wed, Aug 24, 2005 at 08:21:35PM +0100, Joe Orton wrote: It's not fixed *just* yet, only in prefork, and the PR reporter was using worker. I had found the PR ;) Duh, I missed that, sorry. Oh I'm well ahead in the Duh stats ;) I've updated the CHANGES and PR anyway, thanks for the

Re: some problem about mod_ftpd

2005-08-23 Thread Colm MacCarthaigh
On Tue, Aug 23, 2005 at 11:45:11AM +0800, firingme wrote: Next, there isn't any cache mechanism in the storretr's handler, I think maybe mod_disk_cache can help here. In addition to mod_ftpd, there is also mod_ftp, which is in the process of becoming an incubated httpd subproject;

Re: mod_cache wishlist

2005-08-23 Thread Colm MacCarthaigh
On Tue, Aug 23, 2005 at 08:42:48AM -0400, Brian Akins wrote: Deterministic temp files to avoid thundering herd: http://marc.theaimsgroup.com/?l=apache-httpd-devm=112430743432417w=2 Especially Colm's comments: Content definitely should not be served from the cache after it has expired

Re: mod_cache wishlist

2005-08-23 Thread Colm MacCarthaigh
On Tue, Aug 23, 2005 at 10:18:37AM -0400, Brian Akins wrote: I've been looking at this, and it's possibly the Syntax that put me off, but it looks painful on the admin, and probably on the server too. There's nothing in those examples that can't be achieved by making the non-CacheEnable cache

Re: svn commit: r239436 - /httpd/httpd/trunk/support/htcacheclean.c

2005-08-23 Thread Colm MacCarthaigh
On Tue, Aug 23, 2005 at 12:05:13PM -0700, Justin Erenkrantz wrote: --On August 23, 2005 5:03:03 PM + [EMAIL PROTECTED] wrote: Add APR_FOPEN_BINARY to the options passed to apr for opening the cache header files. Why? Because mod_disk_cache uses; APR_CREATE | APR_WRITE |

Re: svn commit: r239459 - in /httpd/httpd/trunk/docs/manual: caching.xml images/caching_fig1.gif images/caching_fig1.png index.xml

2005-08-23 Thread Colm MacCarthaigh
On Tue, Aug 23, 2005 at 10:32:25PM +0200, André Malo wrote: A first take at a User-Guide for caching. Covers mod_cache and mod_file_cache, and tries to place the caching modules in context. Much stuff :) Anyway. indent elements are only meant for example sections (to prevent the use of

Re: 2.1.7 Available for Testing Voting

2005-08-22 Thread Colm MacCarthaigh
On Mon, Aug 22, 2005 at 11:16:57AM -0400, Jeff Trawick wrote: Any reasonable place to put release notes like the following form? some compilers may not like C++ comments and fail to build, showing an error on line XXX of apr_dbd_internal.h; if that occurs, delete that line and re-run

Re: 2.1.7 Available for Testing Voting

2005-08-22 Thread Colm MacCarthaigh
On Mon, Aug 22, 2005 at 05:00:04PM +0100, Nick Kew wrote: Also; htcacheclean is known not to work in this beta, and if used will consistently delete the entire contents of a cache-store. Please apply the $patch, if you intend to use htcacheclean. That sounds to me like a

Re: 2.1.7 Available for Testing Voting

2005-08-22 Thread Colm MacCarthaigh
On Mon, Aug 22, 2005 at 12:59:12PM -0400, Jeff Trawick wrote: yes; handles both families for Listen [::]:10101 so better work-around IF THIS PROBLEM OCCURS is to use that form of Listen ./configure --enable-v4-mapped should fix it, no? -- Colm MacCárthaighPublic

Re: Rolling 2.1.7 On Friday

2005-08-21 Thread Colm MacCarthaigh
On Sun, Aug 21, 2005 at 11:15:43AM -0400, Joshua Slive wrote: http://people.heanet.ie/~colmmacc/manual/misc/cachingguide.html.en Which is about half done. Comments contributions welcome. Looks good. A few comments: See docs like env.html, sections.html, and logs.html for an example

Re: svn commit: r234108 - in /httpd/httpd/branches/2.2.x: CHANGES modules/metadata/mod_setenvif.c

2005-08-20 Thread Colm MacCarthaigh
On Sat, Aug 20, 2005 at 06:39:08PM -, [EMAIL PROTECTED] wrote: -Changes with Apache 2.3.0 +Changes with Apache 2.1.7 + [Remove entries to the current 2.0 section below, when backported] This line is a bit confusing to non-developers, should it be in a (even beta) release CHANGES file?

Re: svn commit: r234108 - in /httpd/httpd/branches/2.2.x: CHANGES modules/metadata/mod_setenvif.c

2005-08-20 Thread Colm MacCarthaigh
On Sat, Aug 20, 2005 at 02:09:40PM -0700, Paul Querna wrote: The code came out, but not the documentation. The oid stuff is still in mod_setenvif.(xml|html.en), which means a non-existant feature is documented. Not sure if that's worth rolling a new tarball for. No, I don't think so, we

Re: svn commit: r234108 - in /httpd/httpd/branches/2.2.x: CHANGES modules/metadata/mod_setenvif.c

2005-08-20 Thread Colm MacCarthaigh
On Sat, Aug 20, 2005 at 02:38:45PM -0700, Paul Querna wrote: Sounds fine. In related not-a-blocker spirit, where do I find whatever is being used to roll the tarballs? (possibly stupid question). It's rm'ing the \.xml$ files but not xml.ja, xml.ko, xml.de and so on, which in turn

Re: Rolling 2.1.7 On Friday

2005-08-19 Thread Colm MacCarthaigh
In this spirit, a major new feature of httpd-2.2 will be reliably working Caching, but the documentation on Caching is a bit tough on users right now. I'm currently working on this; http://people.heanet.ie/~colmmacc/manual/misc/cachingguide.html.en Which is about half done. Comments

Re: [PATCH] mod_disk_cache deterministic tempfiles

2005-08-18 Thread Colm MacCarthaigh
On Wed, Aug 17, 2005 at 03:17:41PM -0700, Justin Erenkrantz wrote: Content definitely should not be served from the cache after it has expired imo. However I think an approach like; if((now + interval) expired) { if(!stat(tmpfile)) { update_cache_from_backend();

Re: [PATCH] mod_disk_cache: speed up read_table

2005-08-18 Thread Colm MacCarthaigh
On Thu, Aug 18, 2005 at 09:22:13AM -0400, Brian Akins wrote: Thanks to all who reminded me what a dumb-a## I am this morning... I forgot the patch. Here it is. Cool. diff -ru httpd-trunk.orig/modules/cache/mod_disk_cache.c httpd-trunk.new2/modules/cache/mod_disk_cache.c ---

Re: [PATCH] mod_disk_cache: speed up read_table

2005-08-18 Thread Colm MacCarthaigh
On Thu, Aug 18, 2005 at 10:43:41AM -0400, Brian Akins wrote: I can understand why this is faster, I'm guessing that you've enough RAM that you're retrieving files from the vmcache and that the higher-layer buffering is just overhead. This is probably going to be the majority case, but would do

Re: [PATCH] mod_disk_cache: speed up read_table

2005-08-18 Thread Colm MacCarthaigh
On Thu, Aug 18, 2005 at 12:11:56PM -0400, Brian Akins wrote: Yep, but there are definite speed-up's to be had. I'm going to canibalise your patch and try some of the above anyway. Cool. I'd be willing to help. I'll be putting on-line all of my TODO's and patches-in-progress shortly, I have

Re: [PATCH] mod_disk_cache deterministic tempfiles

2005-08-18 Thread Colm MacCarthaigh
On Thu, Aug 18, 2005 at 10:07:29AM -0700, Justin Erenkrantz wrote: Okay. I see what you mean now. If the interval is configurable via a directive, then yes that makes sense. This could be done independently of deterministic tempfiles. It could, though it would require using a seperate

Re: [PATCH] mod_disk_cache: speed up read_table

2005-08-18 Thread Colm MacCarthaigh
On Thu, Aug 18, 2005 at 10:43:45AM -0700, Justin Erenkrantz wrote: None of the code in mod_disk_cache used buffering before I turned it on. It gave significant speedups in my performance tests by reducing the syscall overhead. I also had identified and fixed some bugs in apr's buffering

Re: [PATCH] mod_disk_cache deterministic tempfiles

2005-08-18 Thread Colm MacCarthaigh
On Thu, Aug 18, 2005 at 01:39:18PM -0400, Brian Akins wrote: Dead process is solveable with IPC, the existing locking schemes should be enough for this. The hard problem I think is when a backend has stalled. Can't think of an easy fix for that case. When you stat the temp file, if its

Re: [PATCH] mod_disk_cache deterministic tempfiles

2005-08-18 Thread Colm MacCarthaigh
On Thu, Aug 18, 2005 at 02:00:52PM -0400, Brian Akins wrote: Colm MacCarthaigh wrote: So mtime not being recent is no-indication of death, it could easily be a trickling download. True. But, if the files mtime has not changed in 120 seconds (for example) the download is probably hung

Re: RFC: can I make mod_cache per-dir?

2005-08-17 Thread Colm MacCarthaigh
On Tue, Aug 16, 2005 at 10:44:11PM -0700, Paul Querna wrote: We'd certainly sacrifice some speed under these circumstances; but it'd perhaps be better than nothing and would avoid the possibility where we serve content that is now excluded. -- justin IMO, this is why we should revive

Re: [PATCH] mod_disk_cache deterministic tempfiles

2005-08-17 Thread Colm MacCarthaigh
On Wed, Aug 17, 2005 at 04:13:37PM -0400, Brian Akins wrote: Graham Leggett wrote: The disk cache might be a bit more involved, but the idea would be the same. Only way I can think of this is to keep trying to seek until file gets renamed. Maybe not very efficient. Why bother renaming

Re: [PATCH] mod_disk_cache deterministic tempfiles

2005-08-17 Thread Colm MacCarthaigh
On Wed, Aug 17, 2005 at 04:33:24PM -0400, Brian Akins wrote: True. But like Graham said, ultimately, I don't think it's worth it. I got the opposite from what Graham said, but may have mis-read. Not to be biased, but I think my idea of serving recently expired objects would also avoid the

Re: [PATCH] mod_disk_cache deterministic tempfiles

2005-08-17 Thread Colm MacCarthaigh
On Wed, Aug 17, 2005 at 04:11:01PM -0400, Brian Akins wrote: I have the thought that we could also serve files that have recently expired (recent being configurable) if the object was being cached. Psudocode: if(expired (now - recent)) { Content definitely should not be served from the

Re: mod_dnsbl_lookup 0.90

2005-08-16 Thread Colm MacCarthaigh
On Mon, Aug 15, 2005 at 11:11:46PM -0500, Jem Berkes wrote: I did start to implement software side caching in mod_dnsbl_lookup but it raised questions as to whether it's appropriate to have global scale caching when we're doing connection and request oriented processing. So I've left

[PATCH] Make CacheEnable useful for forward proxies

2005-08-16 Thread Colm MacCarthaigh
More mod_cache fix-ups; CacheEnable / isn't very useful for forward proxy servers. This patch makes; CacheEnable / CacheEnable ftp:// CacheEnable http://somesite/ CacheDisablewww.apache.org/blah/ CacheDisableftp://

Re: RFC: can I make mod_cache per-dir?

2005-08-16 Thread Colm MacCarthaigh
On Tue, Aug 16, 2005 at 06:02:04PM -0700, Justin Erenkrantz wrote: The quick handler runs well before any knowledge is available about the backend (dir/file). The only thing you know is the URI path: unsurprisingly, this is all that CacheEnable and CacheDisable can reasonably work with. It's

<    1   2   3   4   5   >