in a
listing. A folder full of [modules-dev] Re: pr is not useful.
I would suspect that anyone asking for crap in the subject line
needs to rtfm procmail, or whatever other tools they have available.
Sorting of incoming mail has been a solved problem for over 20 years.
--
Nick Kew
Application Development
of arbitrary headers.
Please review. If people like this (or if noone objects and I
find the time), I'll document it and commit to /trunk/.
--
Nick Kew
Index: mod_headers.c
===
--- mod_headers.c (revision 450806)
+++ mod_headers.c (working
On Thursday 28 September 2006 18:29, Garrett Rooney wrote:
On 9/28/06, Nick Kew [EMAIL PROTECTED] wrote:
We have a problem with DAV + SSL hardware.
It appears to be the issue described in
http://svn.haxx.se/users/archive-2006-03/0549.shtml
It seems to me that the ability to rewrite
for dealing with headers-fixup being
called multiple times over things like mod_dir/mod_negotiation internal
redirects, leading to it being applied an indeterminate number of times.
The alternative is to save state there.
--
Nick Kew
that doesn't rely on confusing parentheses:
if (rv = do_something(args), rv == APR_SUCCESS)
Can I suggest adopting this as a guideline for new code,
to avoid this kind of bug?
[1] PR#40656 and 40658-40662
--
Nick Kew
-
this is a mailer, not a program editor. But you get the point).
--
Nick Kew
compilers, though I haven't tested it.
It's been clearly defined by ANSI C for as long as ANSI C has existed.
I'm pretty sure it was KR before that, too.
--
Nick Kew
On Wednesday 04 October 2006 19:04, Jim Jagielski wrote:
But that comma method is an abomination ;)
Heh. Is a sequence of statements separated by semicolons an abomination too?
--
Nick Kew
))
Ahem. Apache is supposed to be portable, but AIUI strcasestr is nonstandard.
The second patch (balancer.patch) modifies the behaviour of the
balancer to overcome some of the caveats I mentioned earlier.
(not reviewed - more think-time needed for that)
--
Nick Kew
to deal with that
kind of thing.
Maybe we could come up with a standard bunch of macros to
#include for that kind of thing. But I suspect that would be more
work than doing it ad-hoc, precisely because we don't have a
handy list of issues.
--
Nick Kew
the patches.
* They may be utterly bogus, yet the reporter just reopens them if we
close them.
| Total 739 bugs
That's the bottom line of what makes a flat list like this useless, IMO.
--
Nick Kew
are to say if mod_foo is loaded, then be sure to run mod_foo's
hook in this position before|after mine. It'll work perfectly well (and just
not do anything) if mod_foo is not loaded.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.prenhallprofessional.com/title
in the existing
code, registered as an optional function. Doesn't that mean
AN Other module can register its own int:foo functions, and
the documentation is wrong?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.prenhallprofessional.com/title/0132409674
here?
Yes, it's a case of may change. But since we have the two separate cases
of dbd and fastdbd, I guess it would make sense for the latter to cache.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.prenhallprofessional.com/title/0132409674
, not even the one with
static char strings:
apr_table_set(server_config.approved_items, my_key, my_value);
apr_table_set(server_config.approved_items, key2, value2);
These should be done under mutex, fwiw.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http
things
related to the children and the scoreboard or other shm, a
pre_mpm hook might serve.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
?
Of course. The module just needs to export an accessor function,
to access either the hash itself or the value of a given key.
Use APR_OPTIONAL if you want to keep them fully independent
at link time.
I suppose that I have to use apr_shm_t (and apr_rmm_init??).
Erm, why?
--
Nick Kew
, exporting_module);
return cfg-hash;
}
Or variants thereupon.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.prenhallprofessional.com/title/0132409674
to mod_diagnostics?
If so, how does it differ?
--
Nick Kew
as
read-only when processing a request.
For per-request data, you use it with r-request_config.
See my .sig for more.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
that people.apache.org is currently down. I would appreciate
if you could test the patches and report back here.
+1 to that. A report describing testcases and results in detail could
help with getting it backported.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http
proposition. mod_filter does that: you can conditionally
insert mod_deflate.
--
Nick Kew
so please report back, such that the patches can be
proposed
for backport to 2.0.x.
FWIW, I think mod_deflate 2.2 can be dropped in to 2.0 (source,
not binary, of course). But it does contain a very significant
change: the inflate output filter.
--
Nick Kew
Application Development with Apache
. If necessary, let it fork, demo your ideas on a
branch, then present that for discussion.
Isn't that approximately what Paul suggested some time back?
--
Nick Kew
On Mon, 30 Oct 2006 14:03:03 +0200 (SAST)
Graham Leggett [EMAIL PROTECTED] wrote:
On Mon, October 30, 2006 12:57 pm, Nick Kew wrote:
The current expectation that it be possible to separate completely
the storing of the cached response and the delivery of the content
is broken.
Why
that, at the expense once again of forcing morphing even when it
shouldn't be necessary.
4) change the interface: pass some abstract flush-me callback in,
Ugh. Complexity. Does it gain anything over, say, (1)?
--
Nick Kew
questionable gain (would you use mod_cache to
serve local, static contents?)
--
Nick Kew
the DEFS = -DWITH_LIBXML2 line in the Makefile.
Why is that? libxml2 works fine in Windows, and with apache in
many different modules. Do you know why it's incompatible with
mod_security, or is this just awaiting a round tuit?
--
Nick Kew
Application Development with Apache - the Apache Modules
) to test it first, if you really
can't get the source.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
unconfigured),
but I guess that can wait for 2.2.5 if necessary.
I'll try and find time to review other people's STATUS entries:-)
And my comment on the PCRE thing: since it's not a regression
from what we have already, you can take it as a -1 vote, not veto.
--
Nick Kew
Application
or mod_python?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
On Wed, 08 Nov 2006 22:19:28 +0100
Ruediger Pluem [EMAIL PROTECTED] wrote:
Could someone please add version 2.0.59 to bugzilla for the product
Apache httpd-2?
Good point. That keeps happening. 'Twould be a Good Thing if
updating bugzilla were integrated into the release process.
--
Nick
On Wed, 8 Nov 2006 10:31:42 -0800
Brian McCallister [EMAIL PROTECTED] wrote:
On Nov 8, 2006, at 10:27 AM, Nick Kew wrote:
Just to be clear about it: presumably you're proposing it have
a similar kind of status to mod_perl or mod_python?
Yes.
+1 to that.
-1 to anything that makes
your module is loaded. Your external application should
not use Apache logging, and if it needs SSL then it should
link (or load) the openssl lib itself.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
/Max
to more than 1.
P.S.: I tried to send this question to the users' mailing list a few
days ago but unfortunately I got no reply.
I don't recollect seeing it there.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
a server name. It is fixed in /trunk/, but not 2.2.3.
Thanks for the report!
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
on a subsequent call. Shouldn't the block around 1134 be
brought to the top of the function, so it catches the case
of a last brigade containing only an EOS?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
be notoriously hard to test. I wonder if there's
a compression/zlib test suite we could use?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
might need to check your command's context. A simple first
test for that would be to test whether there are some contexts
where it works and others where it crashes.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
by
FollowSymLinks and SymLinksIfOwnerMatch. [Nick Kew, Ruediger Pluem,
William Rowe]
But it doesn't appear to be backported, nor is there a proposal
in STATUS.
Does anyone recollect where we left this? Were there still
loose ends that would make a backport problematic?
--
Nick Kew
is a post_read_request hook.
It doesn't fit anywhere in the filter chain, because low-level decoding
of folded lines and converting them into a headers_in table happens
in a single step.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
On Sun, 26 Nov 2006 23:55:39 +0100
Mathieu CARBONNEAUX [EMAIL PROTECTED] wrote:
hi,
i'm developping a module and i need to modify ap_document_root
dynamicaly in my module
No you don't! Define another variable you can manipulate.
Don't mess with apache's standard vars!
--
Nick Kew
it in a Location tag does not throw any error.
The Directory context implies Location and Files.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
, et al. Apache, with three times IIS's
market share, didn't. Apache will let you shoot yourself in the
foot, but unlike IIS (or PHP) it won't hand a loaded gun with no
safety cache to an admin who has no clue about using it.
--
Nick Kew
Application Development with Apache - the Apache Modules
suspect you might be
seeing a problem where none exists.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
strongly
enough about it to cast another -1.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
this relates to
relevant updates leading to the CHANGES file entry:
core: Do not allow internal redirects like the DirectoryIndex of
mod_dir to circumvent the symbolic link checks imposed by
FollowSymLinks and SymLinksIfOwnerMatch. [Nick Kew, Ruediger Pluem,
William Rowe]
I'm
to circumvent the symbolic link checks imposed by
FollowSymLinks and SymLinksIfOwnerMatch. [Nick Kew,
Ruediger Pluem,
William Rowe]
I'm struggling to find the relevant changes in SVN, and there are
no pointers in the relevant bug report PR#14206.
I guess
r423886
I found that one
On Wed, 06 Dec 2006 09:42:04 +0100
Frank [EMAIL PROTECTED] wrote:
William A. Rowe, Jr. wrote:
Nick Kew wrote:
[...]
Is OpenSSL not thread-safe?
An SSL_CTX can't be cross-threaded. If the scope of use of that
CTX is restricted to one thread at a time, then yes, OpenSSL has
been
?
OpenSSL is just one of thousands of libraries a module developer might
want to use, and isn't one I've drawn on for examples (as you will
no doubt infer from my ignorance of it:-)
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
, and
What are the criteria for most? Rather nebulous, AFAIK.
2) Yes we might consider turning down those log messages a bit
Yes, those messages are a bug that should be fixed.
They are critical if DBD has been configured; the bug is that
they appear when it hasn't.
--
Nick Kew
Application
On Fri, 8 Dec 2006 16:25:01 -0500
Brian Rectanus [EMAIL PROTECTED] wrote:
Hello all,
I am currently looking into development for using httpd 2.2 as a
transparent reverse proxy.
How does a transparent reverse proxy differ from a reverse
proxy as we know and document it?
--
Nick Kew
time to deal with outstanding matters, great.
If not, go ahead and draw a line.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
acknowledged in /trunk/CHANGES
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
the tutorial. The recipes everyone seems to
copy were designed for Apache 2.0 and mod_proxy_html 1.x,
and while they work for later versions, they lead users
into some gotchas in spite of my warnings!
http://apache.webthing.com/mod_proxy_html/
--
Nick Kew
Application Development with Apache
a fix for that was responsible for the correct headers I saw.
--
Nick Kew
to MySQL in your apache?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
about anything else linking MySQL.
Culprit could be something like Perl, PHP, Python, Ruby, ...
This is a regular problem with linking libraries from modules.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
to tackle this recursion.
The simple solution is for the ErrorDocument to be kept outside the
scope of what's restricted by your module. That gives control to
system administrators.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
On Mon, 8 Jan 2007 16:08:51 +
Patrick Welche [EMAIL PROTECTED] wrote:
so what sort of password does apr_password_validate accept?
Those created with htpasswd is a simple answer.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
module if I require them to restart their webserver twice every time
they need to reload it.
Sysadmins aren't generally going to be working with a module that
changes on every restart.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
be documented. And it would be good if
mod_usertrack declined to build on darwin, so this doesn't hit
users who have no idea of tracking down a crash.
--
Nick Kew
an output filter. Input is a Pull API.
So you have to populate the brigade you were called with,
and add an EOS to that when finished.
Also don't forget the protocol. Your filter may invalidate
things like Content-Length headers, or any checksums.
--
Nick Kew
Application Development with Apache
(hdr-ta), s))) { return res;
}
}
It would then start to process the memory region starting with t with
parse_format_tag.
Heh!
I think the following should fix this:
Yep, looks right, thanks.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http
and server-generated reports.
Web applications and third-party modules and libraries used with
the web server must be investigated separately.
How about replacing must with may have to be? We're not
in the business of saying someone else is guilty, only that
we're innocent.
--
Nick Kew
be interested in working with me so I may
write such functionality, maybe for a future version of Apache?
Patches welcome.
Bear in mind that perchild was threaded, and therefore never
likely to be suitable for php.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http
in my article at
http://www.apachetutor.org/dev/request
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
functional API?
* Is it inherently thread-safe, or will you be needing a reslist
or similar solution?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
shut up:-)
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
on IRC.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
module in its own right.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
On Sun, 11 Feb 2007 15:23:52 +
Nick Kew [EMAIL PROTECTED] wrote:
On Sun, 11 Feb 2007 15:51:37 +0100
Michael Wallner [EMAIL PROTECTED] wrote:
Looking at apr/memory/unix/apr_pools.c, APRs allocator is anything
but a generic infrastructure for implementing my own allocator
to
look into it myself right now.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
On Mon, 12 Feb 2007 22:09:57 +0100
Henrik Nordstrom [EMAIL PROTECTED] wrote:
mån 2007-02-12 klockan 17:51 + skrev Nick Kew:
2. Where there's chunked encoding, the check would best be
implemented in the chunking filter.
3. A simple count/abort filter is then a last resort
On Mon, 12 Feb 2007 23:35:24 +0100
Henrik Nordstrom [EMAIL PROTECTED] wrote:
mån 2007-02-12 klockan 21:55 + skrev Nick Kew:
Because the chunking filter is equipped to discard the chunk that
takes it over the limit, and substitute end-of-chunking.
If we do that in a new filter, we
performance. I would consider
it unacceptable to buffer entire requests or responses at a proxy.
At best it's a big performance hit; at worst it's a DoS-magnet.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
, it might be time to
bring in some kind of if-then-else logic (the road LimitExcept
started down):
Location /limited/ method=GET POST HEAD
Else Location /limited/ method!=GET POST HEAD
/Location
That's far too ugly as stated, but you get the idea.
--
Nick Kew
Application Development with Apache
for modules to add their own arguments
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
. In particular, the .h files, which
give you detailed API documentation.
For higher-level documentation of Apache 2.2, follow my .sig.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
WITHOUT THESE APPROVED:
That's +1 on this list from me. And yesterday from wrowe, minfrin.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
, but it works.
(Agreed, filters are by far the single most important advance
in Apache 2).
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
to a compatibility layer - provided that's
going to be maintainable.
The breakage between 1.x and 2.0 was far too much. If we
do it again, the world will rightly conclude that Apache
is not a solution fit for the long term.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
an API for such things.
3. And if it doesn't, you can still cheat by manipulating its
internals directly. That of course is at your own risk:
you'll need to declare your module as tied to an exact version.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http
..why they are not good or not suitable in
Apache, why?
Apache gives you the choice. Write a new MPM to drive it as you want.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
it could also give a bogus 409,
for example in the case of a newly-installed and misconfigured
server.
Does the DAV RFC explicitly tell us to use 409 in this instance?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
of all module_config
structs in use? Or do I have to create one in my
create_{dir,srv}_config functions?
Yes there is, but you shouldn't use it directly. The API provides
accessors for own- and public module data.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http
functionality with HTTP/1.0
-1 otherwise.
To the OP: why not apply the fix suggested in the bug comments?
Define the size you want to use.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
, we might check the logic in mod_deflate.
It looks as if it'll remove itself if an identity token is
found, which raises the question: are you running anything else
that might compress responses - for example, within your
login script?
--
Nick Kew
Application Development with Apache - the Apache
On Tue, 13 Mar 2007 09:24:25 -0400
Jim Jagielski [EMAIL PROTECTED] wrote:
http://people.apache.org/~jim/code/mod_sed_filter.c
At a glance, it looks like mod_line_edit.
Are you doing anything different?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http
used by
clients of Covalent. Please tell me what I'm missing?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
string as well as regex matching!
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
explicitly invoked.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
On Wed, 14 Mar 2007 13:45:47 +
Nick Kew [EMAIL PROTECTED] wrote:
As for the particular case Frank asked for, that works by
expanding the union to include a function pointer alongside
the strmatch and regexp cases. So it's also a per-rule
configuration flag, and never touches the code
in to trunk, a roadmap would probably be in order.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
On Wed, 14 Mar 2007 15:27:44 +
Joe Orton [EMAIL PROTECTED] wrote:
On Wed, Mar 14, 2007 at 03:01:53PM +, Nick Kew wrote:
On Wed, 14 Mar 2007 14:32:13 +
Joe Orton [EMAIL PROTECTED] wrote:
1) the filtering logic is broken and will consume RAM
proportional to response size
On Wed, 14 Mar 2007 11:15:00 -0400
Jim Jagielski [EMAIL PROTECTED] wrote:
On Mar 14, 2007, at 11:01 AM, Nick Kew wrote:
Oh, I guess you mean the copying to get a null-terminated string
when applying a regexp? And I see it's repeated for every regexp
(ouch)! mod_line_edit uses a local
On Wed, 14 Mar 2007 16:56:41 +
Joe Orton [EMAIL PROTECTED] wrote:
On Wed, Mar 14, 2007 at 03:45:05PM +, Nick Kew wrote:
Nope. Just one brigades worth at a time. And the most likely case
for that to be an entire document is when it's a static file, and
document == brigade
(filters/*, http/* etc) or too awful
(experimental/*). Any objections?
I think I have a better idea. But I think I'd rather hack it up
(round tuits permitting) than discuss it here in the abstract.
Actually if I'm right, your proposed example will still help,
as it'll be a useful contrast.
--
Nick
a chance they'd all be applied.
If I need to alter the patch for this to happen, let me know.
(ie did I use the correct variable naming, are the declarations in the
right header files etc.?)
Looks fine to me.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http
101 - 200 of 1431 matches
Mail list logo