Recommendation for adding APLOGNO() before string format which is passed to ap_log_cerror()

2018-10-16 Thread
Our team works on enhance logging practices by learning from historical log revisions in evolution. By mining historical patches, we find two patches that both add APLOGNO(*) before the format string which is then passed to ap_log_cerror(). However, when apply this rule to httpd-2.4.27, we

several recommendations for log enhancement

2018-01-28 Thread
Our team studies the consistent edits of Httpd during evolution. We find that there may be several missed edits in the latest release of httpd. For example, we find that two consistent edits in historical commits. They are respectively: 1) Version: httpd 2.2.34 – httpd-2.3.6 File:

Re: Re: Consistent update of invoking ap_map_http_request_error()

2018-01-06 Thread
> -Original Messages- > From: "Yann Ylavic" <ylavic@gmail.com> > Sent Time: 2018-01-05 18:41:15 (Friday) > To: httpd-dev <dev@httpd.apache.org> > Cc: > Subject: Re: Consistent update of invoking ap_map_http_request_error() > > Hi,

Consistent update of invoking ap_map_http_request_error()

2018-01-04 Thread
Our team researches on the consistent edits of Httpd during evolution. And we have figured out several spots that may be missed for consistent update. They are both about invoking of function, ap_map_http_request_error().  We suggest to escape call of function and return the corresponding error