Re: ping for http in mod_proxy

2008-02-14 Thread Filip Hanik - Dev Lists
Graham Leggett wrote: Jim Jagielski wrote: Ideally, it would be nice if we had better insight on the actual health of the backends than a simple do they respond to OPTIONS * and how long does it take, but that's pretty much all we can do unless go full-on multicasting of info ala

Re: Small patch to ab apr_socket_recv error handling

2007-03-08 Thread Filip Hanik - Dev Lists
if you want, you can commit this, the error counters are all over the place and not really correct. So I'm gonna keep improving ab to return the correct error stats. Filip Filip Hanik - Dev Lists wrote: ok, Jeff's feedback has been incorporated into this patch. Filip Jeff Trawick wrote

Re: Small patch to ab apr_socket_recv error handling

2007-03-08 Thread Filip Hanik - Dev Lists
it is an attachment, chances are your mail reader is expanding it into your viewing window but you can also get it here http://www.hanik.com/fix-ab-recv-error.patch Filip Jeff Trawick wrote: On 3/7/07, Filip Hanik - Dev Lists [EMAIL PROTECTED] wrote: ok, Jeff's feedback has been

Re: Small patch to ab apr_socket_recv error handling

2007-03-07 Thread Filip Hanik - Dev Lists
ok, Jeff's feedback has been incorporated into this patch. Filip Jeff Trawick wrote: On 3/2/07, Filip Hanik - Dev Lists [EMAIL PROTECTED] wrote: is the patch below looking good? does it need adjustments? do I need to follow a different process? Filip Filip Hanik - Dev Lists wrote: ok

Re: Small patch to ab apr_socket_recv error handling

2007-03-02 Thread Filip Hanik - Dev Lists
is the patch below looking good? does it need adjustments? do I need to follow a different process? Filip Filip Hanik - Dev Lists wrote: ok, final patch, this one also adds in Content-Length: 0 when keep alive is used. somehow, most containers will not do keep alive unless there is a content

Re: Small patch to ab apr_socket_recv error handling

2007-02-28 Thread Filip Hanik - Dev Lists
ok, final patch, this one also adds in Content-Length: 0 when keep alive is used. somehow, most containers will not do keep alive unless there is a content length header. Filip Filip Hanik - Dev Lists wrote: hi Aaron, I added in the -r command line options, to not exit out

Re: Small patch to ab apr_socket_recv error handling

2007-02-27 Thread Filip Hanik - Dev Lists
hi Aaron, I added in the -r command line options, to not exit out on apr_socket_recv errors. Patch attached Filip Aaron Bannert wrote: Apache shouldn't be prematurely disconnecting sockets in the middle of a response unless there is a serious problem (Eg. the Apache child process is

Small patch to ab apr_socket_recv error handling

2007-02-26 Thread Filip Hanik - Dev Lists
I've created a small patch that lets ab continue even if it encounters an error on apr_socket_recv quite commonly, when servers are overloaded they disconnect the socket, ab receives a 104 (connection reset by peer) and the ab test exits. This patch logs the error, both counters correctly,