Re: mod_tls as experimental module?

2021-11-24 Thread Joe Orton
Possibly no strong opinions? +1 from me anyway. How hard is it going to be to test in Travis? On Wed, Nov 24, 2021 at 10:46:03AM +0100, ste...@eissing.org wrote: > Coming back to this. Since there was no feedback on my post: are people > just too occupied/opposed/not interested? > > Curious, >

Re: openssl 3.0 when

2021-11-02 Thread Joe Orton
On Tue, Nov 02, 2021 at 09:23:32AM +0100, ste...@eissing.org wrote: > > > Am 01.11.2021 um 15:24 schrieb Joe Orton : > > > > On Sun, Oct 31, 2021 at 01:35:09PM +0100, ste...@eissing.org wrote: > >> I would like us to come to an understanding what our roadmap

Re: openssl 3.0 when

2021-11-01 Thread Joe Orton
On Sun, Oct 31, 2021 at 01:35:09PM +0100, ste...@eissing.org wrote: > I would like us to come to an understanding what our roadmap in > regard to OpenSSL 3.0 is. People keep on asking about it. > > Yesterday, I spent some hours hacking at mod_ssl and mod_md to > get it running. I managed to

Re: svn commit: r1894220 - in /httpd/httpd/trunk: modules/http2/h2_bucket_beam.c test/modules/http2/test_004_post.py test/modules/http2/test_400_push.py test/modules/http2/test_401_early_hints.py

2021-10-14 Thread Joe Orton
On Thu, Oct 14, 2021 at 11:17:11AM +0200, Ruediger Pluem wrote: > On 10/14/21 10:59 AM, ic...@apache.org wrote: > > - > > + > > +b = APR_BRIGADE_FIRST(bb); > > if (APR_BUCKET_IS_METADATA(b)) { > > APR_BUCKET_REMOVE(b); > > apr_bucket_setaside(b, beam->pool); > >

Re: Ineract with travis? (was: Errored: apache/httpd#1888 (trunk - 47e6ece))

2021-10-12 Thread Joe Orton
On Tue, Oct 12, 2021 at 11:31:51AM +0200, Yann Ylavic wrote: > Gavin (infra) gave all the httpd-committers team the "triage" access > right on github, which follows on travis. > This also includes managing PRs on github, great! Ah, brilliant. Thank you Yann and Gavin. Regards, Joe

Re: Broken: apache/httpd#2037 (trunk - fa7f375)

2021-10-11 Thread Joe Orton
On Mon, Oct 11, 2021 at 11:03:47AM +0100, Joe Orton wrote: > On Sat, Oct 09, 2021 at 06:06:32PM +0200, Yann Ylavic wrote: > > On Sat, Oct 9, 2021 at 5:47 PM Travis CI wrote: > > > > > > Build #2037 was broken > > > > Somehow Travis picked up the wrong Ub

Re: Broken: apache/httpd#2037 (trunk - fa7f375)

2021-10-11 Thread Joe Orton
On Sat, Oct 09, 2021 at 06:06:32PM +0200, Yann Ylavic wrote: > On Sat, Oct 9, 2021 at 5:47 PM Travis CI wrote: > > > > Build #2037 was broken > > Somehow Travis picked up the wrong Ubuntu version?? > All the Ubuntu Focal builds with system's APR failed with: Odd one, I haven't seen this before.

Re: Ineract with travis? (was: Errored: apache/httpd#1888 (trunk - 47e6ece))

2021-10-08 Thread Joe Orton
On Fri, Sep 24, 2021 at 02:28:15PM +0200, Yann Ylavic wrote: > On Fri, Sep 24, 2021 at 2:06 PM Yann Ylavic wrote: > > > > On Mon, Sep 6, 2021 at 5:30 PM Joe Orton wrote: > > > > > > If you're logged into Github you can restart > > > individual jobs w

Re: [VOTE] Release httpd-2.4.51-rc1 as httpd-2.4.51

2021-10-07 Thread Joe Orton
ASF release policy [1] suggests that we have a >=72 hour voting period for releases, but this is a "SHOULD" not a hard rule. Due to: a) the severity of the issue being fixed, and b) the extensive review and testing which the patch has received both here and off-list, and c) the fact we

Re: [VOTE] Release httpd-2.4.51-rc1 as httpd-2.4.51

2021-10-07 Thread Joe Orton
On Thu, Oct 07, 2021 at 03:17:36PM +0200, ste...@eissing.org wrote: > Hi all, > > due to found security weaknesses in our 2.4.50 release, the security team > feels it is necessary to do a new release on very short notice. We will skip > the usual 3 day voting period and close the vote once we

Re: svn commit: r1893876 - /httpd/httpd/trunk/modules/ssl/ssl_engine_init.c

2021-10-07 Thread Joe Orton
On Thu, Oct 07, 2021 at 09:09:32AM +0200, Ruediger Pluem wrote: > On 10/4/21 12:26 PM, jor...@apache.org wrote: > > Author: jorton > > Date: Mon Oct 4 10:26:18 2021 > > New Revision: 1893876 > > > > URL: http://svn.apache.org/viewvc?rev=1893876=rev ... > > +++

Re: [VOTE] Release httpd-2.4.50-rc1 as httpd-2.4.50

2021-10-01 Thread Joe Orton
On Fri, Oct 01, 2021 at 04:40:44PM +0200, ste...@eissing.org wrote: > Hi, all; >Please find below the proposed release tarball and signatures: > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball

Re: trunk/rc usable with OpenSSL 3.0.0 ?

2021-09-13 Thread Joe Orton
On Mon, Sep 13, 2021 at 11:16:15AM +0200, Rainer Jung wrote: > Hi Dennis, > Am 13.09.2021 um 11:05 schrieb Dennis Clarke: > > That Apache httpd, the biggest web server on planet Earth ( let me check > > mars ) has never looked at OpenSSL 3.0.0 as an event in the mail? It has > > been shipped.

Re: trunk/rc usable with OpenSSL 3.0.0 ?

2021-09-13 Thread Joe Orton
On Mon, Sep 13, 2021 at 01:23:37AM -0400, Dennis Clarke wrote: > > ALL : > > > I may receive no reply to this but in general I have been able to build > Apache httpd from any release tarball as well as from trunk. When httpd > needed to get TLS 1.3 working it was a slam dunk to get that working

Re: [VOTE] Release httpd-2.4.49-rc1 as httpd-2.4.49

2021-09-13 Thread Joe Orton
On Fri, Sep 10, 2021 at 05:23:53PM +0200, ste...@eissing.org wrote: > Hi, all; >Please find below the proposed release tarball and signatures: > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball

Re: release roll soon?

2021-09-10 Thread Joe Orton
On Fri, Sep 10, 2021 at 09:42:10AM +0200, ste...@eissing.org wrote: > > > > Am 10.09.2021 um 09:02 schrieb Joe Orton : > > > > On Thu, Sep 09, 2021 at 03:23:13PM -0700, Gregg Smith wrote: > >> Since OpenSSL 3.0.0 GA came out yesterday (Californuts time) I th

Re: release roll soon?

2021-09-10 Thread Joe Orton
On Thu, Sep 09, 2021 at 03:23:13PM -0700, Gregg Smith wrote: > Since OpenSSL 3.0.0 GA came out yesterday (Californuts time) I think it > would be nice to have r1891138 backported for those wishing to try it out. > What you say? I'd say it's better to try to get a successful release out, then try

Re: Errored: apache/httpd#1888 (trunk - 47e6ece)

2021-09-06 Thread Joe Orton
On Mon, Sep 06, 2021 at 04:01:40PM +0200, ste...@eissing.org wrote: > > > > Am 06.09.2021 um 15:45 schrieb Yann Ylavic : > > > > On Mon, Sep 6, 2021 at 3:08 PM Travis CI wrote: > >> > >> apache / httpd > >> > >> trunk > >> > >> Build #1888 has errored > >> 25 mins and 54 secs > > > > Hmm,

Re: Failed: apache/httpd#1856 (candidate-2.4.49 - cd5b61d)

2021-09-03 Thread Joe Orton
I think this is fixed with both r1892841, r1892845 merged but I am still slightly unsure about when things appear as "tags" in Travis and when as "branches", so it might need further tweaks. Regards, Joe

Re: Failed: apache/httpd#1856 (candidate-2.4.49 - cd5b61d)

2021-09-03 Thread Joe Orton
On Thu, Sep 02, 2021 at 01:38:55PM -0400, Eric Covener wrote: > I think there are some jobs that are excluded if not "2.4.x", so it's > doing some trunk-only stuff. Yup, we need to adjust the conditions. I did r1892841 but this is wrong, it needs to catch branches, gimme a minute while a burn a

[VOTE] Re: http2 test suite

2021-09-01 Thread Joe Orton
On Mon, Aug 30, 2021 at 08:39:17AM +0200, Ruediger Pluem wrote: > On 8/28/21 4:00 PM, Yann Ylavic wrote: > > On Fri, Aug 27, 2021 at 10:07 AM ste...@eissing.org > > wrote: > >> Related to that, do we exempt "./test" from RTC in 2.4.x/STATUS? > > > > +1 for CTR, that's how the tests framework

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-26 Thread Joe Orton
On Thu, Aug 26, 2021 at 01:11:16PM +0200, ste...@eissing.org wrote: > Joe: with r1892615 I fixed a bug in waiting for the server to become > unresponsive after a stop. This *should* make timed waits unnecessary > in the http2 test suite. Great stuff, thanks for all your work Stefan. It worked

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-26 Thread Joe Orton
On Thu, Aug 26, 2021 at 09:51:07AM +0200, ste...@eissing.org wrote: > https://app.travis-ci.com/github/apache/httpd > > > assert env.apache_restart() == 0 > 3026E assert 1 == 0 > 3027E+ where 1 = >() > 3028E+where > = 0x7ffb03366a60>.apache_restart > 3029 >

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread Joe Orton
On Wed, Aug 25, 2021 at 05:08:06PM +0200, ste...@eissing.org wrote: > > > > Am 25.08.2021 um 17:06 schrieb Yann Ylavic : > > > > Thanks, looks good, it probably needs a backport to 2.4.x since the > > first travis failure was there (Build #1819). > > Let's see how it works after several runs

Re: http2 test suite

2021-08-25 Thread Joe Orton
On Mon, Aug 23, 2021 at 03:03:34PM +0200, ste...@eissing.org wrote: > > > > Am 23.08.2021 um 14:40 schrieb Joe Orton : > > > > On Mon, Aug 23, 2021 at 12:59:19PM +0200, ste...@eissing.org wrote: > >> The http2 test suites in https://github.com/icing/mod_h2 a

Re: http2 test suite

2021-08-23 Thread Joe Orton
hrieb ste...@eissing.org: > >> > >> > >> > >>> Am 20.08.2021 um 13:46 schrieb Joe Orton : > >>> > >>> On Fri, Aug 20, 2021 at 11:35:45AM +0200, Stefan Eissing wrote: > >>>> https://github.com/apache/httpd/pull/260 >

Re: http2 test suite

2021-08-20 Thread Joe Orton
On Fri, Aug 20, 2021 at 11:35:45AM +0200, Stefan Eissing wrote: > https://github.com/apache/httpd/pull/260 > a PR with the http2 test suite in trunk/test/modules/http2 > > How to use: > > • run configure again after you checked this out > • the following components need to be installed on

Re: svn commit: r1891148 - in /httpd/httpd/trunk: include/ap_mmn.h include/util_filter.h modules/proxy/proxy_util.c server/util_filter.c

2021-08-20 Thread Joe Orton
On Thu, Aug 19, 2021 at 03:28:44PM +0200, Yann Ylavic wrote: > The only filters that care about write completion for now are > ap_core_output_filter() and ssl_io_filter_output(), which try to fill > in the pipe as much as possible, using > ap_filter_reinstate_brigade(_upto) to determine whether

Re: Extra bucket brigade with just an EOS on an input filter at the end.

2021-08-09 Thread Joe Orton
On Sat, Aug 07, 2021 at 06:33:49PM +0200, Dirk-Willem van Gulik wrote: ... > What I am seeing is a first brigade with the POST content; with a > terminating EOF. The bbout data makes it to the CGI script or > (reverse) proxy. > > But I am then getting a second _input_filter call with a second

Re: disallow HTTP 0.9 by default?

2021-07-22 Thread Joe Orton
On Wed, Jul 21, 2021 at 04:04:13PM -0400, Eric Covener wrote: > I was chasing an unrelated thread about close_notify alerts and > reminded me -- is it time to change the default for > HttpProtocolOptions from Allow0.9 to Require1.0? > > As the manual says, the requirement was dropped in RFC 7230.

ap_proxy_acquire_connection crash? (was Re: Broken: apache/httpd#1739 (trunk - f087735))

2021-07-12 Thread Joe Orton
On Fri, Jul 09, 2021 at 06:00:26PM +, Travis CI wrote: > Build Update for apache/httpd > - > > Build: #1739 > Status: Broken > > Duration: 21 mins and 57 secs > Commit: f087735 (trunk) > Author: Rich Bowen > Message: s/freenode/libera/ > > git-svn-id:

Re: svn commit: r1891148 - in /httpd/httpd/trunk: include/ap_mmn.h include/util_filter.h modules/proxy/proxy_util.c server/util_filter.c

2021-06-30 Thread Joe Orton
On Tue, Jun 29, 2021 at 09:16:21PM -, yla...@apache.org wrote: > Author: ylavic > Date: Tue Jun 29 21:16:21 2021 > New Revision: 1891148 > > URL: http://svn.apache.org/viewvc?rev=1891148=rev > Log: > core: Write Completion (WC) bucket type. > > A WC bucket is meant to prevent

Re: where do we want to send website bot notices?

2021-06-28 Thread Joe Orton
On Fri, Jun 25, 2021 at 03:50:33PM -0700, Roy T. Fielding wrote: > I was about to update the site config so that it wouldn't send notices > to dev, but I don't know whether they should instead go to cvs, docs, or > a new list (like notices at httpd). Any opinions? We already have notifications@

Re: SSLFIPS on/off

2021-05-21 Thread Joe Orton
On Wed, May 12, 2021 at 02:25:42PM +0200, pgajdos wrote: > Hello, > > I have a question regarding the logic around SSLFIPS on/off. After > https://svn.apache.org/viewvc?view=revision=1853197 > I think SSLFIPS off will not work as expected. ... > In case sc->fips is FALSE (SSLFIPS off or not

Re: Replace SIGWINCH by SIGUSR2 in trunk?

2021-05-21 Thread Joe Orton
On Mon, May 17, 2021 at 04:35:28PM +0200, Yann Ylavic wrote: > Since APR-1.7 (r1854995), SIGUSR2 is removed from the list of > uncatchable synchronous signals so it could be used instead of > SIGWINCH for graceful stop in httpd. > > The problem with SIGWINCH is when httpd is run from a

Re: [VOTE] Release httpd-2.4.48

2021-05-18 Thread Joe Orton
On Tue, May 18, 2021 at 01:30:25PM +0200, Ruediger Pluem wrote: > > > On 5/18/21 11:52 AM, Giovanni Bechis wrote: > > On 5/17/21 11:36 PM, Christophe JAILLET wrote: > >> Hi, all; > >>    Please find below the proposed release tarball and signatures: > >>

Re: [VOTE] Release httpd-2.4.48

2021-05-18 Thread Joe Orton
On Mon, May 17, 2021 at 11:36:29PM +0200, Christophe JAILLET wrote: > Hi, all; >Please find below the proposed release tarball and signatures: > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release this candidate > tarball as 2.4.48:

Re: htcacheclean.c error when compiling with apr-1.6.x and apr-1.7.x

2021-05-07 Thread Joe Orton
On Fri, May 07, 2021 at 10:12:44AM +0100, Joe Orton wrote: > It seems to be new with GCC 11, these are warnings which become errors > you since are using --enable-maintainer-mode. > > The extensive use of APR_RING* is warning-free in all the APR bucket > brigade code e

Re: htcacheclean.c error when compiling with apr-1.6.x and apr-1.7.x

2021-05-07 Thread Joe Orton
On Tue, May 04, 2021 at 09:12:04AM +0200, jean-frederic clere wrote: > On 04/05/2021 08:59, jean-frederic clere wrote: ... > > In file included from htcacheclean.c:36: > > htcacheclean.c: In function ‘process_dir’: > > /home/jfclere/APR-1.7.x/include/apr-1/apr_ring.h:183:37: error: array > >

Re: [VOTE] Release httpd-2.4.47

2021-04-23 Thread Joe Orton
On Thu, Apr 22, 2021 at 11:25:01AM +0200, Christophe JAILLET wrote: > Hi, all; >Please find below the proposed release tarball and signatures: > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release this candidate > tarball as 2.4.47:

Re: recent watchdog pool changes

2021-04-20 Thread Joe Orton
On Tue, Apr 20, 2021 at 03:58:17PM +0200, Stefan Eissing wrote: > Yann, can you have a look if this fix of mine does do the right thing? For > me, mod_md works better when it does not use destroyed pools. 浪 > > If this is ok, we might want to backport this really fast. This is failing for you

Re: [RESULT: PASS] Re: [VOTE] Release libapreq2-2.16

2021-03-23 Thread Joe Orton
On Mon, Mar 22, 2021 at 06:14:35PM +, Steve Hay wrote: > Success! We now have libapreq2-2.16 correctly indexed on (Meta)CPAN: > > https://metacpan.org/release/SHAY/libapreq2-2.16 > > Thanks to Joe and all the testers/voters for getting this update done. Nice, thanks Steve! Regards, Joe

[RESULT: PASS] Re: [VOTE] Release libapreq2-2.16

2021-03-19 Thread Joe Orton
Thanks for testing again, the vote has passed: PMC votes: +1 from rpluem, ylavic, jorton Community: +1 stevehay I'll promote the release & send the announcement mail. Regards, Joe

Re: [VOTE] Release libapreq2-2.16

2021-03-17 Thread Joe Orton
On Wed, Mar 10, 2021 at 04:05:14PM +, Joe Orton wrote: > I would like to call a VOTE over the next week to release this candidate > tarball as v2.16: > > [X] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. H

Re: "ssl" variables and "SSLRequireSSL"

2021-03-12 Thread Joe Orton
On Fri, Mar 12, 2021 at 12:22:38PM +0100, Stefan Eissing wrote: > Things for consideration: > 1. "SSLOptions StdEnvVars" sets a range of variables unrelated to SSL. > I think these should be provided by the server. Which ones are unrelated to SSL? > 2. "SSLRequireSSL" is internally implemented

Re: [VOTE] Release libapreq2-2.16

2021-03-10 Thread Joe Orton
On Wed, Mar 10, 2021 at 04:05:16PM +, Joe Orton wrote: > Hi, I've prepared a candidate release tarball for libapreq2 v2.15 here: You can see I'm still an amateur at this - should read ^^ v2.16

[VOTE] Release libapreq2-2.16

2021-03-10 Thread Joe Orton
Hi, I've prepared a candidate release tarball for libapreq2 v2.15 here: https://dist.apache.org/repos/dist/dev/httpd/libapreq/ This release is to address an issue blocking the upload to CPAN. I would like to call a VOTE over the next week to release this candidate tarball as v2.16: [ ] +1:

Re: svn commit: r1887342 - /httpd/httpd/trunk/modules/md/md_crypt.c

2021-03-09 Thread Joe Orton
On Tue, Mar 09, 2021 at 10:21:18AM +0100, Stefan Eissing wrote: > > Am 08.03.2021 um 21:50 schrieb Yann Ylavic : > > > > On Mon, Mar 8, 2021 at 9:15 PM wrote: > >> > >> +#if OPENSSL_VERSION_NUMBER < 0x1010L > >> +ip = ASN1_STRING_get_data(cval->d.iPAddress); > > > >

Re: apache subversion and github

2021-03-03 Thread Joe Orton
On Wed, Mar 03, 2021 at 11:06:20AM +0100, Stefan Eissing wrote: > Hi, > > could someone from infra shed some light on what the current status of > the subversion/github integration is? Is there some documentation > about the state of things? > > I am asking because some devs seem to use it,

Re: Errored: apache/httpd#1461 (trunk - cd1fa48)

2021-03-02 Thread Joe Orton
On Tue, Mar 02, 2021 at 03:17:36PM +, Travis CI wrote: > Build Update for apache/httpd > - > > Build: #1461 > Status: Errored > > Duration: 21 mins and 38 secs > Commit: cd1fa48 (trunk) > Author: Stefan Eissing > Message: Adding log tags where log tags are

Re: [RESULT: PASS] Re: [VOTE] Release libapreq2-2.15

2021-02-23 Thread Joe Orton
On Mon, Feb 22, 2021 at 03:57:25PM +, Steve Hay wrote: > On Fri, 13 Nov 2020 at 16:43, Joe Orton wrote: > > > > Thanks all for testing, the vote has passed: > > > > PMC votes +1: ylavic, rpluem, covener > > Community +1: stevehay > > > > (Steve, l

Re: a patch for a ap_ssl_is_https()

2021-02-23 Thread Joe Orton
On Mon, Feb 22, 2021 at 05:28:03PM +0100, Stefan Eissing wrote: > Regarding my proposal to add SSL related inquiry functions to our core > server, here > is a patch for the "ssl_is_https()" function. This allows: > > a) anyone to inquire about a connections SSLiness without the optional >

Re: svn commit: r1782958 - in /httpd/httpd/trunk: docs/log-message-tags/ modules/http2/

2021-01-19 Thread Joe Orton
On Tue, Jan 19, 2021 at 02:39:50PM +0100, Yann Ylavic wrote: > On Tue, Jan 19, 2021 at 2:31 PM Eric Covener wrote: > > > > On Tue, Feb 14, 2017 at 7:54 AM wrote: > > > > > > Author: icing > > > Date: Tue Feb 14 12:54:22 2017 > > > New Revision: 1782958 > > > > > > URL:

Re: docker rate limits (was Re: Errored: apache/httpd#1362 (trunk - 5c3a2e5))

2021-01-11 Thread Joe Orton
On Fri, Jan 08, 2021 at 02:04:10PM +, Joe Orton wrote: > On Fri, Jan 08, 2021 at 01:45:37PM +0100, Yann Ylavic wrote: > > On Fri, Jan 8, 2021 at 12:17 PM Joe Orton wrote: > > > (Plan b is to move to quay.io and non-ubuntu images I guess.) > > > > I'm fine wit

Re: docker rate limits (was Re: Errored: apache/httpd#1362 (trunk - 5c3a2e5))

2021-01-08 Thread Joe Orton
On Fri, Jan 08, 2021 at 01:45:37PM +0100, Yann Ylavic wrote: > On Fri, Jan 8, 2021 at 12:17 PM Joe Orton wrote: > > Is anybody aware, is there an ASF/docker deal to work around this? I > > heard the Docker's OSS program had some quite unpleasant marketing > > buy-in for p

Re: r1884753 httpd trunk throws configure.in:93: error: possibly undefined macro: AC_MSG_ERROR from autoconf

2021-01-08 Thread Joe Orton
On Wed, Dec 23, 2020 at 03:58:12PM -0500, Dennis Clarke wrote: > > > Not too sure what to do with this. Using autoconf 2.69 on a Solaris 10 > server I see : > > /opt/bw/bin/autoconf --verbose --force --include=/opt/bw/include > --warnings=all ... > configure.in:241: error: possibly undefined

docker rate limits (was Re: Errored: apache/httpd#1362 (trunk - 5c3a2e5))

2021-01-08 Thread Joe Orton
Now being hit by the docker hub rate limiting. :( latest: Pulling from library/memcached library/memcached toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit Is anybody aware, is there

Re: svn commit: r1884505 - in /httpd/httpd/trunk: changes-entries/pr64339.txt modules/filters/mod_xml2enc.c

2020-12-17 Thread Joe Orton
On Wed, Dec 16, 2020 at 07:41:59PM +, Nick Kew wrote: > > On 16 Dec 2020, at 17:47, Yann Ylavic wrote: > >> Wouldn't this stop matching "application/xml" for instance? > >> > >> Possibly this test instead: > >>if (strncmp(ctype, "text/", 5) > >>&& (!(x = strstr(ctype, "xml")) >

Re: Still Failing: apache/httpd#1288 (2.4.x - 788be62)

2020-12-11 Thread Joe Orton
On Fri, Dec 11, 2020 at 01:48:39PM +0100, Yann Ylavic wrote: > On Fri, Dec 11, 2020 at 12:59 PM Ruediger Pluem wrote: > > > > On 12/11/20 12:30 PM, Travis CI wrote: > > > > > > branch icon2.4.x > > > > > > build has failed > > > > I think this is

Re: svn commit: r1883708 - /httpd/httpd/trunk/server/core.c

2020-12-04 Thread Joe Orton
On Sun, Nov 22, 2020 at 01:06:11AM -, yla...@apache.org wrote: > Author: ylavic > Date: Sun Nov 22 01:06:11 2020 > New Revision: 1883708 > > URL: http://svn.apache.org/viewvc?rev=1883708=rev > Log: > core: reset ap_runtime_dir to NULL after AP_SQ_MS_DESTROY_CONFIG. > >

Re: APLOGNO number range for vendors?

2020-12-04 Thread Joe Orton
On Tue, Dec 01, 2020 at 08:44:46PM +0100, Rüdiger Plüm wrote: > On 12/1/20 4:02 PM, Yehuda Katz wrote: > > Would a crazy option 4 be to add VENDOR_APLOGNO() which could add a prefix > > to the log number to be used in any patches? > > > > For example, V_APLOGNO('R', 123) could produce AHR123 > >

APLOGNO number range for vendors?

2020-12-01 Thread Joe Orton
Very occasionally we backport patches to RHEL's httpd package in a way that introduces new or different logging output from 2.4/trunk. I'm wondering if there is any opinion about vendors asking for for a small (say, 100?) reserved range of APLOGNO() space to use for such cases? Basically I'd

Re: Broken: apache/httpd#1216 (trunk - 2865f25)

2020-11-24 Thread Joe Orton
On Mon, Nov 23, 2020 at 05:16:42PM +0100, Yann Ylavic wrote: > On Mon, Nov 23, 2020 at 5:06 PM Yann Ylavic wrote: > > > > Yes apr-1.7.x and apr-util-1.7.x would be nice since we can CTR there > > quite easily and verify our fixes. > > Btw, I merged my APR changes (from today) to 1.7.x already :)

Re: Broken: apache/httpd#1216 (trunk - 2865f25)

2020-11-23 Thread Joe Orton
On Mon, Nov 23, 2020 at 01:24:39PM +0100, Yann Ylavic wrote: > --- srclib/apr-trunk/memory/unix/apr_pools.c(revision 1883742) > +++ srclib/apr-trunk/memory/unix/apr_pools.c(working copy) > @@ -1951,10 +1951,8 @@ APR_DECLARE(void) apr_pool_clear_debug(apr_pool_t > > static void

Re: Broken: apache/httpd#1216 (trunk - 2865f25)

2020-11-23 Thread Joe Orton
On Fri, Nov 20, 2020 at 06:08:18PM +0100, Yann Ylavic wrote: > I tried to reproduce this failure locally (debian buster) with multiple > tries but couldn't. > I think I'm using the same environment (apr-1.7.0, apr-util-1.6.1, > APR_POOL_DEBUG, docker.io/redis:latest), and in the same way running:

Re: Travis builds stuck?

2020-11-16 Thread Joe Orton
On Mon, Nov 16, 2020 at 01:36:43PM +0100, Ruediger Pluem wrote: > Does someone has an idea why our Travis builds are staying in received state? > If I go to https://travis-ci.org/github/apache/httpd it tells me me that we > have been migrated to travis-ci.com, but it looks like > that none of the

[RESULT: PASS] Re: [VOTE] Release libapreq2-2.15

2020-11-13 Thread Joe Orton
Thanks all for testing, the vote has passed: PMC votes +1: ylavic, rpluem, covener Community +1: stevehay (Steve, looks like we need to get you on the httpd PMC!) and no -1 votes. I'll promote the release & prep the announcement mail. Regards, Joe

[VOTE] Release libapreq2-2.15

2020-11-05 Thread Joe Orton
Hi, I've prepared a candidate release tarball for libapreq2 v2.15 here: https://dist.apache.org/repos/dist/dev/httpd/libapreq/ This release is mainly to address a security issue in libapreq2 which has been outstanding for over a year, CVE-2019-12412. I would like to call a VOTE over the next

Re: svn commit: r1882776 - /httpd/httpd/trunk/.travis.yml

2020-11-02 Thread Joe Orton
On Fri, Oct 30, 2020 at 09:25:05PM +0100, Ruediger Pluem wrote: > Are the following ones good candidates? They also do LDAP and SSL tests which > could be interesting as I guess that Focal has newer > LDAP and SSL libs compared to Bionic: I'm a bit worried about running pool-debug tests more

Re: Lingering close + unwritten data == failed connections

2020-11-02 Thread Joe Orton
On Sat, Oct 31, 2020 at 01:57:08AM +0100, Yann Ylavic wrote: > On Wed, Oct 28, 2020 at 6:40 PM Joe Orton wrote: > > > > On Wed, Oct 21, 2020 at 05:17:01PM +0100, Adam Hill wrote: > > > On Linux at least, you can see how much unsent data remains by querying > >

Re: svn commit: r1882776 - /httpd/httpd/trunk/.travis.yml

2020-10-29 Thread Joe Orton
On Fri, Oct 23, 2020 at 10:07:39AM +0200, Ruediger Pluem wrote: > > > On 10/23/20 8:24 AM, rpl...@apache.org wrote: > > Author: rpluem > > Date: Fri Oct 23 06:24:55 2020 > > New Revision: 1882776 > > > > URL: http://svn.apache.org/viewvc?rev=1882776=rev > > Log: > > * Two first tests using

Re: Lingering close + unwritten data == failed connections

2020-10-28 Thread Joe Orton
On Wed, Oct 21, 2020 at 05:17:01PM +0100, Adam Hill wrote: > On Linux at least, you can see how much unsent data remains by querying the > SIOCOUTQ ioctl, so the mitigation would be to check to see that ANY data > was draining at all, and if so ( and there's some left ) extend the > lingering

Re: [Bug 64533] Http crashes observed during fuzzing testing

2020-10-09 Thread Joe Orton
On Fri, Oct 09, 2020 at 11:57:38AM +0200, Ruediger Pluem wrote: > Would the following patch makes sense (against trunk)? > > Index: server/mpm/event/event.c > === > --- server/mpm/event/event.c (revision 1882251) > +++

Re: svn commit: r1881552 - /httpd/httpd/trunk/changes-entries/pr64709.txt

2020-09-17 Thread Joe Orton
On Fri, Sep 11, 2020 at 08:26:50AM +0200, Ruediger Pluem wrote: > Thanks for making use of this new approach to document changes. The backport > for this approach misses just one vote. > If it would be backported we could use the full advantages of this approach. Thanks for doing this, it looks

Re: No Travis runs for PR's against 2.4.x?

2020-09-15 Thread Joe Orton
On Tue, Sep 15, 2020 at 01:09:05PM +0200, Ruediger Pluem wrote: > Anyone an idea why https://github.com/apache/httpd/pull/142 which is a > PR against the 2.4.x branch does not trigger a Travis run? It's because you have "[skip ci]" in the second commit. (Do a "git rebase -i origin/2.4.x" and

Re: Broken: apache/httpd#1091 (trunk - 74d32d7)

2020-09-02 Thread Joe Orton
On Wed, Sep 02, 2020 at 12:36:26PM +0200, Ruediger Pluem wrote: > will always fail since node->endp[index] should be zero. Hence it should not > find a pool. Or am I off now? I think we get very little ordering constraints without memory synchronisation, regardless of the order of the C

Re: Trunk warnings win64 1-sept-2020

2020-09-02 Thread Joe Orton
On Tue, Sep 01, 2020 at 09:57:41PM +0200, Christophe JAILLET wrote: > I'll try to fix some of them but it is unlikely that I can fix all of them. > Fixing them would require is many cases to add some casting. I'm not a big > fan of having casting everywhere only to please a given compiler, when

Re: Broken: apache/httpd#1091 (trunk - 74d32d7)

2020-09-02 Thread Joe Orton
On Wed, Sep 02, 2020 at 10:11:39AM +0200, Ruediger Pluem wrote: > > > On 9/2/20 9:10 AM, Joe Orton wrote: > > On Tue, Sep 01, 2020 at 03:11:59PM +0200, Ruediger Pluem wrote: > >> Your point is that there is no case where multiple threads work on the > >> sam

Re: Broken: apache/httpd#1091 (trunk - 74d32d7)

2020-09-02 Thread Joe Orton
On Tue, Sep 01, 2020 at 03:11:59PM +0200, Ruediger Pluem wrote: > Your point is that there is no case where multiple threads work on the same > apr_memcache_conn_t at the same time, correct? > If yes, I agree that this is the case and that I missed this and hence my > point is mood. I think

Re: Broken: apache/httpd#1091 (trunk - 74d32d7)

2020-09-01 Thread Joe Orton
On Tue, Sep 01, 2020 at 01:04:14PM +0200, Ruediger Pluem wrote: > > > On 9/1/20 10:18 AM, Joe Orton wrote: > > On Mon, Aug 31, 2020 at 08:37:55AM +0200, Ruediger Pluem wrote: > >> On 8/30/20 7:22 AM, Christophe JAILLET wrote: > >>> Thread 66 (Thread 0x7f13

Re: Broken: apache/httpd#1091 (trunk - 74d32d7)

2020-09-01 Thread Joe Orton
On Mon, Aug 31, 2020 at 08:37:55AM +0200, Ruediger Pluem wrote: > On 8/30/20 7:22 AM, Christophe JAILLET wrote: > > Thread 66 (Thread 0x7f13a6525700 (LWP 7436)): > > > > #0  0x7f13dd61a187 in kill () from /lib/x86_64-linux-gnu/libc.so.6 > > #1  > > #2  0x7f13dd619e97 in raise () from

Re: Changing the httpd security process

2020-08-20 Thread Joe Orton
On Mon, Aug 17, 2020 at 12:08:35PM +0100, Joe Orton wrote: > This roughly reverts the httpd process to what we used prior to adopting > the Tomcat-esque policy for the whole ASF. We would have to document > this and possibly need it approved by the ASF security team. Thanks to those

Re: svn commit: r1880368 - /httpd/httpd/trunk/docs/manual/style/lang-targets.xml

2020-08-19 Thread Joe Orton
On Wed, Aug 19, 2020 at 10:08:12AM +0200, Christophe JAILLET wrote: > Le 19/08/2020 à 09:47, Joe Orton a écrit : > > Stupid question, why do we need to change the suffix to .utf8 to convert > > these files into UTF-8? > > I don't think it is needed, just a matter of consist

Re: svn commit: r1880368 - /httpd/httpd/trunk/docs/manual/style/lang-targets.xml

2020-08-19 Thread Joe Orton
On Wed, Aug 19, 2020 at 08:36:02AM +0100, Joe Orton wrote: > On Tue, Aug 18, 2020 at 07:08:21AM -0400, Eric Covener wrote: > > On Tue, Aug 18, 2020 at 6:34 AM Joe Orton wrote: > > > > > > On Tue, Jul 28, 2020 at 07:32:01AM -0400, Eric Covener wrote: > > > &

Re: svn commit: r1880368 - /httpd/httpd/trunk/docs/manual/style/lang-targets.xml

2020-08-19 Thread Joe Orton
On Tue, Aug 18, 2020 at 07:08:21AM -0400, Eric Covener wrote: > On Tue, Aug 18, 2020 at 6:34 AM Joe Orton wrote: > > > > On Tue, Jul 28, 2020 at 07:32:01AM -0400, Eric Covener wrote: > > > FYI I am seeing if I can coordinate with Humbedooh to change all the > >

Re: svn commit: r1880368 - /httpd/httpd/trunk/docs/manual/style/lang-targets.xml

2020-08-18 Thread Joe Orton
On Tue, Jul 28, 2020 at 07:32:01AM -0400, Eric Covener wrote: > FYI I am seeing if I can coordinate with Humbedooh to change all the > generated files without one of those 17-part commit threads. > But I will probably just commit in the next few hours either way. Does this still need to be done

Re: svn commit: r1870095 - /httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c

2020-08-17 Thread Joe Orton
On Mon, Aug 17, 2020 at 02:07:33PM +0200, Ruediger Pluem wrote: > On 11/21/19 4:51 PM, jor...@apache.org wrote: > > Author: jorton > > Date: Thu Nov 21 15:51:32 2019 > > New Revision: 1870095 > > > > URL: http://svn.apache.org/viewvc?rev=1870095=rev ... > > @@ -1132,6 +1144,17 @@ static int

Changing the httpd security process

2020-08-17 Thread Joe Orton
At the moment we follow the standard ASF process for handling security vulnerabilities, https://www.apache.org/security/committers.html This includes the following step where fixes are committed with "obscured" commit messages prior to release: "12. The project team commits the fix. No

Re: [VOTE] Release httpd-2.4.46

2020-08-04 Thread Joe Orton
On Tue, Aug 04, 2020 at 01:48:08PM +0200, Rainer Jung wrote: > GDB info (sporadic) Solaris shutdown crashes during OpenSSL shutdown in > mod_watchdog: Awesome level of testing as usual, thanks Rainer! I see similar crashes with mod_watchdog active for 2.4 prefork. I think the trigger is also

Re: [VOTE] Release httpd-2.4.46

2020-08-03 Thread Joe Orton
On Sat, Aug 01, 2020 at 09:13:29AM -0500, Daniel Ruggeri wrote: > Hi, all; >    Third time is a charm! Please find below the proposed release tarball > and signatures: > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release this >

Re: [VOTE] Release httpd-2.4.45

2020-07-30 Thread Joe Orton
On Thu, Jul 30, 2020 at 11:55:09AM +0200, Christophe JAILLET wrote: > I've not tested yet, but looking at Steffen Land compilation error logs on > Windows, I've been surprised by: > >    Warning    C4003    modules\proxy\mod_proxy_fcgi.c    180 not enough > arguments for function-like macro

Re: [VOTE] Release httpd-2.4.45

2020-07-29 Thread Joe Orton
On Wed, Jul 29, 2020 at 10:26:27AM -0500, Daniel Ruggeri wrote: > Hi, all; >    Please find below the proposed release tarball and signatures: > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release this > candidate tarball as 2.4.45: >

Re: libapreq2 status & security release

2020-07-24 Thread Joe Orton
On Fri, Jul 24, 2020 at 03:57:18PM +0300, Issac Goldstand wrote: > > > Anything I'm missing? > > > In theory, no.  In practice I remember it being very difficult to test > properly last time I tried to RM, with a recent Perl and httpd. > > I can't imagine it will be easier, so we should be

libapreq2 status & security release

2020-07-24 Thread Joe Orton
The latest release of libapreq2 (v2.13) has an outstanding security issue, CVE-2019-12412, which was fixed in apreq trunk at https://svn.apache.org/r1866760 and subsequently assigned a CVE name when a Debian user & maintainer noticed it was a security issue. libapreq2 trunk was folded into

Re: svn commit: r1879591 - in /httpd/httpd/trunk: configure.in server/log.c

2020-07-15 Thread Joe Orton
On Wed, Jul 15, 2020 at 04:03:41PM +0200, Graham Leggett wrote: > On 15 Jul 2020, at 15:35, Joe Orton wrote: > > >> checking for gettid()... yes > > > > Interesting, can you provide the config.log and "rpm -q glibc"? With a > > RHEL8 vm here it does

Re: svn commit: r1879591 - in /httpd/httpd/trunk: configure.in server/log.c

2020-07-15 Thread Joe Orton
On Wed, Jul 15, 2020 at 02:58:43PM +0200, Graham Leggett wrote: > On 07 Jul 2020, at 15:40, jor...@apache.org wrote: > > Author: jorton > > Date: Tue Jul 7 13:40:15 2020 > > New Revision: 1879591 > > > > URL: http://svn.apache.org/viewvc?rev=1879591=rev > > Log: > > Check for and use gettid()

Re: Still Failing: apache/httpd#896 (trunk - 9af2218)

2020-06-29 Thread Joe Orton
On Mon, Jun 29, 2020 at 11:16:54AM +0200, Graham Leggett wrote: > On 29 Jun 2020, at 09:19, Joe Orton wrote: > > > The litmus tests are failing, not the perl-framework tests: > > > > https://travis-ci.org/github/apache/httpd/jobs/702768269#L2491 > > Ah - t

Re: Still Failing: apache/httpd#896 (trunk - 9af2218)

2020-06-29 Thread Joe Orton
On Sun, Jun 28, 2020 at 05:15:03PM +0200, Graham Leggett wrote: > On 28 Jun 2020, at 15:47, Travis CI wrote: > > > apache / httpd > > trunk > > Build #896 is still failing9 mins and 44 secs > > Travis mavens, I’ve been looking for the test/perl-framework directory > as referred to in

Re: s390x, ppc64le and arm64 Travis jobs always fail

2020-06-23 Thread Joe Orton
On Tue, Jun 23, 2020 at 12:14:01PM +0200, Yann Ylavic wrote: > Argh, fixed in r1879110 (hopefully). Thanks a lot, looking green! If we didn't find some actual bugs I would feel like burning thousands of hours of CPU time in CI was a wasted effort ;)

Re: s390x, ppc64le and arm64 Travis jobs always fail

2020-06-23 Thread Joe Orton
On Tue, Jun 23, 2020 at 10:53:13AM +0100, Joe Orton wrote: > On Fri, Jun 19, 2020 at 02:21:48PM +0100, Joe Orton wrote: > > so if Apache-Test is trying to connect to ::1 but httpd is only > > listening on AF_INET port 80, it will look like the server is not > > running, even

  1   2   3   4   5   6   7   8   9   10   >