Re: [2.4.39] [mod_auth_form] [mod_session_crypto] Cookie management performance

2019-05-10 Thread Marion & Christophe JAILLET
Hi, have you checked the work in trunk related to "SessionExpiryUpdateInterval"? [1] If you have the opportunity to compile and test the trunk version and report if it corresponds to your use case, it would be great. If you want to have a look at the code itself, see [2]. Just my 2c, CJ

Re: [VOTE] Release httpd-2.4.39

2019-03-29 Thread Marion & Christophe JAILLET
Le 27/03/2019 à 16:09, Daniel Ruggeri a écrit : Hi, all;    Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball as 2.4.39: [ ] +1: It's not just good,

Re: svn commit: r1856208 - /httpd/test/framework/trunk/t/apache/mergeslashes.t

2019-03-26 Thread Marion & Christophe JAILLET
Le 26/03/2019 à 22:52, Eric Covener a écrit : # GET /authz_core/a/b/c//index.html HTTP/1.1\r\nHost: merge-disabled\r\nConnection: close\r\n\r\n # expected 200, got 403 for c// doesn't match locationmatch not ok 7 # Test 7 got: "403" (t/apache/mergeslashes.t at line 73 fail #7)

Re: Regression?

2019-02-18 Thread Marion & Christophe JAILLET
Le 18/02/2019 à 23:55, Gregg Smith a écrit : When setting a header it used to set the header case-sensitive as configured. Now with 2.4.38 it sets in all lower case. Regression? Header always set X-Xss-Protection "1; mode=block" Result; 2.4.37: X-Xss-Protection: 1; mode=block 2.4.38:

Re: svn commit: r32075 - /dev/httpd/ /release/httpd/

2019-01-21 Thread Marion & Christophe JAILLET
Fixed in r32079. I hope I did it right. CJ Le 21/01/2019 à 17:48, Marion et Christophe JAILLET a écrit : s/September/January/ in the announcement (html and txt) CJ > Message du 21/01/19 16:03 > De : drugg...@apache.org > A : c...@httpd.apache.org > Copie à : > Objet :

Re: Testing regime during httpd development/release

2019-01-13 Thread Marion & Christophe JAILLET
Hi Nik, There is no formal workflow advised to follow. However, it is the responsibility of every committer to keep the code compile-able and run-able. However, a few more explanations and precisions. When some code is added/modified, it must be committed in trunk first. trunk is a CTR

Re: Stale BZ Bug Tracker reports

2018-11-01 Thread Marion & Christophe JAILLET
Le 31/10/2018 à 21:52, William A Rowe Jr a écrit : There are 715 reports tagged 2.0.0 through 2.3-HEAD of Status NEW or NEEDINFO with no Resolution. For these bugs I believe we should simply close them with a message that this is a mass-update, that the version is beyond EOL, and a request

Re: Test framework regressions - spelling and usertrack

2018-10-22 Thread Marion & Christophe JAILLET
Le 22/10/2018 à 16:56, Jim Jagielski a écrit : The latest update to usertrack works. Thx! speling still bad: On httpd-2.4 HEAD: t/modules/speling.t . 1/48 # Failed test 11 in t/modules/speling.t at line 46 fail #6 # Failed test 12 in t/modules/speling.t at line 50

Re: Test framework regressions - spelling and usertrack

2018-10-22 Thread Marion & Christophe JAILLET
Le 22/10/2018 à 16:16, Rainer Jung a écrit : Am 22.10.2018 um 15:45 schrieb Yann Ylavic: On Mon, Oct 22, 2018 at 3:28 PM Yann Ylavic wrote: On Mon, Oct 22, 2018 at 3:09 PM Jim Jagielski wrote: These are new from a coupla day ago: Both tests were added a few days ago, so probably not

Re: RESULT: Passed - [VOTE] Release httpd-2.4.35

2018-09-21 Thread Marion & Christophe JAILLET
FYI, 2.4.35 version has been added to bz. CJ Le 21/09/2018 à 14:31, Daniel Ruggeri a écrit : Hi, all;    I am delighted to share that the vote to release Apache httpd-2.4.35 has PASSED. The following votes were recorded: Binding +1: minfrin, icing, jorton, gsmith, steffenal, covener,

Re: [Bug 62318] healthcheck

2018-08-24 Thread Marion & Christophe JAILLET
Yes, agreed. CJ Le 24/08/2018 à 18:05, Eric Covener a écrit : On Fri, Aug 24, 2018 at 11:57 AM Christophe JAILLET wrote: Le 24/08/2018 à 16:40, Jim Jagielski a écrit : I was wondering if someone wanted to provide a sanity check on the above PR and what's "expected" by the health check

Re: alias.t/extra.conf.in change 1829008

2018-08-21 Thread Marion & Christophe JAILLET
Le 21/08/2018 à 15:27, pgajdos a écrit : Hello Christophe, On Mon, Aug 20, 2018 at 08:34:16PM +0200, Marion & Christophe JAILLET wrote: according to https://httpd.apache.org/docs/2.4/en/mod/mod_alias.html#alias, Alias with-in a LocationMatch is allowed since 2.4.19. If you can

Re: We have soon 5 SVN repo's

2017-11-04 Thread Marion & Christophe JAILLET
Hi, So 2.5.0-alpha will be RTC. Good for me, it is what I personally prefer. Will it be a fork of latest 2.4.x and trunk things will have to be proposed, voted and backported? Or will it be a fork from trunk with things likely never (IMHO) really reviewed? My own opinion is a copy of 2.4.x +

Re: svn commit: r1813027 - /httpd/httpd/branches/2.4.x/STATUS

2017-11-01 Thread Marion & Christophe JAILLET
Same analysis here. The 2 declarations are the same. CJ Le 01/11/2017 à 11:02, Rainer Jung a écrit : Hi Bill, Am 31.10.2017 um 21:29 schrieb William A Rowe Jr: On Mon, Oct 23, 2017 at 10:17 AM, wrote: Author: ylavic Date: Mon Oct 23 15:17:02 2017 New Revision: 1813027

Re: Pruning working branches (Was: Re: Why?)

2017-10-25 Thread Marion & Christophe JAILLET
+1 Le 24/10/2017 à 23:05, William A Rowe Jr a écrit : On Tue, Oct 24, 2017 at 8:11 AM, William A Rowe Jr wrote: On Tue, Oct 24, 2017 at 3:28 AM, Steffen wrote: On Tuesday 24/10/2017 at 10:26, Steffen wrote: Can someone clean up the not needed

Re: svn commit: r1787104 - /httpd/httpd/branches/2.4.x/STATUS

2017-03-21 Thread Marion & Christophe JAILLET
Hi, +static const char *cmd_servertype(cmd_parms *cmd, void *in_dconf, + const char *val) +{ +[...] +else if (!strcasecmp(val, "FPM") || !strcasecmp(val, "PHP-FPM")) { Why? PHP-FPM is not documented, neither in the doc, nor in AP_INIT_TAKE1. In

Re: server-status script donated to ASF

2017-03-20 Thread Marion & Christophe JAILLET
Hi, when running, the page get longer 5 seconds or so. In the JS code, there is: // resize pane document.getElementById('leftpane').style.height = document.getElementById('wrapper').getBoundingClientRect().height + "px"; I guess that is "growing page" is coming from there.

Re: svn commit: r1787525 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_autoindex.xml modules/generators/mod_autoindex.c

2017-03-18 Thread Marion & Christophe JAILLET
Le 18/03/2017 à 03:51, cove...@apache.org a écrit : Author: covener Date: Sat Mar 18 02:51:02 2017 New Revision: 1787525 URL: http://svn.apache.org/viewvc?rev=1787525=rev Log: Add IndexOptions UseOldDateFormat *) mod_autoindex: Add IndexOptions UseOldDateFormat to allow the date

Re: svn commit: r1783413 - in /httpd/httpd/branches/2.4.x: ./ STATUS server/mpm/event/event.c

2017-02-17 Thread Marion & Christophe JAILLET
No CHANGES entry? CJ Le 17/02/2017 à 16:36, j...@apache.org a écrit : Author: jim Date: Fri Feb 17 15:36:02 2017 New Revision: 1783413 URL: http://svn.apache.org/viewvc?rev=1783413=rev Log: Merge r1774541 from trunk: event: close a race condition where we might re-enable listeners while

Re: JSON for mod_status

2017-01-21 Thread Marion & Christophe JAILLET
++1 :) Author: jailletc36 Date: Fri Jan 6 07:19:20 2017 New Revision: 1777535 URL:http://svn.apache.org/viewvc?rev=1777535=rev Log: update Modified: httpd/httpd/trunk/STATUS Modified: httpd/httpd/trunk/STATUS

Re: [VOTE] Release Apache httpd 2.4.25 as GA

2016-12-17 Thread Marion & Christophe JAILLET
Proposed fix in r1774728. A solution, stating that the tests have been skipped because of sed location, would be better, though. CJ Le 16/12/2016 à 21:46, Jacob Champion a écrit : On 12/16/2016 12:44 PM, William A Rowe Jr wrote: I expect this is a bug in the 2.4.x branch. However, I found

Re: svn commit: r1769900 - /httpd/httpd/trunk/docs/manual/mod/mod_headers.html.en

2016-11-15 Thread Marion & Christophe JAILLET
Hi, why removing compatibility note (i.e. 2.4.7) ? CJ Le 15/11/2016 à 23:57, elu...@apache.org a écrit : Author: elukey Date: Tue Nov 15 22:57:36 2016 New Revision: 1769900 URL: http://svn.apache.org/viewvc?rev=1769900=rev Log: documentation rebuild Modified:

Re: svn commit: r1756560 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS include/ap_mmn.h modules/dav/main/mod_dav.c modules/dav/main/mod_dav.h

2016-08-16 Thread Marion & Christophe JAILLET
Hi, Le 17/08/2016 à 01:17, yla...@apache.org a écrit : Author: ylavic Date: Tue Aug 16 23:17:46 2016 New Revision: 1756560 URL: http://svn.apache.org/viewvc?rev=1756560=rev Log: Merge r1746207 from trunk: mod_dav: Add support for childtags to dav_error. Submitted by: minfrin Reviewed by:

Re: T 2.4.23 tomorrow (Thurs) ??

2016-06-23 Thread Marion & Christophe JAILLET
Well, perl seems to be at the expected place but perlsub.pod seems to be nowhere. Must be an issue on my test environment or a file not included in my distro or a change between perl 5.18 and 5.22 Thx for your time and explanation. CJ Le 23/06/2016 à 10:55, Stefan Eissing a écrit : As

Re: T 2.4.23 tomorrow (Thurs) ??

2016-06-23 Thread Marion & Christophe JAILLET
= 0.55 CPU) Result: PASS Am 23.06.2016 um 10:08 schrieb Marion & Christophe JAILLET <christophe.jail...@wanadoo.fr>: Le 22/06/2016 à 22:05, Jim Jagielski a écrit : Subj sez it all... afaict, there are no showstoppers and no outstanding issues (none seen in STATUS, or noted as such on

Re: T 2.4.23 tomorrow (Thurs) ??

2016-06-23 Thread Marion &amp; Christophe JAILLET
Le 22/06/2016 à 22:05, Jim Jagielski a écrit : Subj sez it all... afaict, there are no showstoppers and no outstanding issues (none seen in STATUS, or noted as such on any Email threads). So... anyone opposed to a T tomorrow in the hopes of getting this out to people by the start of next

Re: svn commit: r1747056 - in /httpd/httpd/branches/2.4.x: ./ STATUS modules/mappers/mod_rewrite.c

2016-06-07 Thread Marion &amp; Christophe JAILLET
Le 07/06/2016 à 06:59, William A Rowe Jr a écrit : On Mon, Jun 6, 2016 at 3:10 PM, Marion & Christophe JAILLET <christophe.jail...@wanadoo.fr <mailto:christophe.jail...@wanadoo.fr>> wrote: ap_casecmpstr breaks 2.4.x build. Keep strncasecmp for now? (waiting for a

Re: svn commit: r1747056 - in /httpd/httpd/branches/2.4.x: ./ STATUS modules/mappers/mod_rewrite.c

2016-06-06 Thread Marion &amp; Christophe JAILLET
ap_casecmpstr breaks 2.4.x build. Keep strncasecmp for now? (waiting for ap_cstr_casecmp[n]) CJ Le 06/06/2016 à 21:11, j...@apache.org a écrit : Author: jim Date: Mon Jun 6 19:11:20 2016 New Revision: 1747056 URL: http://svn.apache.org/viewvc?rev=1747056=rev Log: Merge r1744206 from trunk:

Re: svn commit: r1743577 [1/2] - in /httpd/httpd/branches/2.4.x: docs/manual/mod/mod_proxy_http2.xml modules/http2/NWGNUproxyht2 modules/http2/h2_proxy_session.c modules/http2/h2_proxy_session.h modul

2016-05-12 Thread Marion &amp; Christophe JAILLET
Hi, there are 2 valid issues spotted by smatch in debug logging message: modules/http2/h2_proxy_session.c:339 on_data_chunk_recv() error: we previously assumed 'stream' could be null (see line 338) modules/http2/h2_proxy_session.c:425 stream_data_read() error: we previously assumed

Re: svn commit: r1743577 [1/2] - in /httpd/httpd/branches/2.4.x: docs/manual/mod/mod_proxy_http2.xml modules/http2/NWGNUproxyht2 modules/http2/h2_proxy_session.c modules/http2/h2_proxy_session.h modul

2016-05-12 Thread Marion &amp; Christophe JAILLET
Hi all, mod_proxy_http2 does not compile because of changes made in mod_hhtp2: - h2_ihash_is_empty vs h2_ihash_empty - h2_request_create vs h2_req_create - modified header files - ... If not fixed in the mean time, I'll give a look at it tonight. Do we need to go thru the formal

Re: svn commit: r1736683 - /httpd/httpd/trunk/docs/manual/mod/mod_authnz_ldap.xml

2016-03-26 Thread Marion &amp; Christophe JAILLET
As far as I've seen, directive names used within the corresponding bloc do not have a link to themselves. That's why I have removed some in this commit. In the same commit, I've also added some missing module= for some other directives in order to keep the link to them. As an example, in

Re: svn commit: r1735610 - in /httpd/httpd/branches/2.4.x: ./ modules/http2/

2016-03-19 Thread Marion &amp; Christophe JAILLET
Le 18/03/2016 15:48, ic...@apache.org a écrit : Author: icing Date: Fri Mar 18 14:48:36 2016 New Revision: 1735610 URL: http://svn.apache.org/viewvc?rev=1735610=rev Log: Merge of 1735608,1735609 from trunk: mod_http2: stream cleanup on GOAWAY handling, PUSHes prohibited after client GOAWAY.

Re: svn commit: r1729495 [2/2] - in /httpd/httpd/branches/2.4.x: ./ modules/aaa/ modules/arch/win32/ modules/core/ modules/examples/ modules/filters/ modules/http2/ modules/loggers/ modules/lua/ modul

2016-02-22 Thread Marion &amp; Christophe JAILLET
Le 22/02/2016 22:21, Rainer Jung a écrit : Am 15.02.2016 um 07:28 schrieb Christophe JAILLET: Le 10/02/2016 00:09, rj...@apache.org a écrit : Modified: httpd/httpd/branches/2.4.x/server/mpm/event/event.c URL:

Re: [PATCH] Reduce memory footprint in mod_dav's property code

2015-12-21 Thread Marion &amp; Christophe JAILLET
You can also have a look at https://bz.apache.org/bugzilla/show_bug.cgi?id=48130 Le 22/12/2015 01:13, Stefan Fuhrmann a écrit : Hi, I stumbled over this while investigation an OOM report from a Subversion user [1]. Due to unfortunate circumstances [2], I've seen directory listings with a few

Re: svn commit: r1717123 - /httpd/httpd/trunk/docs/manual/mod/mod_allowmethods.xml

2015-12-02 Thread Marion &amp; Christophe JAILLET
Will fix. Sorry for not seeing it myself. CJ Le 02/12/2015 15:28, Mike Rumph a écrit : Comment below. On 11/29/2015 1:00 PM, jaillet...@apache.org wrote: Author: jailletc36 Date: Sun Nov 29 21:00:32 2015 New Revision: 1717123 URL: http://svn.apache.org/viewvc?rev=1717123=rev Log: Fix doc as

Re: svn commit: r1715876 - in /httpd/httpd/trunk: modules/cache/ modules/filters/ modules/generators/ modules/http/ modules/http2/ modules/loggers/ modules/mappers/ modules/metadata/ modules/proxy/ mo

2015-11-23 Thread Marion &amp; Christophe JAILLET
Hi, 1 typo below. Moreover, this kind of patch is a good candidate for backport as it introduces many small differences between 2.4 and trunk. Without a backport, backporting future patches may become a nightmare. I would find useful to split it into several pieces. The first one should

Re: strncasecmp

2015-11-23 Thread Marion &amp; Christophe JAILLET
I just made a small application which takes as command line parameters the number of iteration to run, which version of the algorithm to use, the 2 strings to compare and the length to compare (or 0 for the non 'n' versions) Compiled using gcc -O3 test.c Tested using

Re: svn commit: r1715294 - /httpd/httpd/trunk/server/core.c

2015-11-20 Thread Marion &amp; Christophe JAILLET
That was I first thought too. When I looked at r1715255, I noticed: const char *conn = apr_table_get(r->headers_in, "Connection"); if (ap_find_token(r->pool, conn, "upgrade")) { and looked for inconsistencies. When digging deeper, I found that "Connection Upgrade" was used in

Re: svn commit: r1703305 - /httpd/httpd/trunk/modules/aaa/mod_auth_digest.c

2015-10-06 Thread Marion &amp; Christophe JAILLET
Le 05/10/2015 12:03, Plüm, Rüdiger, Vodafone Group a écrit : -Original Message- From: Marion & Christophe JAILLET [mailto:christophe.jail...@wanadoo.fr] Sent: Samstag, 3. Oktober 2015 21:57 To: dev@httpd.apache.org Subject: Re: svn commit: r1703305 - /httpd/httpd/trunk/modules

Re: svn commit: r1703305 - /httpd/httpd/trunk/modules/aaa/mod_auth_digest.c

2015-10-03 Thread Marion &amp; Christophe JAILLET
Le 01/10/2015 20:32, Ruediger Pluem a écrit : On 09/16/2015 12:20 AM, jaillet...@apache.org wrote: Author: jailletc36 Date: Tue Sep 15 22:20:45 2015 New Revision: 1703305 URL: http://svn.apache.org/r1703305 Log: Remove code related to 'AuthDigestEnableQueryStringHack' This has been

Re: svn commit: r1705492 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ server/ server/mpm/event/ server/mpm/netware/ server/mpm/prefork/ server/mpm/winnt/ server/mpm/worker/

2015-09-28 Thread Marion &amp; Christophe JAILLET
Le 28/09/2015 21:54, Ruediger Pluem a écrit : Modified: httpd/httpd/branches/2.4.x/include/ap_mmn.h URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/include/ap_mmn.h?rev=1705492=1705491=1705492=diff == ---

Re: svn commit: r1705492 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ server/ server/mpm/event/ server/mpm/netware/ server/mpm/prefork/ server/mpm/winnt/ server/mpm/worker/

2015-09-27 Thread Marion &amp; Christophe JAILLET
Hi, should r1629916 also be included? The changelog says that it is a follow up to r1629909, which is included in the patch below. CJ Le 27/09/2015 00:20, minf...@apache.org a écrit : Author: minfrin Date: Sat Sep 26 22:20:14 2015 New Revision: 1705492 URL:

Re: svn commit: r1694950 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_request.c

2015-08-09 Thread Marion Christophe JAILLET
Hi, doesn't it require a minor ap_mmn.h bump ? cj Le 10/08/2015 05:30, gsm...@apache.org a écrit : Author: gsmith Date: Mon Aug 10 03:30:25 2015 New Revision: 1694950 URL: http://svn.apache.org/r1694950 Log: ap_process_request needs exportation for use in mod_h2 on Windows Modified:

Re: Issue with bugzilla for BZ #57992 and #57993

2015-06-30 Thread Marion Christophe JAILLET
Should have read the whole message... Sent to bugzilla-ad...@apache.org CJ Le 01/07/2015 07:08, Christophe JAILLET a écrit : Hi, I wanted to CLOSE bug #57992 and #57993 as INVALID. Strangely, they apparently have never been sent to b...@httpd.apache.org (at least according to the mail

Re: svn commit: r1683044 - /httpd/httpd/trunk/server/core.c

2015-06-04 Thread Marion Christophe JAILLET
Hi, Skip a few bytes before calling 'strchr' if we know that they can't match. = in 'ap_resolve_env', at line 1265 we have: if (*s == '$') { if (s[1] == '{' (e = ap_strchr_c(s, '}'))) { So, we looking for an

Re: [VOTE] Simplified 2.2.x EOL Decision

2015-05-27 Thread Marion Christophe JAILLET
Le 28/05/2015 06:44, William A Rowe Jr a écrit : Choose one; [ ] EOL the 2.2.x branch effective 5/31/16; strictly security releases to that date [X] Defer a 2.2.x EOL decision for 6 months and re-consider this proposal in Nov, '15.

Re: svn commit: r1673904 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS docs/manual/mod/mod_logio.xml modules/loggers/mod_logio.c

2015-04-15 Thread Marion Christophe JAILLET
Hi, compatibility note is missing in the doc. BTW, what is the reason of the LogIOTrackTTFB directive? No impact on performance if %^FB is not needed? CJ Le 15/04/2015 19:59, cove...@apache.org a écrit : Author: covener Date: Wed Apr 15 17:59:42 2015 New Revision: 1673904 URL:

Re: svn commit: r1661409 - in /httpd/httpd/branches/2.4.x/docs/manual: ./ mod/ platform/ rewrite/

2015-02-22 Thread Marion Christophe JAILLET
Le 21/02/2015 18:21, lgen...@apache.org a écrit : Modified: httpd/httpd/branches/2.4.x/docs/manual/mod/mod_auth_form.html.fr URL:http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/docs/manual/mod/mod_auth_form.html.fr?rev=1661409r1=1661408r2=1661409view=diff

Re: New to Apache

2015-01-22 Thread Marion Christophe JAILLET
Hi, if you don't have any idea yet on what you would like to work on, maybe a good start is to go thrue our bugzilla. Look at subjects you understand or that seem easy. If a patch is already proposed you can try and test it, then report any feedback. If no patch is available, you can propose

Re: svn commit: r1651084 - in /httpd/httpd/branches/2.4.x: CHANGES STATUS include/ap_mmn.h include/http_log.h server/log.c

2015-01-12 Thread Marion Christophe JAILLET
Hi, the commit message is wrong for this one. Cut'n paste error from the previous one. Won't have time myself to fix it in the comming days. Best regards CJ Le 12/01/2015 14:39, j...@apache.org a écrit : Author: jim Date: Mon Jan 12 13:39:07 2015 New Revision: 1651084 URL:

Re: svn commit: r1638879 - /httpd/httpd/trunk/server/mpm/event/event.c

2014-11-15 Thread Marion Christophe JAILLET
Done in r1639960. CJ Le 15/11/2014 08:32, Marion Christophe JAILLET a écrit : Hi, the same pattern exists in eventopt. CJ Le 12/11/2014 18:32, cove...@apache.org a écrit : Author: covener Date: Wed Nov 12 17:32:24 2014 New Revision: 1638879 URL: http://svn.apache.org/r1638879 Log: avoid

Re: svn commit: r1638879 - /httpd/httpd/trunk/server/mpm/event/event.c

2014-11-14 Thread Marion Christophe JAILLET
Hi, the same pattern exists in eventopt. CJ Le 12/11/2014 18:32, cove...@apache.org a écrit : Author: covener Date: Wed Nov 12 17:32:24 2014 New Revision: 1638879 URL: http://svn.apache.org/r1638879 Log: avoid dereferencing a recently apr_pool_clear()'ed event_conn_state_t *cs in several

Re: svn commit: r1632736 - in /httpd/httpd/branches/2.4.x: CHANGES STATUS modules/proxy/mod_proxy_http.c

2014-10-18 Thread Marion Christophe JAILLET
Hi, Isn't there the same kind of potential issue in: mod_buffer, line 268 mod_cahce, line 687 Best regards, CJ Le 18/10/2014 08:57, jaillet...@apache.org a écrit : Author: jailletc36 Date: Sat Oct 18 06:57:40 2014 New Revision: 1632736 URL: http://svn.apache.org/r1632736 Log: Merge

Re: svn commit: r1628919 - in /httpd/httpd/trunk: CHANGES modules/filters/mod_substitute.c

2014-10-14 Thread Marion Christophe JAILLET
Le 14/10/2014 19:55, Rainer Jung a écrit : Am 14.10.2014 um 14:22 schrieb Christophe JAILLET: Hi, this patch is in the backport proposal for 2.4.x. See my remarks below. The only one that worse it is the one for comparison on new varbuf length either with or with = Best regards, CJ Le

Re: svn commit: r1629507 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number modules/cache/mod_cache_socache.c

2014-10-05 Thread Marion Christophe JAILLET
Hi, apparently this add a new build warning: mod_cache_socache.c:1425:6: warning: no previous prototype for 'socache_status_register' [-Wmissing-prototypes] Adding static fixes it. CJ Le 05/10/2014 19:00, rj...@apache.org a écrit : Author: rjung Date: Sun Oct 5 17:00:31 2014 New

Re: svn commit: r1629508 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache_socache.c

2014-10-05 Thread Marion Christophe JAILLET
Hi, is it related to PR57023 ? CJ Le 05/10/2014 19:05, rj...@apache.org a écrit : Author: rjung Date: Sun Oct 5 17:05:21 2014 New Revision: 1629508 URL: http://svn.apache.org/r1629508 Log: mod_cache_socache: Change average object size hint from 32 bytes to 2048 bytes. Modified:

Re: Coding standards, avoiding vulnerabilities in httpd

2014-09-16 Thread Marion Christophe JAILLET
Le 16/09/2014 22:09, Notes Jonny a écrit : Hello I had a quick look at httpd 2.4.10 (couldn't find on the website how to site how to checkout the trunk) See http://httpd.apache.org/dev/devnotes.html CJ

Re: svn commit: r1621806 - in /httpd/httpd/trunk: modules/loggers/mod_journald.c modules/mappers/mod_negotiation.c modules/proxy/mod_proxy_wstunnel.c server/util_expr_eval.c

2014-09-01 Thread Marion Christophe JAILLET
It is not an issue, it was just to silent some cppcheck warnings. In these 2 cases, it is obvious that explicitly initializing these variables is useless because it is assigned just a few lines after. Moreover: - mod_negotiation.c: set just the line after. - mod_proxy_wstunnel.c: the

Re: svn commit: r1612653 - /httpd/httpd/trunk/server/util_pcre.c

2014-07-22 Thread Marion Christophe JAILLET
+1 Le 22/07/2014 23:01, Rainer Jung a écrit : On 22.07.2014 22:20, Christophe JAILLET wrote: Hi, shouldn't the #error just a few lines below be updated as well, to be more explicit than too old ? You are right. But what about instead changing the configure pcre version test: Index:

Re: Question about APLOGNO

2014-07-20 Thread Marion Christophe JAILLET
Hi I have proposed for backport for 2.4. See STATUS. http://svn.apache.org/r1611978 http://svn.apache.org/r1612068 should merge without any trouble and should not generate any conflict with code only in trunk, should it be backported one day. What I have submitted and not proposed for

Re: svn commit: r1611252 - /httpd/httpd/trunk/include/util_varbuf.h

2014-07-17 Thread Marion Christophe JAILLET
Thanks Mike, Both have been fixed. CJ Le 17/07/2014 21:50, Mike Rumph a écrit : A few comments on typos below: On 7/16/2014 10:34 PM, jaillet...@apache.org wrote: Improve layout, add trailing '.' in function description, capitalize first letter of description, fix typo, turn \0 into \\0.

Re: svn commit: r1610509 - /httpd/httpd/trunk/modules/generators/mod_cgid.c

2014-07-14 Thread Marion Christophe JAILLET
Hi, no APLOGNO ? Best regards, CJ Le 14/07/2014 22:08, cove...@apache.org a écrit : Author: covener Date: Mon Jul 14 20:08:25 2014 New Revision: 1610509 URL: http://svn.apache.org/r1610509 Log: *) SECURITY: CVE-2014-0231 (cve.mitre.org) mod_cgid: Fix a denial of service against CGI

Re: svn commit: r1610509 - /httpd/httpd/trunk/modules/generators/mod_cgid.c

2014-07-14 Thread Marion Christophe JAILLET
Le 14/07/2014 22:28, Eric Covener a écrit : On Mon, Jul 14, 2014 at 4:27 PM, Marion Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Hi, no APLOGNO ? ty, can you help remedy in trunk and 2.4? np. I also have added empty APLOGNO in mod_deflate + fix a comment. r1610518 in trunk

Re: svn commit: r1608762 - in /httpd/httpd/branches/2.4.x: ./ CHANGES modules/proxy/proxy_util.c

2014-07-08 Thread Marion Christophe JAILLET
Le 08/07/2014 15:16, j...@apache.org a écrit : Author: jim Date: Tue Jul 8 13:16:27 2014 New Revision: 1608762 URL: http://svn.apache.org/r1608762 Log: Merge r1588519 from trunk: mod_proxy: When ping/pong is configured for a worker, don't send or forward 100 Continue (interim)

Re: svn commit: r1604373 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS support/ab.c

2014-06-21 Thread Marion Christophe JAILLET
Hi, doc should also be updated accordingly + compatibility note should be added to state in which version this -m option has been added. For your information,, I have a pending patch on my computer for missing compatibility notes in support applications updated in previous releases. Will

Re: svn commit: r1598299 - in /httpd/httpd/branches/2.2.x/docs/manual/mod: mod_autoindex.html.fr mod_autoindex.xml.ja mod_autoindex.xml.ko mod_autoindex.xml.tr

2014-05-29 Thread Marion Christophe JAILLET
Le 29/05/2014 16:12, lgen...@apache.org a écrit : Author: lgentis Date: Thu May 29 14:11:59 2014 New Revision: 1598299 URL: http://svn.apache.org/r1598299 Log: Rebuild. Modified: httpd/httpd/branches/2.2.x/docs/manual/mod/mod_autoindex.html.fr Modified:

Re: svn commit: r1594088 - in /httpd/httpd/branches/2.4.x/docs/manual/mod: mod_rewrite.html.en mod_rewrite.xml

2014-05-12 Thread Marion Christophe JAILLET
Hi, in addition to my patch, what is listed as specials in RewriteCond Server-Variables is not that special to mod_rewrite and are also available here: http://httpd.apache.org/docs/2.4/en/expr.html#vars. So, IMHO, this specials category could be dropped and its items moved in the other

Re: svn commit: r1592529 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_scgi.c modules/proxy/proxy_util.c

2014-05-05 Thread Marion Christophe JAILLET
Hi, why not having SCGI_DEFAULT_PORT in a .h file, just as AJP13_DEF_PORT? This would avoid using SCGI_DEFAULT_PORT in one place and 4000 in another. Moreover, this could be renamed as SCGI_DEF_PORT to be consistent with AJP. Just my 2 cents. CJ Le 05/05/2014 16:02, traw...@apache.org a

Re: svn commit: r1592529 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_scgi.c modules/proxy/proxy_util.c

2014-05-05 Thread Marion Christophe JAILLET
); else sport[0] = '\0'; [...] } All, except scgi, use a :%d. scgi has :%u. To be consistent, I think that %u should be used in all places. CJ Le 05/05/2014 20:59, Marion Christophe JAILLET a écrit : Hi, why not having SCGI_DEFAULT_PORT in a .h file, just as AJP13_DEF_PORT

Re: svn commit: r1592615 - in /httpd/httpd/trunk/modules/proxy: mod_proxy_scgi.c proxy_util.c scgi.h

2014-05-05 Thread Marion Christophe JAILLET
Thanks :) The comment also answer a question I had: Where does this default 4000 comes from? /** @} */ missing ? CJ Le 05/05/2014 21:26, traw...@apache.org a écrit : Author: trawick Added: httpd/httpd/trunk/modules/proxy/scgi.h URL:

Re: svn commit: r1588704 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_util.c

2014-04-20 Thread Marion Christophe JAILLET
Hi, The description and the CHANGES are about AH00784 but the patch is only about adding 'status' to AH00783. -else if (APR_EEXIST == status) { +else if (APR_STATUS_IS_EEXIST(status)) { seems not to change anything. #define APR_STATUS_IS_EEXIST(s) ((s) == APR_EEXIST) So, is

Re: svn commit: r1588244 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS docs/manual/mod/mod_headers.xml modules/metadata/mod_headers.c

2014-04-17 Thread Marion Christophe JAILLET
Hi, Changelog entry is about Header and RequestHeader but doc has only been updated for the first one. Moreover, a compatibility note should be, IMO, added for the updated syntax. CJ Le 17/04/2014 15:36, j...@apache.org a écrit : Changes with Apache 2.4.10 + *) mod_headers: Allow

Re: svn commit: r1584896 - /httpd/httpd/trunk/modules/filters/mod_proxy_html.c

2014-04-17 Thread Marion Christophe JAILLET
r1588356 Should you share my analysis and should a CHANGE be useful for what I think is a corner case, feel free to add something, or I can do it by the end of the week. Does this fix a crash or a parsing error or ...? (CHANGES)

Re: svn commit: r1584896 - /httpd/httpd/trunk/modules/filters/mod_proxy_html.c

2014-04-15 Thread Marion Christophe JAILLET
Hi, AFAIK, no crash has ever been reported for that. I just noted this while looking at PR56287 and found it odd. A file such as: +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+- htmlhead meta http-equiv=Conten contentheadbody/body/html +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+- will trigger the scan past the end

Re: svn commit: r1584941 - /httpd/httpd/branches/2.4.x/STATUS

2014-04-05 Thread Marion Christophe JAILLET
Hi, I've gone quickly thru the module and I have a few remarks: - What is the use of FN_LOG_MARK on line 87? Couldn't we use APLOG_MARK instead? 'connect_to_peer' is called only in one place with module_index=APLOG_MODULE_INDEX - Do things like

Re: svn commit: r1584582 - /httpd/httpd/branches/2.4.x/STATUS

2014-04-04 Thread Marion Christophe JAILLET
Le 04/04/2014 13:59, Yann Ylavic a écrit : On Fri, Apr 4, 2014 at 1:35 PM, Eric Covener cove...@gmail.com wrote: FYI not necessary to propose docs-only changes in STATUS, they are CTR. Oh, I see, thanks for the information. Should I (or one) backport it if no one else screams for a while

Re: AW: APR_FOPEN_BUFFERED and small files

2014-02-14 Thread Marion Christophe JAILLET
lol, sure Le 14/02/2014 21:44, Plüm, Rüdiger, Vodafone Group a écrit : -Ursprüngliche Nachricht- Von: Christophe JAILLET Gesendet: Freitag, 14. Februar 2014 21:39 An: dev@httpd.apache.org Betreff: APR_FOPEN_BUFFERED and small files Hi, when a file is opened using apr_file_open

Re: [VOTE] obscuring (or not) commit logs/CHANGES for fixes to vulnerabilities

2014-01-10 Thread Marion Christophe JAILLET
Le 10/01/2014 14:38, Jeff Trawick a écrit : [ ] It is an accepted practice (but not required) to obscure or omit the vulnerability impact in CHANGES or commit log information when committing fixes for vulnerabilities to any branch. [X] It is mandatory to provide best available description

Re: svn commit: r1556914 - /httpd/httpd/trunk/modules/dav/lock/locks.c

2014-01-09 Thread Marion Christophe JAILLET
Sure, but I personally prefer to keep only one exit point in functions. Just a matter of taste. CJ Le 09/01/2014 20:17, Rainer Jung a écrit : On 09.01.2014 19:48, jaillet...@apache.org wrote: Author: jailletc36 Date: Thu Jan 9 18:48:11 2014 New Revision: 1556914 URL:

Re: Some redundant code and comment typos in mod_remoteip

2013-12-13 Thread Marion Christophe JAILLET
Not correct, this is just a french man who didn't take time to check in a dictionary... :) I update... Thx CJ Le 13/12/2013 19:57, Mike Rumph a écrit : equivalant versus equivalent Perhaps this is a difference in British versus American spelling, correct? Anyway, thanks for the

Re: svn commit: r1490290 - /httpd/httpd/trunk/modules/lua/lua_passwd.c

2013-06-06 Thread Marion Christophe JAILLET
Correct. This was introduced in r1465115. Fixed in trunk in r1490507. Le 06/06/2013 17:54, Guenter Knauf a écrit : ua/lua_passwd.c T

Re: svn commit: r1476694 - in /httpd/httpd/branches/2.4.x: CHANGES STATUS docs/manual/mod/mod_authnz_ldap.xml include/ap_mmn.h include/httpd.h modules/aaa/mod_authnz_ldap.c server/util.c

2013-04-27 Thread Marion Christophe JAILLET
Le 28/04/2013 01:14, minf...@apache.org a écrit : Author: minfrin Date: Sat Apr 27 23:14:11 2013 New Revision: 1476694 URL: http://svn.apache.org/r1476694 Log: mod_authnz_ldap: Allow using exec: callouts like SSLPassphraseDialog for AuthLDAPBindPassword. trunk patch:

Re: svn commit: r1463045 - /httpd/httpd/trunk/modules/aaa/mod_auth_digest.c

2013-03-31 Thread Marion Christophe JAILLET
Hi, they are 3 similar constructions in server/log.c CJ Le 31/03/2013 22:13, s...@apache.org a écrit : Author: sf Date: Sun Mar 31 20:13:48 2013 New Revision: 1463045 URL: http://svn.apache.org/r1463045 Log: ap_log_error already logs the error string, no need to log it twice Modified:

Re: svn commit: r1463049 - /httpd/httpd/trunk/modules/aaa/mod_auth_digest.c

2013-03-31 Thread Marion Christophe JAILLET
Hi, doc also has to be clean the same way. CJ Le 31/03/2013 22:38, s...@apache.org a écrit : Author: sf Date: Sun Mar 31 20:38:17 2013 New Revision: 1463049 URL: http://svn.apache.org/r1463049 Log: Remove partial non-working implementation of MD5-sess and qop=auth-int. If anyone wants to

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-22 Thread Marion Christophe JAILLET
Yes, i work and test on trunk. I'll give it a try. Thx CJ Le 22/03/2013 22:14, Stefan Fritsch a écrit : On Tuesday 19 March 2013, Marion Christophe JAILLET wrote: Le 18/03/2013 22:43, Stefan Fritsch a écrit : On Thursday 14 March 2013, you wrote: BTW, I tried to activate pool debug

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-19 Thread Marion Christophe JAILLET
Le 18/03/2013 22:43, Stefan Fritsch a écrit : On Thursday 14 March 2013, you wrote: BTW, I tried to activate pool debug with using |-enable-pool-debug=all but the server crashes while starting on my test machine. Do you know if it is supposed to work (and I do something wrong) or no one uses

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-13 Thread Marion Christophe JAILLET
My goal was to check for useless memory allocation when calling logging function. Logging with TRACE is unlikely to output something on a production machine. However, function called as parameters of the logging function will still be called. I made a check on the whole source code to check

Re: svn commit: r1455225 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/ docs/manual/howto/ docs/manual/mod/ include/ modules/filters/ modules/generators/ modules/slotmem/ os/unix/ server/ support/

2013-03-11 Thread Marion Christophe JAILLET
Le 11/03/2013 20:32, Gregg Smith a écrit : On 3/11/2013 9:38 AM, j...@apache.org wrote: Author: jim Date: Mon Mar 11 16:38:39 2013 New Revision: 1455225 URL: http://svn.apache.org/r1455225 Log: Merge r1442865, r1442759, r1442326, r1442309, r1448171, r1418556, r1448453, r1425771, r1425772,

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-03 Thread Marion Christophe JAILLET
Le 01/03/2013 11:43, Guenter Knauf a écrit : Hi Christophe, Am 01.03.2013 08:00, schrieb Christophe JAILLET: To quick... you can fix the svn log with: svn propedit -r 1451478 --revprop svn:log Gün. Thanks, done. CJ

Question about memory allocation in 'substring_conf' (server/util.c)

2013-02-05 Thread Marion Christophe JAILLET
Hi, This may look useless, but I can't figure out why in function 'substring_conf' (line 752 in server/util.c) we allocate len+2 bytes ? This seems to have been like that forever. IMO, len+1 should be enough. Changing that would be a huge memory usage improvement :). Does any one has an

Re: svn commit: r1422549 - in /httpd/httpd/trunk: include/ap_mmn.h include/httpd.h server/util.c server/util_md5.c

2012-12-17 Thread Marion Christophe JAILLET
Le 17/12/2012 00:20, Stefan Fritsch a écrit : +AP_DECLARE(void) ap_bin2hex(const void *src, apr_size_t srclen, char *dest) +{ +const unsigned char *in = src; +unsigned char *out = (unsigned char *)dest; +apr_size_t i; + +for (i = 0; i srclen; i++) { +*out++ =

Re: svn commit: r1420377 - in /httpd/httpd/trunk: docs/manual/mod/mod_lua.xml modules/lua/lua_apr.c modules/lua/lua_apr.h modules/lua/mod_lua.c

2012-12-12 Thread Marion Christophe JAILLET
Here are a few things triggered by cppcheck. Le 11/12/2012 21:08, humbed...@apache.org a écrit : Author: humbedooh Date: Tue Dec 11 20:08:24 2012 New Revision: 1420377 URL: http://svn.apache.org/viewvc?rev=1420377view=rev Log: mod_lua: Add a lot of core httpd/apr functionality to mod_lua

Re: svn commit: r1419755 - /httpd/httpd/trunk/modules/http/http_filters.c

2012-12-10 Thread Marion Christophe JAILLET
Le 10/12/2012 21:53, jaillet...@apache.org a écrit : Author: jailletc36 Date: Mon Dec 10 20:53:24 2012 New Revision: 1419755 URL: http://svn.apache.org/viewvc?rev=1419755view=rev Log: Avoid unnecessary %s substitution Modified: httpd/httpd/trunk/modules/http/http_filters.c Modified:

Re: svn commit: r1417892 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/ docs/manual/mod/ include/ modules/proxy/

2012-12-06 Thread Marion Christophe JAILLET
Le 06/12/2012 14:59, j...@apache.org a écrit : Author: jim Date: Thu Dec 6 13:59:32 2012 New Revision: 1417892 URL: http://svn.apache.org/viewvc?rev=1417892view=rev Log: Merge r1404653 from trunk: Allow for setting of sticky session split char... Bugz 53893 [...] ---