gstein (and others), here is another micro-patch for the original
mod_dav.c 1.94 change we made a couple of weeks ago. David Waite
noticed a segfault and made this patch. Please apply ASAP!
The old code never hit this problem, because it would always send NULL
as the last argument to
Applied. Thanks!
On Thu, Jun 19, 2003 at 03:17:17PM -0500, Ben Collins-Sussman wrote:
gstein (and others), here is another micro-patch for the original
mod_dav.c 1.94 change we made a couple of weeks ago. David Waite
noticed a segfault and made this patch. Please apply ASAP!
The old
Applied. Thanks!
On Wed, Jun 18, 2003 at 02:52:48PM -0500, Ben Collins-Sussman wrote:
[Reposting patch, with gstein's added check for r-sent_bodyct.]
Have mod_dav deal with errors that happen during a streamy provider response.
* mod_dav.c (dav_method_propfind, dav_method_report): if the
OK, so now all the mod_dav 'streamy propfind' patches are in. My two
original concerns are addressed: no more segfault, no more unlogged
errors. I think jerenkrantz should be happy. gstein and striker as
well.
That said, it'd be swell if we can get revisions 1.94, 1.95, 1.96 of
mod_dav.c
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Sent: Thursday, June 19, 2003 11:37 PM
OK, so now all the mod_dav 'streamy propfind' patches are in. My two
original concerns are addressed: no more segfault, no more unlogged
errors. I think jerenkrantz should be happy. gstein and
--On Tuesday, June 17, 2003 7:49 PM -0700 Greg Stein [EMAIL PROTECTED] wrote:
Hmm. It seems possible that deliver_report could fail before generating any
response. Thus, we want to test what the situation is, and deliver the error
or perform the new ah, crap. punt option.
The logic would be like
On Tue, Jun 17, 2003 at 11:33:48PM -0700, Justin Erenkrantz wrote:
--On Tuesday, June 17, 2003 7:49 PM -0700 Greg Stein [EMAIL PROTECTED]
wrote:
Hmm. It seems possible that deliver_report could fail before generating any
response. Thus, we want to test what the situation is, and deliver the
--On Tuesday, June 17, 2003 11:49 PM -0700 Greg Stein [EMAIL PROTECTED] wrote:
Definitely possible. But we have no better measure to detect that some
output has been generated. Once *some* output has been started (and, say, it
has been buffered by some filter), then the only likely error that
[Reposting patch, with gstein's added check for r-sent_bodyct.]
Have mod_dav deal with errors that happen during a streamy provider response.
* mod_dav.c (dav_method_propfind, dav_method_report): if the dav
provider throws an error in the middle of streaming a response, have
mod_dav log an
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Sent: Tuesday, June 17, 2003 8:27 PM
Have mod_dav deal with errors that happen during a streamy provider response.
(This is a followup to the change that makes dav_method_propfind streamy.)
Hopefully, this addresses jerenkrantz's concerns;
On Tue, Jun 17, 2003 at 01:27:19PM -0500, Ben Collins-Sussman wrote:
...
@@ -4033,9 +4043,19 @@
/* run report hook */
if ((err = (*vsn_hooks-deliver_report)(r, resource, doc,
r-output_filters)) != NULL) {
-/* NOTE: we're assuming
11 matches
Mail list logo
