Re: svn commit: r1638879 - /httpd/httpd/trunk/server/mpm/event/event.c

2014-11-16 Thread Yann Ylavic
Hi, Maybe it would make sense to clear the recycled pool in ap_push_pool(), that would simplify caller's life (currently we always do it before the call). How about the attached patch? Regards, Yann. On Sun, Nov 16, 2014 at 6:55 AM, Marion Christophe JAILLET christophe.jail...@wanadoo.fr

Re: svn commit: r1638879 - /httpd/httpd/trunk/server/mpm/event/event.c

2014-11-16 Thread Eric Covener
On Sun, Nov 16, 2014 at 7:27 AM, Yann Ylavic ylavic@gmail.com wrote: Hi, Maybe it would make sense to clear the recycled pool in ap_push_pool(), that would simplify caller's life (currently we always do it before the call). +1

Re: svn commit: r1638879 - /httpd/httpd/trunk/server/mpm/event/event.c

2014-11-16 Thread Yann Ylavic
On Sun, Nov 16, 2014 at 3:54 PM, Eric Covener cove...@gmail.com wrote: On Sun, Nov 16, 2014 at 7:27 AM, Yann Ylavic ylavic@gmail.com wrote: Maybe it would make sense to clear the recycled pool in ap_push_pool(), that would simplify caller's life (currently we always do it before the call).

Re: svn commit: r1638879 - /httpd/httpd/trunk/server/mpm/event/event.c

2014-11-15 Thread Marion Christophe JAILLET
Done in r1639960. CJ Le 15/11/2014 08:32, Marion Christophe JAILLET a écrit : Hi, the same pattern exists in eventopt. CJ Le 12/11/2014 18:32, cove...@apache.org a écrit : Author: covener Date: Wed Nov 12 17:32:24 2014 New Revision: 1638879 URL: http://svn.apache.org/r1638879 Log: avoid

Re: svn commit: r1638879 - /httpd/httpd/trunk/server/mpm/event/event.c

2014-11-14 Thread Marion Christophe JAILLET
Hi, the same pattern exists in eventopt. CJ Le 12/11/2014 18:32, cove...@apache.org a écrit : Author: covener Date: Wed Nov 12 17:32:24 2014 New Revision: 1638879 URL: http://svn.apache.org/r1638879 Log: avoid dereferencing a recently apr_pool_clear()'ed event_conn_state_t *cs in several