Re: [1.3 PATCH-ette] mod_log_forensic warning

2004-05-10 Thread Ben Laurie 
Jeff Trawick wrote:

pid_t is long on Solaris
+1





Index: src/modules/standard/mod_log_forensic.c
===
RCS file: /home/cvs/apache-1.3/src/modules/standard/mod_log_forensic.c,v
retrieving revision 1.7
diff -u -r1.7 mod_log_forensic.c
--- src/modules/standard/mod_log_forensic.c 21 Feb 2004 15:24:36 -  1.7
+++ src/modules/standard/mod_log_forensic.c 7 May 2004 12:07:08 -
@@ -189,7 +189,7 @@
 if (!(id = ap_table_get(r-subprocess_env, UNIQUE_ID))) {
 /* we make the assumption that we can't go through all the PIDs in
under 1 second */
-id = ap_psprintf(r-pool, %x:%lx:%x, getpid(), time(NULL), next_id++);
+id = ap_psprintf(r-pool, %lx:%lx:%x, (long)getpid(), time(NULL), 
next_id++);
 }
 rcfg.id = id;
 ap_set_module_config(r-request_config, log_forensic_module, rcfg);


--
http://www.apache-ssl.org/ben.html   http://www.thebunker.net/
There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit. - Robert Woodruff

[1.3 PATCH-ette] mod_log_forensic warning

2004-05-07 Thread Jeff Trawick 
pid_t is long on Solaris

Index: src/modules/standard/mod_log_forensic.c
===
RCS file: /home/cvs/apache-1.3/src/modules/standard/mod_log_forensic.c,v
retrieving revision 1.7
diff -u -r1.7 mod_log_forensic.c
--- src/modules/standard/mod_log_forensic.c 21 Feb 2004 15:24:36 -  1.7
+++ src/modules/standard/mod_log_forensic.c 7 May 2004 12:07:08 -
@@ -189,7 +189,7 @@
 if (!(id = ap_table_get(r-subprocess_env, UNIQUE_ID))) {
 /* we make the assumption that we can't go through all the PIDs in
under 1 second */
-id = ap_psprintf(r-pool, %x:%lx:%x, getpid(), time(NULL), next_id++);
+id = ap_psprintf(r-pool, %lx:%lx:%x, (long)getpid(), time(NULL), 
next_id++);
 }
 rcfg.id = id;
 ap_set_module_config(r-request_config, log_forensic_module, rcfg);