Re: [Bug?] cvs commit: httpd-2.0/server core.c

2004-01-14 Thread Brad Nicholes
>What about the case where they did have sendfile, but did not use large >file support? [Did/Do] we attempt to test the EnableSendfile logic? Yes, that happens in core.c/default_handler() when apr_file_open() is called. If the build has send_file support then the APR_SENDFILE_ENABLED flag is pas

Re: [Bug?] cvs commit: httpd-2.0/server core.c

2004-01-13 Thread William A. Rowe, Jr.
At 07:05 PM 1/13/2004, Brad Nicholes wrote: >I don't think so because the "split into multiple bucket" code was >only enabled if both large_file and send_file was enabled. Which meant >that on a non-large_file build the check for ENABLE_SENDFILE_OFF wasn't >there anyway. If they have large_fi

Re: [Bug?] cvs commit: httpd-2.0/server core.c

2004-01-13 Thread Brad Nicholes
I don't think so because the "split into multiple bucket" code was only enabled if both large_file and send_file was enabled. Which meant that on a non-large_file build the check for ENABLE_SENDFILE_OFF wasn't there anyway. If they have large_file support and don't have send_file (ie. NetWare

Re: [Bug?] cvs commit: httpd-2.0/server core.c

2004-01-13 Thread William A. Rowe, Jr.
Woha... At 11:50 AM 1/8/2004, [EMAIL PROTECTED] wrote: >bnicholes2004/01/08 09:50:03 > > Modified:server core.c > Log: > If large file support is enabled allow the file to be split into AP_MAX_SENDFILE > sized buckets. Otherwise Apache will be unable to send files larger than 2 gig