Re: [PATCH] Eliminate 13 in modules/aaa/mod_authn_dbd.c / modules/aaa/mod_authnz_ldap.c

2007-09-02 Thread William A. Rowe, Jr.
Graham Leggett wrote: Martin Kraemer wrote: Here's a patch to eliminate the 13, and to improve portability to EBCDIC machines by using apr_toupper(). Some of this fooness here revolves around charset issues, something I am not clear on for many platforms. The first question is, what is

Re: [PATCH] Eliminate 13 in modules/aaa/mod_authn_dbd.c / modules/aaa/mod_authnz_ldap.c

2007-09-01 Thread Graham Leggett
Martin Kraemer wrote: Here's a patch to eliminate the 13, and to improve portability to EBCDIC machines by using apr_toupper(). Some of this fooness here revolves around charset issues, something I am not clear on for many platforms. The first question is, what is the charset of the names

[PATCH] Eliminate 13 in modules/aaa/mod_authn_dbd.c / modules/aaa/mod_authnz_ldap.c

2007-08-31 Thread Martin Kraemer
From the 2.2.x STATUS doc: * mod_authn_dbd: Export any additional columns queried in the SQL select into the environment with the name AUTHENTICATE_COLUMN. This brings mod_authn_dbd behaviour in line with mod_authnz_ldap. Trunk:

Re: [PATCH] Eliminate 13 in modules/aaa/mod_authn_dbd.c / modules/aaa/mod_authnz_ldap.c

2007-08-31 Thread Graham Leggett
On Fri, August 31, 2007 12:41 pm, Martin Kraemer wrote: From the 2.2.x STATUS doc: * mod_authn_dbd: Export any additional columns queried in the SQL select into the environment with the name AUTHENTICATE_COLUMN. This brings mod_authn_dbd behaviour in line with mod_authnz_ldap.

Re: [PATCH] Eliminate 13 in modules/aaa/mod_authn_dbd.c / modules/aaa/mod_authnz_ldap.c

2007-08-31 Thread Martin Kraemer
On Fri, Aug 31, 2007 at 12:54:44PM +0200, Graham Leggett wrote: Here's a patch to eliminate the 13, and to improve portability to EBCDIC machines by using apr_toupper(). Thanks for this - the fooness really needed to be sorted out before it was rolled out over the other authn mechanisms.

Re: [PATCH] Eliminate 13 in modules/aaa/mod_authn_dbd.c / modules/aaa/mod_authnz_ldap.c

2007-08-31 Thread Martin Kraemer
On Fri, Aug 31, 2007 at 05:09:34PM +0200, Martin Kraemer wrote: Should I commit, or do you? Forgot to mention that I meant: commit to trunk. For 2.2.x, I'd prefer you do it. Martin -- [EMAIL PROTECTED]| Fujitsu Siemens http://www.fujitsu-siemens.com/imprint.html | 81730