Re: [PATCH] properly set the parent pid on shutdown

2006-05-27 Thread William A. Rowe, Jr.
Davi Arnaut wrote: On Fri, 26 May 2006 13:48:05 -0500 William A. Rowe, Jr. [EMAIL PROTECTED] wrote: +1 on visual review. Anyone have a win9x install handy to verify that this works? Sorry, none of my multiboots still boot 9x. I've personally tested it on WIN98 (virtual machine). Just a

[PATCH] properly set the parent pid on shutdown

2006-05-26 Thread Davi Arnaut
Hi, On WIN9X machines, before signaling the parent process in ap_signal_parent() we ought to set the proper parent pid retrieved by GetWindowThreadProcessId(). Otherwise, the event will be signaled without being properly opened because the parent pid will remain the same as the calling process

Re: [PATCH] properly set the parent pid on shutdown

2006-05-26 Thread William A. Rowe, Jr.
+1 on visual review. Anyone have a win9x install handy to verify that this works? Sorry, none of my multiboots still boot 9x. Davi Arnaut wrote: Hi, On WIN9X machines, before signaling the parent process in ap_signal_parent() we ought to set the proper parent pid retrieved by

Re: [PATCH] properly set the parent pid on shutdown

2006-05-26 Thread Davi Arnaut
On Fri, 26 May 2006 13:48:05 -0500 William A. Rowe, Jr. [EMAIL PROTECTED] wrote: +1 on visual review. Anyone have a win9x install handy to verify that this works? Sorry, none of my multiboots still boot 9x. I've personally tested it on WIN98 (virtual machine). Davi Arnaut wrote: Hi,