RE: mod_mem_cache bad for large/busy files (Was: [PATCH] remove some mutex locks in the worker MPM)

2003-01-02 Thread Bill Stoddard
in there the disk wasn't bottlenecking anymore... Dave - Original Message - From: Bill Stoddard [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, January 01, 2003 6:38 AM Subject: RE: [PATCH] remove some mutex locks in the worker MPM it may also have to do with caching we were doing

Re: mod_mem_cache bad for large/busy files (Was: [PATCH] remove some mutex locks in the worker MPM)

2003-01-02 Thread David Burry
the [PATCH] remove some mutex locks in the worker MPM thread)... so we kind of gave up on mod_mem_cache. This is kind of how this discussion branched off of that thread, sorry I didn't state that clearly earlier. It would be nice if there were some kind of shared cache, shared between processes

Re: [PATCH] remove some mutex locks in the worker MPM

2003-01-02 Thread Brian Pane
Aaron Bannert wrote: The patch looks good at first glance. Have you done any testing to see how much it improves performance (on UP and MP machines) and if it has any effect when APR is build with generic atomics? Here are the performance numbers that I have. I ran httpd-2.1.0-dev on an

Re: mod_mem_cache bad for large/busy files (Was: [PATCH] remove some mutex locks in the worker MPM)

2003-01-02 Thread David Burry
- Original Message - From: Brian Pane [EMAIL PROTECTED] Sent: Thursday, January 02, 2003 2:19 PM For large files, I'd anticipate that mod_cache wouldn't provide much benefit at all. If you characterize the cost of delivering a file as time_to_stat_and_open_and_close +

RE: [PATCH] remove some mutex locks in the worker MPM

2003-01-01 Thread Bill Stoddard
it may also have to do with caching we were doing (mod_mem_cache crashed and burned, What version were you running? What was the failure? If you can give me enough info to debug the problem, I'll work on it. Bill

mod_mem_cache bad for large/busy files (Was: [PATCH] remove some mutex locks in the worker MPM)

2003-01-01 Thread David Burry
Subject: RE: [PATCH] remove some mutex locks in the worker MPM it may also have to do with caching we were doing (mod_mem_cache crashed and burned, What version were you running? What was the failure? If you can give me enough info to debug the problem, I'll work on it. Bill

Re: [PATCH] remove some mutex locks in the worker MPM

2003-01-01 Thread Aaron Bannert
The patch looks good at first glance. Have you done any testing to see how much it improves performance (on UP and MP machines) and if it has any effect when APR is build with generic atomics? -aaron On Tuesday, December 31, 2002, at 05:30 PM, Brian Pane wrote: I'm working on replacing some

[PATCH] remove some mutex locks in the worker MPM

2002-12-31 Thread Brian Pane
I'm working on replacing some mutex locks with atomic-compare-and-swap based algorithms in the worker MPM, in order to get better concurrency and lower overhead. Here's the first change: take the pool recycling code out of the mutex-protected critical region in the queue_info code. Comments

Re: [PATCH] remove some mutex locks in the worker MPM

2002-12-31 Thread David Burry
- Original Message - From: David Burry [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Tuesday, December 31, 2002 5:54 PM Subject: Re: [PATCH] remove some mutex locks in the worker MPM Ohh this sounds like an awesome optimization... I noticed mutex contentions were extremely high on a very high traffic