Re: [Patch] Simplifying mod_alias

2015-01-22 Thread Graham Leggett
On 31 Dec 2014, at 5:56 PM, Eric Covener cove...@gmail.com wrote: For a URL of http://example.com/foo/bar/baz.html # this matches against baz.html only FilesMatch (.*\.html)$ Redirect http://other.example.com/$1 /FilesMatch You would not have any way to match or capture some part of

Re: [Patch] Simplifying mod_alias

2014-12-31 Thread Graham Leggett
On 22 Dec 2014, at 2:24 PM, Eric Covener cove...@gmail.com wrote: You'll still have 7 directives though. Some of them will be marked deprecated because they're less flexible. Sometimes less flexible is a sign of simplicity and not something to be relegated to a compat module. The *Match

Re: [Patch] Simplifying mod_alias

2014-12-31 Thread Eric Covener
On Wed, Dec 31, 2014 at 8:57 AM, Graham Leggett minf...@sharp.fm wrote: You'll also have two modules and two pages in the manual. The examples for Redirect will now have configuration sections with named back-references and won't work in htaccess. The FilesMatch container should support

Re: [Patch] Simplifying mod_alias

2014-12-31 Thread Eric Covener
On Wed, Dec 31, 2014 at 8:57 AM, Graham Leggett minf...@sharp.fm wrote: I still don't see any reason to call the existing *Match deprecated to add expression support. I see no link between the two. I would like to deprecate the *Match directives, but that has no bearing on expression

Re: [Patch] Simplifying mod_alias

2014-12-31 Thread Graham Leggett
On 31 Dec 2014, at 5:12 PM, Eric Covener cove...@gmail.com wrote: I don't think FilesMatch is enough functionally, because you're too limited in what you can check and match. Can you clarify in more detail? If this is so, I am keen to fix it. Regards, Graham —

Re: [Patch] Simplifying mod_alias

2014-12-31 Thread Eric Covener
On Wed, Dec 31, 2014 at 10:30 AM, Graham Leggett minf...@sharp.fm wrote: I don't think FilesMatch is enough functionally, because you're too limited in what you can check and match. Can you clarify in more detail? If this is so, I am keen to fix it. For a URL of

Re: [Patch] Simplifying mod_alias

2014-12-22 Thread Ruediger Pluem
On 12/21/2014 02:48 PM, Graham Leggett wrote: On 27 Jan 2014, at 12:11 AM, GRAHAM LEGGETT minf...@sharp.fm wrote: A look at mod_alias shows it has 7 directives: • Alias • AliasMatch • Redirect • RedirectMatch • RedirectPermanent • RedirectTemp • ScriptAlias • ScriptAliasMatch In

Re: [Patch] Simplifying mod_alias

2014-12-22 Thread Graham Leggett
On 21 Dec 2014, at 10:48 PM, Eric Covener cove...@gmail.com wrote: I don't see how adding expression or Location support as necessitating, or benefiting in a meaningful way, from the deprecation / movement of the other directives. I am assuming the *match directives could either a) provide

Re: [Patch] Simplifying mod_alias

2014-12-22 Thread Eric Covener
On Mon, Dec 22, 2014 at 5:15 AM, Graham Leggett minf...@sharp.fm wrote: The expression support is a superset of the regex support, making the regex support redundant. The *Match parameters are self contained, you cannot make a backreference outside the scope of that single directive. In

Re: [Patch] Simplifying mod_alias

2014-12-22 Thread Reindl Harald
Am 22.12.2014 um 11:15 schrieb Graham Leggett: On 21 Dec 2014, at 10:48 PM, Eric Covener cove...@gmail.com wrote: I don't see how adding expression or Location support as necessitating, or benefiting in a meaningful way, from the deprecation / movement of the other directives. I am assuming

Re: [Patch] Simplifying mod_alias

2014-12-22 Thread Graham Leggett
On 22 Dec 2014, at 14:53, Reindl Harald h.rei...@thelounge.net wrote: as user i will tell you something about the without any notable problems: if you use the new directives in the main configuration and somewhere below (vhost or even .htaccess) compat directives you get undefined behavior

Re: [Patch] Simplifying mod_alias

2014-12-22 Thread Reindl Harald
Am 22.12.2014 um 14:26 schrieb Graham Leggett: On 22 Dec 2014, at 14:53, Reindl Harald h.rei...@thelounge.net wrote: as user i will tell you something about the without any notable problems: if you use the new directives in the main configuration and somewhere below (vhost or even

[Patch] Simplifying mod_alias

2014-12-21 Thread Graham Leggett
On 27 Jan 2014, at 12:11 AM, GRAHAM LEGGETT minf...@sharp.fm wrote: A look at mod_alias shows it has 7 directives: • Alias • AliasMatch • Redirect • RedirectMatch • RedirectPermanent • RedirectTemp • ScriptAlias • ScriptAliasMatch In theory we only need these three: • Alias •

Re: [Patch] Simplifying mod_alias

2014-12-21 Thread André Malo
Hi, I think, most of the directives are compatibility ones. IMHO the best way to handle a transition to a different configuration concept would be to introduce a new module (mod_alias_ng or mod_fs_map or so...) instead of patching the current one and producing a lot of anger (Alias* and

Re: [Patch] Simplifying mod_alias

2014-12-21 Thread Graham Leggett
On 21 Dec 2014, at 4:18 PM, André Malo n...@perlig.de wrote: I think, most of the directives are compatibility ones. IMHO the best way to handle a transition to a different configuration concept would be to introduce a new module (mod_alias_ng or mod_fs_map or so...) instead of patching

Re: [Patch] Simplifying mod_alias

2014-12-21 Thread Helmut K. C. Tessarek
On 21.12.14 9:41 , Graham Leggett wrote: What we should do in future is remove all the *Match directives and move them into a mod_alias_compat module, leaving just Alias/Redirect/ScriptAlias in mod_alias, same as we did with authnz in httpd v2.4. +1. In SW development a lot of people mixup

Re: [Patch] Simplifying mod_alias

2014-12-21 Thread Tim Bannister
On 21 Dec 2014, at 13:48, Graham Leggett minf...@sharp.fm wrote: This patch implements the above. The idea is that the existing syntaxes remain unaltered (and can be deprecated in future), while we introduce new Location syntaxes with a single argument, like so: Location /image

Re: [Patch] Simplifying mod_alias

2014-12-21 Thread Eric Covener
On Sun, Dec 21, 2014 at 9:41 AM, Graham Leggett minf...@sharp.fm wrote: What we should do in future is remove all the *Match directives and move them into a mod_alias_compat module, leaving just Alias/Redirect/ScriptAlias in mod_alias, same as we did with authnz in httpd v2.4. I am -1 on

Re: [Patch] Simplifying mod_alias

2014-12-21 Thread Graham Leggett
On 21 Dec 2014, at 7:37 PM, Eric Covener cove...@gmail.com wrote: I am -1 on moving them to a _compat module. I don't see a technical reason, there's nothing wrong with the current code or function, and I think there has to be a stronger case to justify adding more upgrade speedbumps. The

Re: [Patch] Simplifying mod_alias

2014-12-21 Thread Eric Covener
On Sun, Dec 21, 2014 at 1:57 PM, Graham Leggett minf...@sharp.fm wrote: I am -1 on moving them to a _compat module. I don't see a technical reason, there's nothing wrong with the current code or function, and I think there has to be a stronger case to justify adding more upgrade speedbumps.