Re: Magic in request.c

2001-12-08 Thread Brian Pane
Ben Laurie wrote: This patch removes some magic in request.c. I wrote it coz 2.0.28 didn't actually work at all for me, coz the magic failed. +1; this patch is a lot less cryptic than the current logic Somehow the magic was OK again in the snapshot I tried, but I consider it a bad thing

Re: Magic in request.c

2001-12-08 Thread Bill Stoddard
(btw, the whole directory walk I find completely unreadable, I ought to do something about it). +1, readability is a good thing. Bill

Magic in request.c

2001-12-08 Thread Ben Laurie
This patch removes some magic in request.c. I wrote it coz 2.0.28 didn't actually work at all for me, coz the magic failed. Somehow the magic was OK again in the snapshot I tried, but I consider it a bad thing that it exists at all (btw, the whole directory walk I find completely unreadable, I

Re: Magic in request.c

2001-12-08 Thread William A. Rowe, Jr.
This patch removes some magic in request.c. I wrote it coz 2.0.28 didn't actually work at all for me, coz the magic failed. ++1. Clarity doesn't have to be inconsistent with optimization. In my defense, what existing before was even less legible - I sincerely tryed to improve it before