Missing include in simple_run.c

2009-01-02 Thread Rainer Jung 

When compiling trunk, I get

simple_run.c:242: warning: implicit declaration of function 
'ap_run_drop_privileges'


I can fix it with the following patch:

Index: server/mpm/simple/simple_run.c
===
--- server/mpm/simple/simple_run.c  (revision 730683)
+++ server/mpm/simple/simple_run.c  (working copy)
@@ -28,6 +28,7 @@

 #include ap_listen.h
 #include mpm.h
+#include mpm_common.h

 /**
  * Create Timers.

I'm not sure though, whether that's the best way, or you want to move 
the symbol to another include file instead.


Regards,

Rainer

Re: Missing include in simple_run.c

2009-01-02 Thread Ruediger Pluem 


On 01/02/2009 03:04 PM, Rainer Jung wrote:
 When compiling trunk, I get
 
 simple_run.c:242: warning: implicit declaration of function
 'ap_run_drop_privileges'
 
 I can fix it with the following patch:
 
 Index: server/mpm/simple/simple_run.c
 ===
 --- server/mpm/simple/simple_run.c  (revision 730683)
 +++ server/mpm/simple/simple_run.c  (working copy)
 @@ -28,6 +28,7 @@
 
  #include ap_listen.h
  #include mpm.h
 +#include mpm_common.h
 
  /**
   * Create Timers.
 
 I'm not sure though, whether that's the best way, or you want to move
 the symbol to another include file instead.

+1, go for it and patch it. The other MPM's include it as well and use
it from there.

Regards

Rüdiger