Negative mod_proxy ping_timeout..

2016-02-09 Thread Yann Ylavic
.. is meant to do a simple TCP readability check on the connection, using ap_proxy_is_socket_connected(). This is trunk only AFAICT. However all our proxy modules handle this just after calling ap_proxy_connect_backend() which already calls ap_proxy_is_socket_connected() for the same purpose.

Re: Negative mod_proxy ping_timeout..

2016-02-09 Thread Jim Jagielski
Why the change to modules/proxy/mod_proxy_hcheck.c? > On Feb 9, 2016, at 10:58 AM, Yann Ylavic wrote: > >

Re: Negative mod_proxy ping_timeout..

2016-02-09 Thread Yann Ylavic
On Tue, Feb 9, 2016 at 5:42 PM, Jim Jagielski wrote: > Why the change to modules/proxy/mod_proxy_hcheck.c? The call to ap_proxy_connect_backend() just above already calls ap_proxy_is_socket_connected() for any reused connection, so why check it twice? If the connection is not

Re: Negative mod_proxy ping_timeout..

2016-02-09 Thread Jim Jagielski
> On Feb 9, 2016, at 11:49 AM, Yann Ylavic wrote: > > On Tue, Feb 9, 2016 at 5:42 PM, Jim Jagielski wrote: >> Why the change to modules/proxy/mod_proxy_hcheck.c? > > The call to ap_proxy_connect_backend() just above already calls >