Re: Non-blocking read and input filters / ap_get_brigade callers

2013-10-19 Thread Yann Ylavic
On Sat, Oct 19, 2013 at 1:16 AM, Yann Ylavic wrote: > > If it breaks things, take a look at the second patch > "httpd-trunk-util_filter_wouldblock.patch" (attached) > +/* + * Was the previous call to : + * rv = ap_get_brigade(., bb, .., block, ..) + * a non-blocking read which would have blo

Non-blocking read and input filters / ap_get_brigade callers

2013-10-18 Thread Yann Ylavic
Helo, while looking at builtin modules' use of ap_get_brigade(), it seems to me that some don't behave correctly with non-blocking calls which would block. I must say that the core filter's behaviour to return APR_SUCCESS with an empty brigade, which may be turned to APR_EAGAIN if ap_http_filter(