Re: Problem w/ Revision 1864435

2019-09-19 Thread Rainer Jung 

Hi Bill,

Am 19.09.2019 um 19:39 schrieb William A Rowe Jr:

This commit somehow missed my inbox (and wasn't quoted in your observations)

http://svn.apache.org/viewvc?view=revision&revision=1864435

Rainer, you observed in the commit notes;

The GCC flag "-Wno-error=comment" introduced byr1855446  

andr1850745    
are only known since GCC 4.2. Since it gets
set unconditionally, this breaks compilation with old GCC
even when not using maintainer mode.

Make the fix for maintainer mode more specific by using
a version dependent pragma in the relevant two C files
only switching off error status for comment warnings.

Can we read this to say the comment error wasn't thrown by GCC 4.1 and 
earlier?


I don't know. The flag was introduced in r1850745 plus r1855446 and 
backported by r1856931. Jim's original commit log only mentions clang.


See PR63633 for more details about the problem caused by that change.


Can we please revert, and add an autoconf test for the support of (or lack
of errors against) this -Wno-error=comment flag? That should allow us to
apply it to all friendly compilers and avoid adding it to other elder 
compilers.


I remember I tried that first and I am not sure what where the exact 
problems I encountered, but I think we didn't have the configure/make 
infrastructure in place to dynamically add CFLAGS for specific modules, 
only LD flags.


Regards,

Rainer

On Thu, Sep 19, 2019 at 10:26 AM Jim Jagielski > wrote:


This breaks building on macOS:

Making all in filters
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static      -o libmod_data.la
 mod_data.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static      -o
libmod_ratelimit.la  mod_ratelimit.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static      -o
libmod_reqtimeout.la  mod_reqtimeout.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static      -o
libmod_ext_filter.la  mod_ext_filter.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static      -o libmod_request.la
 mod_request.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-security -Wunused -g -O0 -static      -o libmod_include.la
 mod_include.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
--mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include
-Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -std=c89 -Werror -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations
-Wdeclaration-after-statement -Wpointer-arith -Wformat
-Wformat-sec

Re: Problem w/ Revision 1864435

2019-09-19 Thread William A Rowe Jr 
This commit somehow missed my inbox (and wasn't quoted in your observations)

http://svn.apache.org/viewvc?view=revision&revision=1864435

Rainer, you observed in the commit notes;

The GCC flag "-Wno-error=comment" introduced by r1855446

and r1850745 
are only known since GCC 4.2. Since it gets
set unconditionally, this breaks compilation with old GCC
even when not using maintainer mode.

Make the fix for maintainer mode more specific by using
a version dependent pragma in the relevant two C files
only switching off error status for comment warnings.

Can we read this to say the comment error wasn't thrown by GCC 4.1 and
earlier?

Can we please revert, and add an autoconf test for the support of (or lack
of errors against) this -Wno-error=comment flag? That should allow us to
apply it to all friendly compilers and avoid adding it to other elder
compilers.




On Thu, Sep 19, 2019 at 10:26 AM Jim Jagielski  wrote:

> This breaks building on macOS:
>
> Making all in filters
> /Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
> --mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall
> -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89
> -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wmissing-declarations -Wdeclaration-after-statement -Wpointer-arith
> -Wformat -Wformat-security -Wunused -g -O0 -static  -o libmod_data.la
> mod_data.lo
> /Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
> --mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall
> -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89
> -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wmissing-declarations -Wdeclaration-after-statement -Wpointer-arith
> -Wformat -Wformat-security -Wunused -g -O0 -static  -o
> libmod_ratelimit.la mod_ratelimit.lo
> /Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
> --mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall
> -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89
> -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wmissing-declarations -Wdeclaration-after-statement -Wpointer-arith
> -Wformat -Wformat-security -Wunused -g -O0 -static  -o
> libmod_reqtimeout.la mod_reqtimeout.lo
> /Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
> --mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall
> -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89
> -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wmissing-declarations -Wdeclaration-after-statement -Wpointer-arith
> -Wformat -Wformat-security -Wunused -g -O0 -static  -o
> libmod_ext_filter.la mod_ext_filter.lo
> /Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
> --mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall
> -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89
> -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wmissing-declarations -Wdeclaration-after-statement -Wpointer-arith
> -Wformat -Wformat-security -Wunused -g -O0 -static  -o
> libmod_request.la mod_request.lo
> /Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
> --mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall
> -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89
> -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wmissing-declarations -Wdeclaration-after-statement -Wpointer-arith
> -Wformat -Wformat-security -Wunused -g -O0 -static  -o
> libmod_include.la mod_include.lo
> /Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
> --mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall
> -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89
> -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wmissing-declarations -Wdeclaration-after-statement -Wpointer-arith
> -Wformat -Wformat-security -Wunused -g -O0 -static  -o
> libmod_filter.la mod_filter.lo
> /Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
> --mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall
> -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89
> -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wmissing-declarations -Wdeclaration-after-statement -Wpointer-arith
> -Wformat -Wformat-security -Wunused -g -O0 -static  -o
> libmod_reflector.la mod_reflector.lo
> /Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent
> --mode=link gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall
> -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89
> -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wmissing-declarations -Wdeclaration-after-statement -

Problem w/ Revision 1864435

2019-09-19 Thread Jim Jagielski 
This breaks building on macOS:

Making all in filters
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent --mode=link 
gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall 
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89 
-Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations 
-Wdeclaration-after-statement -Wpointer-arith -Wformat -Wformat-security 
-Wunused -g -O0 -static  -o libmod_data.la mod_data.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent --mode=link 
gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall 
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89 
-Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations 
-Wdeclaration-after-statement -Wpointer-arith -Wformat -Wformat-security 
-Wunused -g -O0 -static  -o libmod_ratelimit.la mod_ratelimit.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent --mode=link 
gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall 
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89 
-Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations 
-Wdeclaration-after-statement -Wpointer-arith -Wformat -Wformat-security 
-Wunused -g -O0 -static  -o libmod_reqtimeout.la mod_reqtimeout.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent --mode=link 
gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall 
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89 
-Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations 
-Wdeclaration-after-statement -Wpointer-arith -Wformat -Wformat-security 
-Wunused -g -O0 -static  -o libmod_ext_filter.la mod_ext_filter.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent --mode=link 
gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall 
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89 
-Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations 
-Wdeclaration-after-statement -Wpointer-arith -Wformat -Wformat-security 
-Wunused -g -O0 -static  -o libmod_request.la mod_request.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent --mode=link 
gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall 
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89 
-Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations 
-Wdeclaration-after-statement -Wpointer-arith -Wformat -Wformat-security 
-Wunused -g -O0 -static  -o libmod_include.la mod_include.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent --mode=link 
gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall 
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89 
-Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations 
-Wdeclaration-after-statement -Wpointer-arith -Wformat -Wformat-security 
-Wunused -g -O0 -static  -o libmod_filter.la mod_filter.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent --mode=link 
gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall 
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89 
-Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations 
-Wdeclaration-after-statement -Wpointer-arith -Wformat -Wformat-security 
-Wunused -g -O0 -static  -o libmod_reflector.la mod_reflector.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent --mode=link 
gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall 
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89 
-Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations 
-Wdeclaration-after-statement -Wpointer-arith -Wformat -Wformat-security 
-Wunused -g -O0 -static  -o libmod_substitute.la mod_substitute.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent --mode=link 
gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall 
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89 
-Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations 
-Wdeclaration-after-statement -Wpointer-arith -Wformat -Wformat-security 
-Wunused -g -O0 -static  -o libmod_sed.la mod_sed.lo sed0.lo sed1.lo 
regexp.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent --mode=link 
gcc -I/usr/local/include/libxml2 -I/usr/local/include -Wall 
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -std=c89 
-Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations 
-Wdeclaration-after-statement -Wpointer-arith -Wformat -Wformat-security 
-Wunused -g -O0 -static  -o libmod_charset_lite.la mod_charset_lite.lo
/Users/jim/src/asf/code/dev/httpd-trunk/srclib/apr/libtool --silent --mode=link 
gcc -I/usr/local/include/libxml2 -I/usr/loc