Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Rainer Jung
Am 27.04.2020 um 15:57 schrieb Joe Orton: On Sat, Apr 25, 2020 at 08:10:40PM +0200, Rainer Jung wrote: Patch available at home.apache.org/~rjung/patches/httpd-trunk-mon-snaps-v1_2.patch Very nice! +1 from me. Does the times_per_thread logic still make any sense? It's always been wrong for

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Rainer Jung
Am 27.04.2020 um 17:28 schrieb Yann Ylavic: On Mon, Apr 27, 2020 at 5:18 PM Rainer Jung wrote: Hi Yann, Am 27.04.2020 um 16:40 schrieb Yann Ylavic: Hi Rainer, On Mon, Apr 27, 2020 at 3:17 PM Rainer Jung wrote: Thanks for this. Could you please create this as a PR on github as well? This

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Yann Ylavic
On Mon, Apr 27, 2020 at 5:18 PM Rainer Jung wrote: > > Hi Yann, > > Am 27.04.2020 um 16:40 schrieb Yann Ylavic: > > Hi Rainer, > > > > On Mon, Apr 27, 2020 at 3:17 PM Rainer Jung wrote: > >>> > >>> Thanks for this. > >>> Could you please create this as a PR on github as well? This ensures that

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Rainer Jung
Hi Yann, Am 27.04.2020 um 16:40 schrieb Yann Ylavic: Hi Rainer, On Mon, Apr 27, 2020 at 3:17 PM Rainer Jung wrote: Thanks for this. Could you please create this as a PR on github as well? This ensures that all the Travis tests are run for your patch. Thanks Rüdiger. Done and indeed

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Yann Ylavic
Hi Rainer, On Mon, Apr 27, 2020 at 3:17 PM Rainer Jung wrote: > > > > Thanks for this. > > Could you please create this as a PR on github as well? This ensures that > > all the Travis tests are run for your patch. > > Thanks Rüdiger. Done and indeed Travis found one not that I fixed but we >

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Joe Orton
On Sat, Apr 25, 2020 at 08:10:40PM +0200, Rainer Jung wrote: > Patch available at > > home.apache.org/~rjung/patches/httpd-trunk-mon-snaps-v1_2.patch Very nice! +1 from me. Does the times_per_thread logic still make any sense? It's always been wrong for Linux AFAICT so maybe can just be

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Rainer Jung
Am 27.04.2020 um 08:57 schrieb Ruediger Pluem: On 4/25/20 8:10 PM, Rainer Jung wrote: Patch available at home.apache.org/~rjung/patches/httpd-trunk-mon-snaps-v1_2.patch Thanks for this. Could you please create this as a PR on github as well? This ensures that all the Travis tests are run

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Ruediger Pluem
On 4/25/20 8:10 PM, Rainer Jung wrote: > Patch available at > > home.apache.org/~rjung/patches/httpd-trunk-mon-snaps-v1_2.patch Thanks for this. Could you please create this as a PR on github as well? This ensures that all the Travis tests are run for your patch. Regards Rüdiger

Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-25 Thread Rainer Jung
Patch available at home.apache.org/~rjung/patches/httpd-trunk-mon-snaps-v1_2.patch Some notes: - in order to use the data from mod_systemd (monitor hook), which runs in the maim process, and also from mod_status, so from child processes, it needs to sit in shared memory. Since most of the