Re: Question about mod_sed

2016-06-20 Thread Christophe JAILLET
Le 17/06/2016 à 14:35, Ruediger Pluem a écrit : On 06/17/2016 02:24 PM, Marion et Christophe JAILLET wrote: Hi, The code in trunk and 2.4 don't have the 3 last lines: memcpy(eval->gspend, sz, len + 1); /* hspend will now point to NULL character */ eval->gspend += len;

Re: Question about mod_sed

2016-06-17 Thread Rainer Jung
Am 17.06.2016 um 12:00 schrieb Ruediger Pluem: On 06/16/2016 10:33 PM, Christophe JAILLET wrote: Hi, I'm not familiar with sed implementation, but 'copy_to_genbuf' looks spurious. Actually it only expands a buffer if some space is needed, but nothing is copied. Should it look like:

Re: Question about mod_sed

2016-06-17 Thread Ruediger Pluem
> > Message du 17/06/16 12:00 > > De : "Ruediger Pluem" <rpl...@apache.org> > > A : dev@httpd.apache.org > > Copie à : > > Objet : Re: Question about mod_sed > > > > > > > > On 06

Re: Question about mod_sed

2016-06-17 Thread Marion et Christophe JAILLET
p#l231     The code in my first post is what I think is correct. Sorry for not being clear.   CJ > Message du 17/06/16 12:00 > De : "Ruediger Pluem" > A : dev@httpd.apache.org > Copie à : > Objet : Re: Question about mod_sed > > > > On 06/16/2016

Re: Question about mod_sed

2016-06-17 Thread Ruediger Pluem
On 06/16/2016 10:33 PM, Christophe JAILLET wrote: > Hi, > > > I'm not familiar with sed implementation, but 'copy_to_genbuf' looks spurious. > > Actually it only expands a buffer if some space is needed, but nothing is > copied. > > > Should it look like: > > static void

Question about mod_sed

2016-06-16 Thread Christophe JAILLET
Hi, I'm not familiar with sed implementation, but 'copy_to_genbuf' looks spurious. Actually it only expands a buffer if some space is needed, but nothing is copied. Should it look like: static void copy_to_genbuf(sed_eval_t *eval, const char* sz) { int len = strlen(sz); unsigned