Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
On 4/10/23 11:37 PM, BUSH Steve wrote: > I just downloaded the apache 2.4.57 source code and attempting to compile on > Windows, mod_rewrite.c fails with this error: > > > I fixed it for my local build by editing modules/mapper/mod_rewrite.mak and > updating the CPP_PROJ= lines to include the following > highlighted additions: > > CPP_PROJ=/nologo /MD /W3 /Zi /O2 /Oy- /I "../../include" /I "../../server" /I > "../database" /I "../ssl" /I > "../../srclib/apr/include" /I "../../srclib/apr-util/include" /D "NDEBUG" /D > "WIN32" /D "_WINDOWS" /Fo"$(INTDIR)\\" > /Fd"$(INTDIR)\mod_rewrite_src" /FD /c > > and > > CPP_PROJ=/nologo /MDd /W3 /Zi /Od /I "../../include" /I > "../../server" /I "../database" /I "../ssl" /I > "../../srclib/apr/include" /I "../../srclib/apr-util/include" /D "_DEBUG" /D > "WIN32" /D "_WINDOWS" /Fo"$(INTDIR)\\" > /Fd"$(INTDIR)\mod_rewrite_src" /FD /EHsc /c http://svn.apache.org/viewvc?view=revision=1908937 http://svn.apache.org/viewvc?view=revision=1909061 Thanks for the hint of the second location. Regards Rüdiger
RE: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
I just downloaded the apache 2.4.57 source code and attempting to compile on Windows, mod_rewrite.c fails with this error: mod_rewrite.c mod_rewrite.c(109): fatal error C1083: Cannot open include file: 'test_char.h': No such file or directory NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.28.29910\bin\HostX64\x64\cl.exe"' : return code '0x2' Stop. NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.28.29910\bin\HostX64\x64\nmake.exe"' : return code '0x2' Stop. NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.28.29910\bin\HostX64\x64\nmake.exe"' : return code '0x2' Stop. Looking at the comparison between mod_rewrite.c in 2.4.56 and 2.4.57, this line was added to 2.4.57: #include "mod_rewrite.h" #include "ap_expr.h" #include "test_char.h" Looking in the build tree, test_char.h is located in server/test_char.h, but the build settings are not picking it up. I build with nmake /f Makefile.win installr XML_PARSER="libexpat" I fixed it for my local build by editing modules/mapper/mod_rewrite.mak and updating the CPP_PROJ= lines to include the following highlighted additions: CPP_PROJ=/nologo /MD /W3 /Zi /O2 /Oy- /I "../../include" /I "../../server" /I "../database" /I "../ssl" /I "../../srclib/apr/include" /I "../../srclib/apr-util/include" /D "NDEBUG" /D "WIN32" /D "_WINDOWS" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_rewrite_src" /FD /c and CPP_PROJ=/nologo /MDd /W3 /Zi /Od /I "../../include" /I "../../server" /I "../database" /I "../ssl" /I "../../srclib/apr/include" /I "../../srclib/apr-util/include" /D "_DEBUG" /D "WIN32" /D "_WINDOWS" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_rewrite_src" /FD /EHsc /c Steve From: Eric Covener Sent: Wednesday, April 5, 2023 12:05 PM To: Apache HTTP Server Development List Subject: Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57 On Sun, Apr 2, 2023 at 12: 10 PM Eric Covener wrote: > > Hi all, > > Please find below the proposed release tarball and signatures: > > https: //urldefense. com/v3/__https: //dist. apache. org/repos/dist/dev/httpd/__;!!FbCVDoc3r24SyHFW!8DCCBctTbhX1spkJE4gZ9qtBOb5nXByw5xDUdZZ2airtNqNH4rVWHzx8MyOsxF2kx0RNY2MeA_S38Hk$[dist[. ]apache[. ]org] On Sun, Apr 2, 2023 at 12:10 PM Eric Covener mailto:cove...@gmail.com>> wrote: > > Hi all, > > Please find below the proposed release tarball and signatures: > > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/httpd/__;!!FbCVDoc3r24SyHFW!8DCCBctTbhX1spkJE4gZ9qtBOb5nXByw5xDUdZZ2airtNqNH4rVWHzx8MyOsxF2kx0RNY2MeA_S38Hk$<https://urldefense.com/v3/__https:/dist.apache.org/repos/dist/dev/httpd/__;!!FbCVDoc3r24SyHFW!8DCCBctTbhX1spkJE4gZ9qtBOb5nXByw5xDUdZZ2airtNqNH4rVWHzx8MyOsxF2kx0RNY2MeA_S38Hk$>[dist[.]apache[.]org] > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.57-rc1 as 2.4.57: > [ ] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. > > The computed digests of the tarball up for vote are: > sha256: bc3e7e540b83ec24f9b847c6b4d7148c55b79b27d102e21227eb65f7183d6b45 > *httpd-2.4.57-rc1.tar.gz > sha512: > 730560d4aab3699aa59716bb75858f8432a902aeab3c380b4d3e0f6813e9ae4e278d3b7fdf63a4e94c07b5100933d8684d76f6095f3d60d48ea0f1458c9ed0b4 > *httpd-2.4.57-rc1.tar.gz > > The SVN candidate source is found at tags/2.4.57-rc1-candidate. Vote passes with many binding +1 and no negative votes: +1: covener, rpluem, steffenal, gbechis, jorton, jailletc36, ylavic I will finalize some time over the next day or two. -- Eric Covener cove...@gmail.com<mailto:cove...@gmail.com> This email and any attachments are intended solely for the use of the individual or entity to whom it is addressed and may be confidential and/or privileged. If you are not one of the named recipients or have received this email in error, (i) you should not read, disclose, or copy it, (ii) please notify sender of your receipt by reply email and delete this email and all attachments, (iii) Dassault Systèmes does not accept or assume any liability or responsibility for any use of or reliance on this email. Please be informed that your personal data are processed according to our data privacy policy as described on our website. Should you have any questions related to personal data protection, please contact 3DS Data Protection Officer https://www.3ds.com/privacy-policy/contact/
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
On Sun, Apr 2, 2023 at 12:10 PM Eric Covener wrote: > > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.57-rc1 as 2.4.57: > [ ] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. > > The computed digests of the tarball up for vote are: > sha256: bc3e7e540b83ec24f9b847c6b4d7148c55b79b27d102e21227eb65f7183d6b45 > *httpd-2.4.57-rc1.tar.gz > sha512: > 730560d4aab3699aa59716bb75858f8432a902aeab3c380b4d3e0f6813e9ae4e278d3b7fdf63a4e94c07b5100933d8684d76f6095f3d60d48ea0f1458c9ed0b4 > *httpd-2.4.57-rc1.tar.gz > > The SVN candidate source is found at tags/2.4.57-rc1-candidate. Vote passes with many binding +1 and no negative votes: +1: covener, rpluem, steffenal, gbechis, jorton, jailletc36, ylavic I will finalize some time over the next day or two. -- Eric Covener cove...@gmail.com
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
Le 03/04/2023 à 21:44, Christophe JAILLET a écrit :
Le 02/04/2023 à 18:10, Eric Covener a écrit :
Hi all,
Please find below the proposed release tarball and signatures:
https://dist.apache.org/repos/dist/dev/httpd/
I would like to call a VOTE over the next few days to release
this candidate tarball httpd-2.4.57-rc1 as 2.4.57:
[X] +1: It's not just good, it's good enough!
[ ] +0: Let's have a talk.
[ ] -1: There's trouble in paradise. Here's what's wrong.
The computed digests of the tarball up for vote are:
sha256: bc3e7e540b83ec24f9b847c6b4d7148c55b79b27d102e21227eb65f7183d6b45
*httpd-2.4.57-rc1.tar.gz
sha512:
730560d4aab3699aa59716bb75858f8432a902aeab3c380b4d3e0f6813e9ae4e278d3b7fdf63a4e94c07b5100933d8684d76f6095f3d60d48ea0f1458c9ed0b4
*httpd-2.4.57-rc1.tar.gz
The SVN candidate source is found at tags/2.4.57-rc1-candidate.
+1
Tested only with event.
Tested with:
Linux pop-os 6.2.0
gcc (Ubuntu 12.1.0-2ubuntu1~22.04) 12.1.0
OpenSSL 3.0.2 15 Mar 2022 (Library: OpenSSL 3.0.2 15 Mar 2022)
libssl-dev 3.0.2
libbrotli-dev 1.0.9
libjansson-dev 2.13.1
libnghttp2-dev 1.43.0
libpcre2-dev 10.39
liblua5.3-dev 5.3.6
libsystemd-dev 249.11
libldap2-dev 2.5.14+dfsg
libxml2-dev 2.9.13+dfsg
libcurl4-openssl-dev 7.81.0
Still can't get the pytest run correctly.
I've tried to make some clean-ups. Should have a real look at it one day :(
> pip install -U multipart
did the trick. (thanks error.log!)
I don't know if it is a new requirement or if I did something wrong on
my setup.
Does is worth mentioning in README.pytest?
Another point, when building mod_tls.
After upgrading to latest github rustls-ffi, I now get:
tls_core.c: In function ‘extract_client_hello_values’:
tls_core.c:510:14: error: ‘rustls_client_hello’ has no member named
‘sni_name’
510 | if (hello->sni_name.len > 0) {
| ^~
tls_core.c:511:55: error: ‘rustls_client_hello’ has no member named
‘sni_name’
511 | cc->sni_hostname = apr_pstrndup(c->pool,
hello->sni_name.data, hello->sni_name.len);
| ^~
tls_core.c:511:77: error: ‘rustls_client_hello’ has no member named
‘sni_name’
511 | cc->sni_hostname = apr_pstrndup(c->pool,
hello->sni_name.data, hello->sni_name.len);
Apparently related to:
https://github.com/rustls/rustls-ffi/commit/ed82a03f2481095f251e7aee604a2ca29b8c1c5e#diff-6f7bcae64b59e4d5ad181e43c27a22088434c36827db05f8767e00dabcd7973eR426
So, maybe some trouble and conditional compilation to come in a close
future.
This module is tagged as experimental, so from my POV it can't be a show
stopper.
CJ
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
Good day, +1 no issues seen on Windows after include ../../server for mod_rewrite test_char.h Steffen > Op 2 apr. 2023 om 18:11 heeft Eric Covener het volgende > geschreven: > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.57-rc1 as 2.4.57: > [ ] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. > > The computed digests of the tarball up for vote are: > sha256: bc3e7e540b83ec24f9b847c6b4d7148c55b79b27d102e21227eb65f7183d6b45 > *httpd-2.4.57-rc1.tar.gz > sha512: > 730560d4aab3699aa59716bb75858f8432a902aeab3c380b4d3e0f6813e9ae4e278d3b7fdf63a4e94c07b5100933d8684d76f6095f3d60d48ea0f1458c9ed0b4 > *httpd-2.4.57-rc1.tar.gz > > The SVN candidate source is found at tags/2.4.57-rc1-candidate. > > -- > Eric Covener > cove...@gmail.com
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
Le 02/04/2023 à 18:10, Eric Covener a écrit : Hi all, Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball httpd-2.4.57-rc1 as 2.4.57: [X] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: sha256: bc3e7e540b83ec24f9b847c6b4d7148c55b79b27d102e21227eb65f7183d6b45 *httpd-2.4.57-rc1.tar.gz sha512: 730560d4aab3699aa59716bb75858f8432a902aeab3c380b4d3e0f6813e9ae4e278d3b7fdf63a4e94c07b5100933d8684d76f6095f3d60d48ea0f1458c9ed0b4 *httpd-2.4.57-rc1.tar.gz The SVN candidate source is found at tags/2.4.57-rc1-candidate. +1 Tested only with event. Tested with: Linux pop-os 6.2.0 gcc (Ubuntu 12.1.0-2ubuntu1~22.04) 12.1.0 OpenSSL 3.0.2 15 Mar 2022 (Library: OpenSSL 3.0.2 15 Mar 2022) libssl-dev 3.0.2 libbrotli-dev 1.0.9 libjansson-dev 2.13.1 libnghttp2-dev 1.43.0 libpcre2-dev 10.39 liblua5.3-dev 5.3.6 libsystemd-dev 249.11 libldap2-dev 2.5.14+dfsg libxml2-dev 2.9.13+dfsg libcurl4-openssl-dev 7.81.0 Still can't get the pytest run correctly. I've tried to make some clean-ups. Should have a real look at it one day :( CJ
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
On Sun, Apr 2, 2023 at 6:11 PM Eric Covener wrote: > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.57-rc1 as 2.4.57: [X] +1: It's not just good, it's good enough! All tests pass on Debian 11 and 12, sums and sigs OK. Thanks Eric, Yann.
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
On Sun, Apr 02, 2023 at 12:10:25PM -0400, Eric Covener wrote: > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.57-rc1 as 2.4.57: > [X] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. +1 for release, CHANGES looks good, sigs match, tests pass on RHEL 8+9. Thanks for RMing. Regards, Joe
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
On 4/3/23 12:19 PM, SteffenAL wrote: > vcxproj files since a few years . They where generated from the dsp files. But these are not part of the source, but your local ones? > > can I just include the test_char.h generated from gen_test_char.c /.exe ? Yes you can. Regards Rüdiger > > On Monday 03/04/2023 at 11:26, Ruediger Pluem wrote: >> How do you build it? Via cmake or via the mak files? >> >> Regards >> >> Rüdiger >> >> On 4/3/23 10:51 AM, SteffenAL wrote: >>> Build no go: >>> >>> >>> ErrorC1083Cannot open include file: 'test_char.h': No such file or >>> directorymod_rewriteC:\VS17\Win64\httpd-2.4\modules\mappers\mod_rewrite.c109 >>> >>> Is it ok that I include the test_char.h generated from gen_test_char.exe ? >>> >>> Steffen >>> >>> >>> On Sunday 02/04/2023 at 18:11, Eric Covener wrote: Hi all, Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball httpd-2.4.57-rc1 as 2.4.57: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: sha256: bc3e7e540b83ec24f9b847c6b4d7148c55b79b27d102e21227eb65f7183d6b45 *httpd-2.4.57-rc1.tar.gz sha512: 730560d4aab3699aa59716bb75858f8432a902aeab3c380b4d3e0f6813e9ae4e278d3b7fdf63a4e94c07b5100933d8684d76f6095f3d60d48ea0f1458c9ed0b4 *httpd-2.4.57-rc1.tar.gz The SVN candidate source is found at tags/2.4.57-rc1-candidate. -- Eric Covener cove...@gmail.com >>> >
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
How do you build it? Via cmake or via the mak files? Regards Rüdiger On 4/3/23 10:51 AM, SteffenAL wrote: > Build no go: > > > ErrorC1083Cannot open include file: 'test_char.h': No such file or > directorymod_rewriteC:\VS17\Win64\httpd-2.4\modules\mappers\mod_rewrite.c109 > > Is it ok that I include the test_char.h generated from gen_test_char.exe ? > > Steffen > > > On Sunday 02/04/2023 at 18:11, Eric Covener wrote: >> Hi all, >> >> Please find below the proposed release tarball and signatures: >> >> https://dist.apache.org/repos/dist/dev/httpd/ >> >> I would like to call a VOTE over the next few days to release >> this candidate tarball httpd-2.4.57-rc1 as 2.4.57: >> [ ] +1: It's not just good, it's good enough! >> [ ] +0: Let's have a talk. >> [ ] -1: There's trouble in paradise. Here's what's wrong. >> >> The computed digests of the tarball up for vote are: >> sha256: bc3e7e540b83ec24f9b847c6b4d7148c55b79b27d102e21227eb65f7183d6b45 >> *httpd-2.4.57-rc1.tar.gz >> sha512: >> 730560d4aab3699aa59716bb75858f8432a902aeab3c380b4d3e0f6813e9ae4e278d3b7fdf63a4e94c07b5100933d8684d76f6095f3d60d48ea0f1458c9ed0b4 >> *httpd-2.4.57-rc1.tar.gz >> >> The SVN candidate source is found at tags/2.4.57-rc1-candidate. >> >> -- >> Eric Covener >> cove...@gmail.com >
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
On 4/2/23 18:10, Eric Covener wrote: Hi all, Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball httpd-2.4.57-rc1 as 2.4.57: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: sha256: bc3e7e540b83ec24f9b847c6b4d7148c55b79b27d102e21227eb65f7183d6b45 *httpd-2.4.57-rc1.tar.gz sha512: 730560d4aab3699aa59716bb75858f8432a902aeab3c380b4d3e0f6813e9ae4e278d3b7fdf63a4e94c07b5100933d8684d76f6095f3d60d48ea0f1458c9ed0b4 *httpd-2.4.57-rc1.tar.gz The SVN candidate source is found at tags/2.4.57-rc1-candidate. +1 tested on Fedora 37 and OpenBSD 7.3 Thanks of RMing Giovanni OpenPGP_signature Description: OpenPGP digital signature
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
On 4/2/23 6:10 PM, Eric Covener wrote: > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.57-rc1 as 2.4.57: > [X] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. > > The computed digests of the tarball up for vote are: > sha256: bc3e7e540b83ec24f9b847c6b4d7148c55b79b27d102e21227eb65f7183d6b45 > *httpd-2.4.57-rc1.tar.gz > sha512: > 730560d4aab3699aa59716bb75858f8432a902aeab3c380b4d3e0f6813e9ae4e278d3b7fdf63a4e94c07b5100933d8684d76f6095f3d60d48ea0f1458c9ed0b4 > *httpd-2.4.57-rc1.tar.gz > > The SVN candidate source is found at tags/2.4.57-rc1-candidate. > +1 Tested on RedHat 8 x86_64 Regards Rüdiger
Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57
On Sun, Apr 2, 2023 at 12:10 PM Eric Covener wrote: > > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.57-rc1 as 2.4.57: > [x] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. my +1, ubuntu 22.04 and aix/xlc/ppc64
