Re: bug with Apache 1.3 NetWare build system
On Apr 23, 2007, at 1:20 PM, Brad Nicholes wrote: +1, go ahead and commit it. Brad +1
Re: bug with Apache 1.3 NetWare build system
On 4/19/2007 at 11:36 AM, in message [EMAIL PROTECTED], Guenter Knauf [EMAIL PROTECTED] wrote: Hi Brad, I've just found that we have same bug in the AP13 build system as what I fixed long time ago with the AP2x build system already; in each NWGNUmakefile.mak you can read: # # These flags will be added to the link.opt file # XLFLAGS += \ $(EOLIST) but in fact the XLFLAGS dont go into the link.opt file but instead into the link.def file. This does not work, and I'm unable to add additional libraries for linking the following patch fixes this: --- NWGNUtail.inc.origWed Jul 12 10:16:06 2006 +++ NWGNUtail.inc Thu Apr 19 19:25:24 2007 @@ -220,7 +220,7 @@ @echo -l $(REGEX)\$(OBJDIR) $@ @echo -l $(STDMOD)\$(OBJDIR) $@ @echo -l $(NWOS)\$(OBJDIR) $@ -#@echo -l $(METROWERKS)\Novell Support\Metrowerks Support\Libraries\Runtime $@ +#@echo -l $(METROWERKS)\Novell Support\Metrowerks Support\Libraries\Runtime $@ @echo -l $(NWSDKDIR)\imports $@ @echo -l $(LDAPSDK)\Netware\clib\imports $@ @echo -nodefaults $@ @@ -240,6 +240,9 @@ ifneq $(NLM_FLAGS) @echo -flags $(NLM_FLAGS) $@ endif +ifneq $(strip $(XLFLAGS)) + @echo $(strip $(XLFLAGS)) $@ +endif ifneq $(strip $(FILES_nlm_objs)) @echo $(foreach objfile,$(strip $(FILES_nlm_objs)),$(subst /,\,$(objfile))) $@ endif @@ -262,9 +265,6 @@ ifneq $(FILES_nlm_exports) @echo Export $(foreach export,$(subst $(SPACE),$(COMMA),$(strip $(FILES_nlm_exports))),$(subst /,\,$(export))) $(OBJDIR)\$(NLM_NAME)_link.def endif -ifneq $(strip $(XLFLAGS)) - @echo $(strip $(XLFLAGS)) $(OBJDIR)\$(NLM_NAME)_link.def -endif #ifndef XDCFOUND #@echo XDCData $(NWOS)\apache.xdc $(OBJDIR)\$(NLM_NAME)_link.def #endif can we get this into the Apache 1.3 source tree? thanks, Guenter. +1, go ahead and commit it. Brad
bug with Apache 1.3 NetWare build system
Hi Brad, I've just found that we have same bug in the AP13 build system as what I fixed long time ago with the AP2x build system already; in each NWGNUmakefile.mak you can read: # # These flags will be added to the link.opt file # XLFLAGS += \ $(EOLIST) but in fact the XLFLAGS dont go into the link.opt file but instead into the link.def file. This does not work, and I'm unable to add additional libraries for linking the following patch fixes this: --- NWGNUtail.inc.orig Wed Jul 12 10:16:06 2006 +++ NWGNUtail.inc Thu Apr 19 19:25:24 2007 @@ -220,7 +220,7 @@ @echo -l $(REGEX)\$(OBJDIR) $@ @echo -l $(STDMOD)\$(OBJDIR) $@ @echo -l $(NWOS)\$(OBJDIR) $@ -# @echo -l $(METROWERKS)\Novell Support\Metrowerks Support\Libraries\Runtime $@ +# @echo -l $(METROWERKS)\Novell Support\Metrowerks Support\Libraries\Runtime $@ @echo -l $(NWSDKDIR)\imports $@ @echo -l $(LDAPSDK)\Netware\clib\imports $@ @echo -nodefaults $@ @@ -240,6 +240,9 @@ ifneq $(NLM_FLAGS) @echo -flags $(NLM_FLAGS) $@ endif +ifneq $(strip $(XLFLAGS)) + @echo $(strip $(XLFLAGS)) $@ +endif ifneq $(strip $(FILES_nlm_objs)) @echo $(foreach objfile,$(strip $(FILES_nlm_objs)),$(subst /,\,$(objfile))) $@ endif @@ -262,9 +265,6 @@ ifneq $(FILES_nlm_exports) @echo Export $(foreach export,$(subst $(SPACE),$(COMMA),$(strip $(FILES_nlm_exports))),$(subst /,\,$(export))) $(OBJDIR)\$(NLM_NAME)_link.def endif -ifneq $(strip $(XLFLAGS)) - @echo $(strip $(XLFLAGS)) $(OBJDIR)\$(NLM_NAME)_link.def -endif #ifndef XDCFOUND # @echo XDCData $(NWOS)\apache.xdc $(OBJDIR)\$(NLM_NAME)_link.def #endif can we get this into the Apache 1.3 source tree? thanks, Guenter.
[PATCH] bug with Apache 1.3 NetWare build system
Hi Brad, I've examined a bit further, and found more issues with the XLFLAGS; it was mis-used for the xdcdata option; so now I have a more complete patch which fixes: - issue with XLFLAGS which was used wrong previously - issue with handling of the xdcdata option - issue with copyright string (seems -copy option is broken and doesnt allow commas in string) complete patch attached and also here: http://www.gknw.net/test/httpd_patches/ap13build.diff if you agree I would also like to fix some more minor build issues, f.e. introduce version number detection, use vpath where possible etc. thanks, Guenter. ap13build.diff Description: Binary data
