Re: cvs commit: httpd-2.0/modules/aaa mod_authnz_ldap.c

2004-10-05 Thread Jess Holle
Paul Querna wrote: Graham Leggett wrote: This block of code definitely belongs in apr-util, you are 100% right - but moving it to apr-util is a completely separate issue to fixing the bug as committed. Then this 'bug' should be submitted as a bug in APR-Util, not httpd. Not rea

Re: cvs commit: httpd-2.0/modules/aaa mod_authnz_ldap.c

2004-10-05 Thread Graham Leggett
Paul Querna wrote: This block of code definitely belongs in apr-util, you are 100% right - but moving it to apr-util is a completely separate issue to fixing the bug as committed. Then this 'bug' should be submitted as a bug in APR-Util, not httpd. Definitely not - like I said, the issue of the

Re: cvs commit: httpd-2.0/modules/aaa mod_authnz_ldap.c

2004-10-05 Thread Paul Querna
Graham Leggett wrote: This block of code definitely belongs in apr-util, you are 100% right - but moving it to apr-util is a completely separate issue to fixing the bug as committed. Then this 'bug' should be submitted as a bug in APR-Util, not httpd. So far this code will only be moved in httpd

Re: cvs commit: httpd-2.0/modules/aaa mod_authnz_ldap.c

2004-10-05 Thread Graham Leggett
Paul Querna wrote: mod_auth_ldap: Handle the inconsistent way in which the MS LDAP library handles special characters. It seems like this is something that belongs in APR-Util. Wouldn't any application that needed to escape characters in an LDAP filter end up copying this code? This block o

Re: cvs commit: httpd-2.0/modules/aaa mod_authnz_ldap.c

2004-10-05 Thread Jess Holle
Well and good, just don't lose the fix from 2.1 or 2.0 in the process. Otherwise, I don't care where the fix goes. -- Jess Holle Paul Querna wrote: [EMAIL PROTECTED] wrote: minfrin 2004/10/04 16:43:20 Modified:.CHANGES modules/aaa mod_authnz_ldap.c Log: mod_a

Re: cvs commit: httpd-2.0/modules/aaa mod_authnz_ldap.c

2004-10-05 Thread Paul Querna
[EMAIL PROTECTED] wrote: minfrin 2004/10/04 16:43:20 Modified:.CHANGES modules/aaa mod_authnz_ldap.c Log: mod_auth_ldap: Handle the inconsistent way in which the MS LDAP library handles special characters. It seems like this is something that belongs in APR-Ut