Re: http2 connection keepalive broken

2018-04-30 Thread Stefan Eissing
> Am 30.04.2018 um 12:15 schrieb Yann Ylavic : > > On Mon, Apr 30, 2018 at 12:06 PM, Stefan Eissing > wrote: >> >>> Am 30.04.2018 um 12:00 schrieb Yann Ylavic : >>> >>> There nothing wrong with returning CONN_STATE_WRITE_COMPLETION here >>> like before, CONN_STATE_HANDLER is wrong though. >>>

Re: http2 connection keepalive broken

2018-04-30 Thread Yann Ylavic
On Mon, Apr 30, 2018 at 12:06 PM, Stefan Eissing wrote: > >> Am 30.04.2018 um 12:00 schrieb Yann Ylavic : >> >> There nothing wrong with returning CONN_STATE_WRITE_COMPLETION here >> like before, CONN_STATE_HANDLER is wrong though. >> So the previous code with s/CONN_STATE_HANDLER/CONN_STATE_LINGE

Re: http2 connection keepalive broken

2018-04-30 Thread Stefan Eissing
> Am 30.04.2018 um 12:00 schrieb Yann Ylavic : > > On Mon, Apr 30, 2018 at 9:28 AM, Stefan Eissing > wrote: >> >> with the change http://svn.apache.org/r1819214 the keepalive handling >> in HTTP/2 was broken, as reported here >> >> https://github.com/icing/mod_h2/issues/160 > > Oh crap, I tho

Re: http2 connection keepalive broken

2018-04-30 Thread Yann Ylavic
On Mon, Apr 30, 2018 at 9:28 AM, Stefan Eissing wrote: > > with the change http://svn.apache.org/r1819214 the keepalive handling > in HTTP/2 was broken, as reported here > > https://github.com/icing/mod_h2/issues/160 Oh crap, I thougth that the h2 connection was over at this point (with its own k

http2 connection keepalive broken

2018-04-30 Thread Stefan Eissing
Yann, with the change http://svn.apache.org/r1819214 the keepalive handling in HTTP/2 was broken, as reported here https://github.com/icing/mod_h2/issues/160 If the mpm_event connection state handling is not suitable to honoring a keepalive setting, we need to fix this. Keeping idle connection