Re: httpd/trunk -Werror and warning free

2015-09-11 Thread Stefan Eissing
Tried the inline. clang is too smart for that one. Current attempt: #pragma GCC diagnostic ignored "-Wunused-const-variable" explicitly set for module declarations with warning. For including #pragma inside the #define. I did not find a portable way. Can with live with such a pragma in httpd?

Re: httpd/trunk -Werror and warning free

2015-09-05 Thread Jim Jagielski
Ideally, the patch would be broken up into separate ones; for example, the change for maintainer-mode should be sep from the fixes of warnings, etc. > On Sep 4, 2015, at 9:26 AM, Stefan Eissing > wrote: > >

httpd/trunk -Werror and warning free

2015-09-04 Thread Stefan Eissing
Below you find a patch that would make httpd/trunk - set -std=c89 on gcc in maintainer mode - abort compilation on every warning (-Werror) in maintainer-mode - fix all warnings that are currently there Please consider over the weekend. I would very much like to have that applied so all my C89

Re: httpd/trunk -Werror and warning free

2015-09-04 Thread Ruediger Pluem
AP_DECLARE_MODULE_LAST is no good alternative to AP_DECLARE_MODULE as it will break per module loglevels. We should not introduce this API. Why is this case op_Var: removed in util_expr_eval.c? Regards Rüdiger On 09/04/2015 03:26 PM, Stefan Eissing wrote: > Below you find a patch that would

Re: httpd/trunk -Werror and warning free

2015-09-04 Thread Yann Ylavic
On Fri, Sep 4, 2015 at 4:24 PM, Ruediger Pluem wrote: > AP_DECLARE_MODULE_LAST is no good alternative to AP_DECLARE_MODULE as it will > break per module loglevels. > We should not introduce this API. How about: Index: include/http_log.h

AW: httpd/trunk -Werror and warning free

2015-09-04 Thread Plüm , Rüdiger , Vodafone Group
Doesn't that create another warning about aplog_module_index_fake_use being unused? Regards Rüdiger > -Ursprüngliche Nachricht- > Von: Yann Ylavic [mailto:ylavic@gmail.com] > Gesendet: Freitag, 4. September 2015 18:13 > An: dev@httpd.apache.org > Betreff: Re: http

Re: httpd/trunk -Werror and warning free

2015-09-04 Thread Yann Ylavic
On Fri, Sep 4, 2015 at 7:37 PM, Plüm, Rüdiger, Vodafone Group wrote: > Doesn't that create another warning about aplog_module_index_fake_use being > unused? It may not if the compiler knows about "inline"...