Re: mod_cache: save filter recalls body to non-empty brigade?

2007-01-25 Thread Niklas Edmundsson
On Wed, 24 Jan 2007, Plüm, Rüdiger, VF EITO wrote: Of course practically you don't want to make assumptions about the emptiness of the existing brigade, so clearing the brigade as a first step makes definite sense. It is not needed to clear the brigade, because the brigade passed to the filte

Re: mod_cache: save filter recalls body to non-empty brigade?

2007-01-24 Thread Plüm , Rüdiger , VF EITO
> -Ursprüngliche Nachricht- > Von: Graham Leggett > Gesendet: Mittwoch, 24. Januar 2007 16:15 > An: dev@httpd.apache.org > Cc: dev@httpd.apache.org > Betreff: Re: mod_cache: save filter recalls body to non-empty brigade? > > > On Wed, January 24, 2007 2:15

Re: mod_cache: save filter recalls body to non-empty brigade?

2007-01-24 Thread Giuliano Gavazzi
On 24 Jan 2007, at 14:39, Giuliano Gavazzi wrote: this could be the underlying cause to a bug I reported against mod_cache+mod_include in 2.2.4 and then reported to this list: I spoke too early, I was wrong. Regarding your observation, I see that in cache_save_filter recall_body is called w

Re: mod_cache: save filter recalls body to non-empty brigade?

2007-01-24 Thread Niklas Edmundsson
On Wed, 24 Jan 2007, Graham Leggett wrote: On Wed, January 24, 2007 2:15 pm, Niklas Edmundsson wrote: In mod_cache, recall_body() is called in the cache_save_filter() when revalidating an entity. However, if I have understood things correctly the brigade is already populated when the save fil

Re: mod_cache: save filter recalls body to non-empty brigade?

2007-01-24 Thread Graham Leggett
On Wed, January 24, 2007 2:15 pm, Niklas Edmundsson wrote: > In mod_cache, recall_body() is called in the cache_save_filter() when > revalidating an entity. > > However, if I have understood things correctly the brigade is already > populated when the save filter is called, so calling recall_body(

Re: mod_cache: save filter recalls body to non-empty brigade?

2007-01-24 Thread Giuliano Gavazzi
On 24 Jan 2007, at 13:15, Niklas Edmundsson wrote: In mod_cache, recall_body() is called in the cache_save_filter() when revalidating an entity. However, if I have understood things correctly the brigade is already populated when the save filter is called, so calling recall_body() in t

mod_cache: save filter recalls body to non-empty brigade?

2007-01-24 Thread Niklas Edmundsson
In mod_cache, recall_body() is called in the cache_save_filter() when revalidating an entity. However, if I have understood things correctly the brigade is already populated when the save filter is called, so calling recall_body() in this case would place additional stuff in the bucket briga