Re: namespacing in mod_ssl

2015-04-20 Thread William A Rowe Jr
On Apr 20, 2015 2:32 AM, "Joe Orton" wrote: > > On Thu, Apr 16, 2015 at 06:42:04AM +0200, Kaspar Brand wrote: > > On 15.04.2015 18:36, Stefan Sperling wrote: > > > However, the actual issue here is that mod_ssl is squatting the SSL_ namespace. > > > Historically this may have made sense (it seems

Re: namespacing in mod_ssl

2015-04-20 Thread Joe Orton
On Thu, Apr 16, 2015 at 06:42:04AM +0200, Kaspar Brand wrote: > On 15.04.2015 18:36, Stefan Sperling wrote: > > However, the actual issue here is that mod_ssl is squatting the SSL_ > > namespace. > > Historically this may have made sense (it seems mod_ssl and OpenSSL have > > shared history/author

Re: namespacing in mod_ssl

2015-04-18 Thread Eric Covener
On Sat, Apr 18, 2015 at 9:18 AM, Stefan Sperling wrote: > So to take a first step forward, here's a diff that puts ssl_util_ssl.h > macros into the MODSSL_ namespace. +1

Re: namespacing in mod_ssl

2015-04-18 Thread Stefan Sperling
On Wed, Apr 15, 2015 at 06:36:13PM +0200, Stefan Sperling wrote: > However, the actual issue here is that mod_ssl is squatting the SSL_ > namespace. > Historically this may have made sense (it seems mod_ssl and OpenSSL have > shared history/authors). Bill Rowe suggested to try moving mod_ssl's > f

Re: namespacing in mod_ssl

2015-04-16 Thread William A Rowe Jr
On Wed, Apr 15, 2015 at 11:42 PM, Kaspar Brand wrote: > On 15.04.2015 18:36, Stefan Sperling wrote: > > However, the actual issue here is that mod_ssl is squatting the SSL_ > namespace. > > Historically this may have made sense (it seems mod_ssl and OpenSSL have > > shared history/authors). Bill

Re: namespacing in mod_ssl

2015-04-15 Thread Kaspar Brand
On 15.04.2015 18:36, Stefan Sperling wrote: > However, the actual issue here is that mod_ssl is squatting the SSL_ > namespace. > Historically this may have made sense (it seems mod_ssl and OpenSSL have > shared history/authors). Bill Rowe suggested to try moving mod_ssl's > functions into the ap_

Re: namespacing in mod_ssl

2015-04-15 Thread Jeff Trawick
On 04/15/2015 02:54 PM, Jeff Trawick wrote: On 04/15/2015 11:36 AM, Stefan Sperling wrote: A few months ago, OpenBSD's LibreSSL added a new function called SSL_CTX_use_certificate_chain(). This unexpectedly broke the build of Apache's mod_ssl which defines a function of the same name. In OpenBSD

Re: namespacing in mod_ssl

2015-04-15 Thread Victor J. Orlikowski
On Apr 15, 2015, at 3:54 PM, Jeff Trawick wrote: > > IMO it would be appropriate to instead go one by one and make sure we're > using an appropriate name to begin with for these functions that are > squatting the SSL namespace, instead of making these often-bewildering names > ugly and (still)

Re: namespacing in mod_ssl

2015-04-15 Thread Jeff Trawick
On 04/15/2015 11:36 AM, Stefan Sperling wrote: A few months ago, OpenBSD's LibreSSL added a new function called SSL_CTX_use_certificate_chain(). This unexpectedly broke the build of Apache's mod_ssl which defines a function of the same name. In OpenBSD this was worked around by patching mod_ssl,

namespacing in mod_ssl

2015-04-15 Thread Stefan Sperling
A few months ago, OpenBSD's LibreSSL added a new function called SSL_CTX_use_certificate_chain(). This unexpectedly broke the build of Apache's mod_ssl which defines a function of the same name. In OpenBSD this was worked around by patching mod_ssl, renaming the clashing function. Since then Libre