post_config on reload

2009-03-13 Thread Andrej van der Zee
Hi, I found this piece of code for dealing with the post_config issue (it is called twice, while I need to initialise my stuff only once): void *data; const char *userdata_key = post_config_only_once_key; apr_pool_userdata_get(data, userdata_key, s-process-pool); if (!data) {

Re: post_config on reload

2009-03-13 Thread Sorin Manolache
On Fri, Mar 13, 2009 at 16:21, Andrej van der Zee andrejvander...@gmail.com wrote: Hi, Do not do this -  a restart should be a restart, not a half of a restart.  You should be reinitializing whatever you do on a restart as well as a start.  That's the whole point. I have one phrase that

Re: post_config on reload

2009-03-13 Thread Andrej van der Zee
Hi, Do not do this - a restart should be a restart, not a half of a restart. You should be reinitializing whatever you do on a restart as well as a start. That's the whole point. I have one phrase that should illustrate why : memory leak. For example, if your extension creates another

Re: post_config on reload

2009-03-13 Thread Joe Lewis
Sorin Manolache wrote: On Fri, Mar 13, 2009 at 16:21, Andrej van der Zee andrejvander...@gmail.com wrote: Hi, Do not do this - a restart should be a restart, not a half of a restart. You should be reinitializing whatever you do on a restart as well as a start. That's the whole

Re: post_config on reload

2009-03-13 Thread Joe Lewis
Andrej van der Zee wrote: Hi, I was wondering if there is a solution for detecting a post_config invocation on behalf of apachctl restart instead of a clean start (in case of a restart, I do not want to initialise my stuff again). Do not do this - a restart should be a restart, not a half