Re: protocols and mod_h2 consolidation

2015-08-25 Thread Stefan Eissing
Ok, I see that warning flags vary on platforms. That's natural. However if our most common (I assume) dev platform does not enable the superset of all, then we get errors/warnings continuously as people will check in code that fails elsewhere. And I do not think that adding things like #ifndef

Re: protocols and mod_h2 consolidation

2015-08-25 Thread Stefan Eissing
Gregg, I just checked in changes that should fix the warnings you mentioned. Thanks for reviewing this. As to the SERVER_PROTOCOL, I have no idea yet what may cause this. //Stefan Am 25.08.2015 um 06:11 schrieb Gregg Smith g...@gknw.net: Hi, On 8/24/2015 9:29 AM, Stefan Eissing wrote:

Re: protocols and mod_h2 consolidation

2015-08-25 Thread Gregg Smith
Stefan, Changes worked great. Thanks. Gregg On 8/25/2015 3:43 AM, Stefan Eissing wrote: Gregg, I just checked in changes that should fix the warnings you mentioned. Thanks for reviewing this. As to the SERVER_PROTOCOL, I have no idea yet what may cause this. //Stefan Am 25.08.2015 um

Re: protocols and mod_h2 consolidation

2015-08-25 Thread William A Rowe Jr
On Aug 24, 2015 11:43 PM, Gregg Smith g...@gknw.net wrote: On 8/24/2015 9:29 AM, Stefan Eissing wrote: I hope this works for everyone. The next weeks might be a good time to think about it and propose any changes and correct my mistakes. There are two things that go bump on my lowest non-eol

Re: protocols and mod_h2 consolidation

2015-08-25 Thread Gregg Smith
On 8/25/2015 5:57 PM, William A Rowe Jr wrote: On Aug 24, 2015 11:43 PM, Gregg Smithg...@gknw.net wrote: On 8/24/2015 9:29 AM, Stefan Eissing wrote: I hope this works for everyone. The next weeks might be a good time to think about it and propose any changes and correct my mistakes. There

protocols and mod_h2 consolidation

2015-08-24 Thread Stefan Eissing
As you might have noticed, I am doing some cleanup work on mod_h2 and want to create THE PATCH for backporting soon. The new core directives Protocols and ProtocolsHonorOrder are implemented, such as on a server or virtual host one may write Protocols h2c http/1.1 # enable h2c and

Re: protocols and mod_h2 consolidation

2015-08-24 Thread Eric Covener
On Mon, Aug 24, 2015 at 12:29 PM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: I hope this works for everyone. The next weeks might be a good time to think about it and propose any changes and correct my mistakes. Look good in concept to me

Re: protocols and mod_h2 consolidation

2015-08-24 Thread Gregg Smith
Hi, On 8/24/2015 9:29 AM, Stefan Eissing wrote: I hope this works for everyone. The next weeks might be a good time to think about it and propose any changes and correct my mistakes. There are two things that go bump on my lowest non-eol version of MSVC. h2_worker.c .\h2_worker.c(113) :