Re: proxy_fcgi directives or envvars?
It would be nice to avoid the overhead of getting the ENV. > On Jan 8, 2017, at 11:31 AM, Eric Covener wrote: > > We have an issue in proxy_fcgi in 2.4.21 and later that makes me think > we need to tell proxy_fcgi when it's talking to php-fpm vs. a generic > fastcgi application, due to historical things in httpd and php-fpm. > Basically, we cleaned up some fcgi variables that php-fpm was > interpreting as not only Apache-originated but proxy_fcgi vs. > mod_fastcgi. > > I notice that even complex proxy submodules (proxy_http) have no > directives but use envvars for config. I actually like this approach > for obscure-ish things, but directives do have some benefits (error > checking, better doc) > > Anyone have strong feelings either way? > > -- > Eric Covener > cove...@gmail.com
Re: proxy_fcgi directives or envvars?
On Sun, 2017-01-08 at 11:31 -0500, Eric Covener wrote: I'm easy either way. > I notice that even complex proxy submodules (proxy_http) have no > directives but use envvars for config. I actually like this approach > for obscure-ish things, but directives do have some benefits (error > checking, better doc) I think (from distant memory) I may be responsible for some of that. At some point I wanted to introduce directives where there were none. But mod_proxy had, by convention, put all the directives in mod_proxy itself, including some that belonged on the same docs page as what I needed to add. I have an idea something may have been needed in both mod_proxy and mod_proxy_http. It certainly gave rise to issues with how to document it without a major reorg. Envvars offered a straightforward workaround. -- Nick Kew
proxy_fcgi directives or envvars?
We have an issue in proxy_fcgi in 2.4.21 and later that makes me think we need to tell proxy_fcgi when it's talking to php-fpm vs. a generic fastcgi application, due to historical things in httpd and php-fpm. Basically, we cleaned up some fcgi variables that php-fpm was interpreting as not only Apache-originated but proxy_fcgi vs. mod_fastcgi. I notice that even complex proxy submodules (proxy_http) have no directives but use envvars for config. I actually like this approach for obscure-ish things, but directives do have some benefits (error checking, better doc) Anyone have strong feelings either way? -- Eric Covener cove...@gmail.com
