Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-22 Thread Stefan Fritsch
On Tuesday 19 March 2013, Marion Christophe JAILLET wrote: Le 18/03/2013 22:43, Stefan Fritsch a écrit : On Thursday 14 March 2013, you wrote: BTW, I tried to activate pool debug with using |-enable-pool-debug=all but the server crashes while starting |on my test machine. Do

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-22 Thread Marion Christophe JAILLET
Yes, i work and test on trunk. I'll give it a try. Thx CJ Le 22/03/2013 22:14, Stefan Fritsch a écrit : On Tuesday 19 March 2013, Marion Christophe JAILLET wrote: Le 18/03/2013 22:43, Stefan Fritsch a écrit : On Thursday 14 March 2013, you wrote: BTW, I tried to activate pool debug with

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-22 Thread Christophe JAILLET
I still have the same issue with mpm worker but it works with prefork. It is enough for what I want to do. Thx CJ

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-19 Thread Marion Christophe JAILLET
Le 18/03/2013 22:43, Stefan Fritsch a écrit : On Thursday 14 March 2013, you wrote: BTW, I tried to activate pool debug with using |-enable-pool-debug=all but the server crashes while starting on my test machine. Do you know if it is supposed to work (and I do something wrong) or no one uses

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-18 Thread Stefan Fritsch
On Thursday 14 March 2013, you wrote: BTW, I tried to activate pool debug with using |-enable-pool-debug=all but the server crashes while starting on my test machine. Do you know if it is supposed to work (and I do something wrong) or no one uses it with httpd ? I am sure that I have used

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-13 Thread Stefan Fritsch
Note that there is some macro magic in http_log.h that does this automatically on C99 compilers. There is nothing wrong with doing the check explicitly, and it is definitely a good idea if the saved function call is very expensive. But in general other improvements may have more impact and

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-13 Thread Marion Christophe JAILLET
My goal was to check for useless memory allocation when calling logging function. Logging with TRACE is unlikely to output something on a production machine. However, function called as parameters of the logging function will still be called. I made a check on the whole source code to check

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-03 Thread Marion Christophe JAILLET
Le 01/03/2013 11:43, Guenter Knauf a écrit : Hi Christophe, Am 01.03.2013 08:00, schrieb Christophe JAILLET: To quick... you can fix the svn log with: svn propedit -r 1451478 --revprop svn:log Gün. Thanks, done. CJ

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-01 Thread Guenter Knauf
Hi Christophe, Am 01.03.2013 08:00, schrieb Christophe JAILLET: To quick... you can fix the svn log with: svn propedit -r 1451478 --revprop svn:log Gün.

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-02-28 Thread Christophe JAILLET
To quick... Le 01/03/2013 07:33, jaillet...@apache.org a écrit : Author: jailletc36 Date: Fri Mar 1 06:33:40 2013 New Revision: 1451478 URL: http://svn.apache.org/r1451478 Log: Avoid some memory allocation on error path in 'http2env' if TRACE1 logging is not activated Avoid a function ca