Re: svn commit: r1673904 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS docs/manual/mod/mod_logio.xml modules/loggers/mod_logio.c

2015-04-15 Thread Marion Christophe JAILLET 

Hi,

compatibility note is missing in the doc.

BTW, what is the reason of the LogIOTrackTTFB directive? No impact on 
performance if %^FB is not needed?


CJ

Le 15/04/2015 19:59, cove...@apache.org a écrit :

Author: covener
Date: Wed Apr 15 17:59:42 2015
New Revision: 1673904

URL: http://svn.apache.org/r1673904
Log:
Merge r1671918, r1673113 from trunk:

allow time to first byte (of response headers)
to be logged by mod_logio.

mod_logio was just a conveninent place to do this
w/o writing a new filter or complicating an existing
important one.



Use 'unsigned int' in bitfield

Modified:
 httpd/httpd/branches/2.4.x/   (props changed)
 httpd/httpd/branches/2.4.x/CHANGES
 httpd/httpd/branches/2.4.x/STATUS
 httpd/httpd/branches/2.4.x/docs/manual/mod/mod_logio.xml
 httpd/httpd/branches/2.4.x/modules/loggers/mod_logio.c

Modified: httpd/httpd/branches/2.4.x/docs/manual/mod/mod_logio.xml
URL: 
http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/docs/manual/mod/mod_logio.xml?rev=1673904r1=1673903r2=1673904view=diff
==
--- httpd/httpd/branches/2.4.x/docs/manual/mod/mod_logio.xml (original)
+++ httpd/httpd/branches/2.4.x/docs/manual/mod/mod_logio.xml Wed Apr 15 
17:59:42 2015
@@ -72,6 +72,12 @@
  tdBytes transferred (received and sent), including request and 
headers,
  cannot be zero. This is the combination of %I and %O.br /
  Available in Apache 2.4.7 and later/td/tr
+
+trtdcode%^FB/code/td
+tdDelay in microseconds between when the request arrived and the
+first byte of the response headers are written.  Only available if
+directiveLogIOTrackTTFB/directive is set to ON.
+/td/tr
  /table
  
  pUsually, the functionality is used like this:/p

@@ -83,4 +89,21 @@
  /dl
  /section
  
+directivesynopsis

+nameLogIOTrackTTFB/name
+descriptionEnable tracking of time to first byte (TTFB)/description
+syntaxLogIOTrackTTFB ON|OFF/syntax
+defaultLogIOTrackTTFB OFF/default
+contextlistcontextserver config/contextcontextvirtual host/context
+contextdirectory/contextcontext.htaccess/context/contextlist
+overridenone/override
+
+usage
+pThis directive configures whether this module tracks the delay
+between the request being read and the first byte of the response
+headers being written.  The resulting value may be logged with the
+code%^FB/code format./p
+/usage
+/directivesynopsis
+
  /modulesynopsis

Re: svn commit: r1673904 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS docs/manual/mod/mod_logio.xml modules/loggers/mod_logio.c

2015-04-15 Thread Eric Covener 
Thanks for the review

On Wed, Apr 15, 2015 at 1:21 PM, Marion  Christophe JAILLET
christophe.jail...@wanadoo.fr wrote:
 compatibility note is missing in the doc.

r1673924.

 BTW, what is the reason of the LogIOTrackTTFB directive? No impact on
 performance if %^FB is not needed?

Unfortunately it needs to call apr_time_now()  (gettimeofday()) before
it is called back by mod_log_config to be able to track the time.

I didn't want to add another apr_time_now() in the request path, but I
don't know how practical of a concern that might be.