Re: svn commit: r1694950 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_request.c

2015-08-10 Thread Gregg Smith 

On 8/10/2015 11:44 AM, William A Rowe Jr wrote:

On Mon, Aug 10, 2015 at 12:31 PM, Gregg Smithg...@gknw.net  wrote:


Hi,

I guess a minor at least.

I did not add, remove or change the structure of the function, I simply
made it available to modules. Does that warrant a major bump?


Never a major - that is reserved for changing the signature of functions
or members of structures that are catastrophic for previously compiled
modules.  This is not one of those :)

The previous absence of these exports was simply a bug, I don't see
a reason to bump the version minor for bug fixing.

If users were looking to determine compatibility, e.g. on the 2.4 released
branch, I might have another opinion, but during trunk development, we
fix it and move on.  A previously compiled module simply wouldn't have
any insight on these functions so correcting it doesn't break what they
were already aware of


Thanks Christophe for bringing it up.
Thanks Bill and Rüdiger for the answer. I was sure it was not a major 
bump yet was foggy on the minor. My feeling on it was as Bill stated in 
his last sentence above.


G

Re: svn commit: r1694950 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_request.c

2015-08-10 Thread Gregg Smith 

Hi,

I guess a minor at least.

I did not add, remove or change the structure of the function, I simply 
made it available to modules. Does that warrant a major bump?




On 8/9/2015 10:40 PM, Marion  Christophe JAILLET wrote:

Hi,

doesn't it require a minor ap_mmn.h bump ?

cj

Le 10/08/2015 05:30, gsm...@apache.org a écrit :

Author: gsmith
Date: Mon Aug 10 03:30:25 2015
New Revision: 1694950

URL: http://svn.apache.org/r1694950
Log:
ap_process_request needs exportation for use in mod_h2 on Windows

Modified:
 httpd/httpd/trunk/include/http_request.h
 httpd/httpd/trunk/modules/http/http_request.c

Modified: httpd/httpd/trunk/include/http_request.h
URL: 
http://svn.apache.org/viewvc/httpd/httpd/trunk/include/http_request.h?rev=1694950r1=1694949r2=1694950view=diff
== 


--- httpd/httpd/trunk/include/http_request.h (original)
+++ httpd/httpd/trunk/include/http_request.h Mon Aug 10 03:30:25 2015
@@ -316,7 +316,7 @@ AP_DECLARE(void) ap_allow_standard_metho
   * the response to the client
   * @param r The current request
   */
-void ap_process_request(request_rec *r);
+AP_DECLARE(void) ap_process_request(request_rec *r);
/* For post-processing after a handler has finished with a request.
   * (Commonly used after it was suspended)

Modified: httpd/httpd/trunk/modules/http/http_request.c
URL: 
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_request.c?rev=1694950r1=1694949r2=1694950view=diff
== 


--- httpd/httpd/trunk/modules/http/http_request.c (original)
+++ httpd/httpd/trunk/modules/http/http_request.c Mon Aug 10 03:30:25 
2015

@@ -363,7 +363,7 @@ void ap_process_async_request(request_re
  ap_process_request_after_handler(r);
  }
  -void ap_process_request(request_rec *r)
+AP_DECLARE(void) ap_process_request(request_rec *r)
  {
  apr_bucket_brigade *bb;
  apr_bucket *b;

Re: svn commit: r1694950 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_request.c

2015-08-10 Thread William A Rowe Jr 
On Mon, Aug 10, 2015 at 12:31 PM, Gregg Smith g...@gknw.net wrote:

 Hi,

 I guess a minor at least.

 I did not add, remove or change the structure of the function, I simply
 made it available to modules. Does that warrant a major bump?


Never a major - that is reserved for changing the signature of functions
or members of structures that are catastrophic for previously compiled
modules.  This is not one of those :)

The previous absence of these exports was simply a bug, I don't see
a reason to bump the version minor for bug fixing.

If users were looking to determine compatibility, e.g. on the 2.4 released
branch, I might have another opinion, but during trunk development, we
fix it and move on.  A previously compiled module simply wouldn't have
any insight on these functions so correcting it doesn't break what they
were already aware of.

RE: svn commit: r1694950 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_request.c

2015-08-10 Thread Plüm , Rüdiger , Vodafone Group 


 -Original Message-
 From: Marion  Christophe JAILLET 
 Sent: Montag, 10. August 2015 07:41
 To: dev@httpd.apache.org
 Subject: Re: svn commit: r1694950 - in /httpd/httpd/trunk:
 include/http_request.h modules/http/http_request.c
 
 Hi,
 
 doesn't it require a minor ap_mmn.h bump ?

I don't think so, since it only fixes a build issue on Windows and does not 
touch the API elsewhere.

Regards

Rüdiger

 
 cj
 
 Le 10/08/2015 05:30, gsm...@apache.org a écrit :
  Author: gsmith
  Date: Mon Aug 10 03:30:25 2015
  New Revision: 1694950
 
  URL: http://svn.apache.org/r1694950
  Log:
  ap_process_request needs exportation for use in mod_h2 on Windows
 
  Modified:
   httpd/httpd/trunk/include/http_request.h
   httpd/httpd/trunk/modules/http/http_request.c
 
  Modified: httpd/httpd/trunk/include/http_request.h
  URL:
 http://svn.apache.org/viewvc/httpd/httpd/trunk/include/http_request.h?rev=
 1694950r1=1694949r2=1694950view=diff
 
 ==
 
  --- httpd/httpd/trunk/include/http_request.h (original)
  +++ httpd/httpd/trunk/include/http_request.h Mon Aug 10 03:30:25 2015
  @@ -316,7 +316,7 @@ AP_DECLARE(void) ap_allow_standard_metho
 * the response to the client
 * @param r The current request
 */
  -void ap_process_request(request_rec *r);
  +AP_DECLARE(void) ap_process_request(request_rec *r);
 
/* For post-processing after a handler has finished with a request.
 * (Commonly used after it was suspended)
 
  Modified: httpd/httpd/trunk/modules/http/http_request.c
  URL:
 http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_request.c
 ?rev=1694950r1=1694949r2=1694950view=diff
 
 ==
 
  --- httpd/httpd/trunk/modules/http/http_request.c (original)
  +++ httpd/httpd/trunk/modules/http/http_request.c Mon Aug 10 03:30:25
 2015
  @@ -363,7 +363,7 @@ void ap_process_async_request(request_re
ap_process_request_after_handler(r);
}
 
  -void ap_process_request(request_rec *r)
  +AP_DECLARE(void) ap_process_request(request_rec *r)
{
apr_bucket_brigade *bb;
apr_bucket *b;

Re: svn commit: r1694950 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_request.c

2015-08-09 Thread Marion Christophe JAILLET 

Hi,

doesn't it require a minor ap_mmn.h bump ?

cj

Le 10/08/2015 05:30, gsm...@apache.org a écrit :

Author: gsmith
Date: Mon Aug 10 03:30:25 2015
New Revision: 1694950

URL: http://svn.apache.org/r1694950
Log:
ap_process_request needs exportation for use in mod_h2 on Windows

Modified:
 httpd/httpd/trunk/include/http_request.h
 httpd/httpd/trunk/modules/http/http_request.c

Modified: httpd/httpd/trunk/include/http_request.h
URL: 
http://svn.apache.org/viewvc/httpd/httpd/trunk/include/http_request.h?rev=1694950r1=1694949r2=1694950view=diff
==
--- httpd/httpd/trunk/include/http_request.h (original)
+++ httpd/httpd/trunk/include/http_request.h Mon Aug 10 03:30:25 2015
@@ -316,7 +316,7 @@ AP_DECLARE(void) ap_allow_standard_metho
   * the response to the client
   * @param r The current request
   */
-void ap_process_request(request_rec *r);
+AP_DECLARE(void) ap_process_request(request_rec *r);
  
  /* For post-processing after a handler has finished with a request.

   * (Commonly used after it was suspended)

Modified: httpd/httpd/trunk/modules/http/http_request.c
URL: 
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_request.c?rev=1694950r1=1694949r2=1694950view=diff
==
--- httpd/httpd/trunk/modules/http/http_request.c (original)
+++ httpd/httpd/trunk/modules/http/http_request.c Mon Aug 10 03:30:25 2015
@@ -363,7 +363,7 @@ void ap_process_async_request(request_re
  ap_process_request_after_handler(r);
  }
  
-void ap_process_request(request_rec *r)

+AP_DECLARE(void) ap_process_request(request_rec *r)
  {
  apr_bucket_brigade *bb;
  apr_bucket *b;