Re: svn commit: r1715789 - in /httpd/httpd/trunk: modules/cache/ modules/filters/ modules/generators/ modules/http/ modules/http2/ modules/loggers/ modules/mappers/ modules/metadata/ modules/proxy/ mo

2015-11-24 Thread Jim Jagielski 
To be clear, I was only semi-joking about the code
changes (eg: apr_atoi64()) which did not involve
ap_casecmpstr() at all :) :)


> On Nov 23, 2015, at 11:50 AM, Yann Ylavic  wrote:
> 
> On Mon, Nov 23, 2015 at 3:05 PM, Jim Jagielski  wrote:
>> 
>> That's cheating :)
> 
> Yeah, reverted (r1715869) and re-committed (r1715876) with no functional 
> change.
> Thanks for catching!

Re: svn commit: r1715789 - in /httpd/httpd/trunk: modules/cache/ modules/filters/ modules/generators/ modules/http/ modules/http2/ modules/loggers/ modules/mappers/ modules/metadata/ modules/proxy/ mo

2015-11-24 Thread Yann Ylavic 
I think that's what I understood :)
I prefered reverting the whole and re-committing without the unrelated
changes (the three apr_atoi64() in cache_util.c), and then commit
those apr_atoi64() changes separately (r1715886) to propose a specific
backport...

On Tue, Nov 24, 2015 at 1:37 PM, Jim Jagielski  wrote:
> To be clear, I was only semi-joking about the code
> changes (eg: apr_atoi64()) which did not involve
> ap_casecmpstr() at all :) :)
>
>
>> On Nov 23, 2015, at 11:50 AM, Yann Ylavic  wrote:
>>
>> On Mon, Nov 23, 2015 at 3:05 PM, Jim Jagielski  wrote:
>>>
>>> That's cheating :)
>>
>> Yeah, reverted (r1715869) and re-committed (r1715876) with no functional 
>> change.
>> Thanks for catching!
>

Re: svn commit: r1715789 - in /httpd/httpd/trunk: modules/cache/ modules/filters/ modules/generators/ modules/http/ modules/http2/ modules/loggers/ modules/mappers/ modules/metadata/ modules/proxy/ mo

2015-11-23 Thread Jim Jagielski 

> On Nov 23, 2015, at 7:33 AM, yla...@apache.org wrote:
> 
> Author: ylavic
> Date: Mon Nov 23 12:33:09 2015
> New Revision: 1715789
> 
> URL: http://svn.apache.org/viewvc?rev=1715789=rev
> Log:
> Use new ap_casecmpstr[n]() functions where appropriate (not exhaustive).
> 
> 
> Modified: httpd/httpd/trunk/modules/cache/cache_util.c
> URL: 
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cache/cache_util.c?rev=1715789=1715788=1715789=diff
> ==
> --- httpd/httpd/trunk/modules/cache/cache_util.c (original)
> +++ httpd/httpd/trunk/modules/cache/cache_util.c Mon Nov 23 12:33:09 2015
> @@ -594,7 +594,12 @@ int cache_check_freshness(cache_handle_t
> }
> 
> if ((agestr = apr_table_get(h->resp_hdrs, "Age"))) {
> -age_c = apr_atoi64(agestr);
> +char *endp;
> +apr_off_t offt;
> +if (!apr_strtoff(, agestr, , 10)
> +&& endp > agestr && !*endp) {
> +age_c = offt;
> +}
> }
> 
> /* calculate age of object */
> 

That's cheating :)

Re: svn commit: r1715789 - in /httpd/httpd/trunk: modules/cache/ modules/filters/ modules/generators/ modules/http/ modules/http2/ modules/loggers/ modules/mappers/ modules/metadata/ modules/proxy/ mo

2015-11-23 Thread Yann Ylavic 
On Mon, Nov 23, 2015 at 3:05 PM, Jim Jagielski  wrote:
>
> That's cheating :)

Yeah, reverted (r1715869) and re-committed (r1715876) with no functional change.
Thanks for catching!