Re: svn commit: r1743577 [1/2] - in /httpd/httpd/branches/2.4.x: docs/manual/mod/mod_proxy_http2.xml modules/http2/NWGNUproxyht2 modules/http2/h2_proxy_session.c modules/http2/h2_proxy_session.h modul

2016-05-12 Thread Marion & Christophe JAILLET

Hi,

there are 2 valid issues spotted by smatch in debug logging message:

modules/http2/h2_proxy_session.c:339 on_data_chunk_recv() error: we 
previously assumed 'stream' could be null (see line 338)
modules/http2/h2_proxy_session.c:425 stream_data_read() error: we 
previously assumed 'stream' could be null (see line 424)


I'll also give a closer look at it tonight if no one fix it in the meantime.

CJ

Le 12/05/2016 à 23:31, j...@apache.org a écrit :

Author: jim
Date: Thu May 12 21:31:44 2016
New Revision: 1743577

URL: http://svn.apache.org/viewvc?rev=1743577=rev
Log:
Merge r1729208, r1735668, r1735668, r1735931, r1735935, r1735942 from trunk:

let proxy handler forward ALPN protocol strings for ssl proxy connections

Remove leftover comment

Remove leftover comment

APLOGNO update for mod_proxy_http2

fix APLOGNO at wrong place, me stupid

h2_proxy_session: fill in missing APLOGNO()s.
Submitted by: icing, jailletc36, jailletc36, icing, icing, ylavic
Reviewed/backported by: jim

Added:
 httpd/httpd/branches/2.4.x/docs/manual/mod/mod_proxy_http2.xml
 httpd/httpd/branches/2.4.x/modules/http2/NWGNUproxyht2
 httpd/httpd/branches/2.4.x/modules/http2/h2_proxy_session.c
 httpd/httpd/branches/2.4.x/modules/http2/h2_proxy_session.h
 httpd/httpd/branches/2.4.x/modules/http2/mod_proxy_http2.c
 httpd/httpd/branches/2.4.x/modules/http2/mod_proxy_http2.h





Re: svn commit: r1743577 [1/2] - in /httpd/httpd/branches/2.4.x: docs/manual/mod/mod_proxy_http2.xml modules/http2/NWGNUproxyht2 modules/http2/h2_proxy_session.c modules/http2/h2_proxy_session.h modul

2016-05-12 Thread Marion & Christophe JAILLET

Hi all,

mod_proxy_http2 does not compile because of changes made in mod_hhtp2:

   - h2_ihash_is_empty vs h2_ihash_empty
   - h2_request_create vs h2_req_create
   - modified header files
   - ...

If not fixed in the mean time, I'll give a look at it tonight.


Do we need to go thru the formal voting process for fixing build failure 
on an experimental module?


CJ


Le 12/05/2016 à 23:31, j...@apache.org a écrit :

Author: jim
Date: Thu May 12 21:31:44 2016
New Revision: 1743577

URL: http://svn.apache.org/viewvc?rev=1743577=rev
Log:
Merge r1729208, r1735668, r1735668, r1735931, r1735935, r1735942 from trunk:

let proxy handler forward ALPN protocol strings for ssl proxy connections

Remove leftover comment

Remove leftover comment

APLOGNO update for mod_proxy_http2

fix APLOGNO at wrong place, me stupid

h2_proxy_session: fill in missing APLOGNO()s.
Submitted by: icing, jailletc36, jailletc36, icing, icing, ylavic
Reviewed/backported by: jim

Added:
 httpd/httpd/branches/2.4.x/docs/manual/mod/mod_proxy_http2.xml
 httpd/httpd/branches/2.4.x/modules/http2/NWGNUproxyht2
 httpd/httpd/branches/2.4.x/modules/http2/h2_proxy_session.c
 httpd/httpd/branches/2.4.x/modules/http2/h2_proxy_session.h
 httpd/httpd/branches/2.4.x/modules/http2/mod_proxy_http2.c
 httpd/httpd/branches/2.4.x/modules/http2/mod_proxy_http2.h