Re: svn commit: r1787525 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_autoindex.xml modules/generators/mod_autoindex.c

2017-03-18 Thread Eric Covener 
On Sat, Mar 18, 2017 at 4:08 AM, Marion & Christophe JAILLET
 wrote:
> So I think that there is a small display artifact and that there is 1 extra
> space when the "%Y-%m-%d %H:%M" format is used.
>
> I've not tested, so I don't know if it makes a real difference.
>
> Also the comment should be changed in something like /* Length="22-Feb-1998
> 23:42  " or Length="1975-04-07 01:23  ". See 'datetime_format' definition */


Thanks, comment updated in r1787553.  I left the whitespace as-is,
since this retains how both versions have been appearing.

-- 
Eric Covener
cove...@gmail.com

Re: svn commit: r1787525 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_autoindex.xml modules/generators/mod_autoindex.c

2017-03-18 Thread Marion & Christophe JAILLET 



Le 18/03/2017 à 03:51, cove...@apache.org a écrit :

Author: covener
Date: Sat Mar 18 02:51:02 2017
New Revision: 1787525

URL: http://svn.apache.org/viewvc?rev=1787525=rev
Log:
Add IndexOptions UseOldDateFormat

   *) mod_autoindex: Add IndexOptions UseOldDateFormat to allow the date
  format from 2.2 in the Last Modified column. PR60846.
   
PR34014 / r903052 changed date format for autoindex


[...]

@@ -1844,8 +1851,9 @@ static void output_directories(struct en
  apr_time_exp_t ts;
  apr_time_exp_lt(, ar[x]->lm);
  apr_strftime(time_str, , sizeof(time_str),
-"%Y-%m-%d %H:%M  ", );
-ap_rputs(time_str, r);
+datetime_format,
+);
+ap_rvputs(r, time_str, "  ", NULL);
  }
  else {
  /*Length="1975-04-07 01:23  " (see 4 lines above) */


The lines below have been changed this way in r903052:

-/*Length="22-Feb-1998 23:42  " (see 4 lines above) */
+/*Length="1975-04-07 01:23  " (see 4 lines above) */
 ap_rputs("   ", r);


So I think that there is a small display artifact and that there is 1 
extra space when the "%Y-%m-%d %H:%M" format is used.


I've not tested, so I don't know if it makes a real difference.

Also the comment should be changed in something like /* 
Length="22-Feb-1998 23:42  " or Length="1975-04-07 01:23  ". See 
'datetime_format' definition */


CJ