Reading this commentary, we agree that is an enhancement. On Oct 15, 2017 06:32, <rj...@apache.org> wrote:
> Author: rjung > Date: Sun Oct 15 11:31:58 2017 > New Revision: 1812217 > > URL: http://svn.apache.org/viewvc?rev=1812217&view=rev > Log: > Vote, comment. > > Modified: > httpd/httpd/branches/2.4.x/STATUS > > Modified: httpd/httpd/branches/2.4.x/STATUS > URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/ > STATUS?rev=1812217&r1=1812216&r2=1812217&view=diff > ============================================================ > ================== > --- httpd/httpd/branches/2.4.x/STATUS (original) > +++ httpd/httpd/branches/2.4.x/STATUS Sun Oct 15 11:31:58 2017 > @@ -214,9 +214,24 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: > trunk patch: http://svn.apache.org/r1810448 > http://svn.apache.org/r1810998 > 2.4.x patch: svn merge -c 1810448,1810998 ^/httpd/httpd/trunk . > - +1: jim, wrowe > + +1: jim, wrowe, rjung > [This seems to fit into the mold of per-platform quirks which we > process > in CTR flow, adding my +1 to note that the patch looks sane.] > + rjung: The following two comments are not meant to block applying > that change. > + - A possible enhancement would be to detect the problem, e.g. > + using AC_CHECK_LIB for a test that should always succeed and > + if it fails, try again with "-Wno-error=strict-prototypes". > + - Another more far reaching enhancement would be to add > + "-Wno-error=strict-prototypes" only during configure but not > + later when we do the actual build in order to still detect > missing > + prototypes then. Since configure does not seem to have the > + concept of settings only applied during configure run, we > would > + need to remember "-Wno-error=strict-prototypes" as a flag we > just > + added to make configure work. Then, right before configure > + generates output files, we would strip any such flag from > CFLAGS > + to generate the correct build time CFLAGS. > + Unfortunately things might get trickier when building apr/apu > + in combination with httpd. > > > PATCHES/ISSUES THAT ARE BEING WORKED > > >
