Re: svn commit: r1813167 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy_balancer.c

2017-10-25 Thread Jim Jagielski
The only reasons we keep those factors as ints rather than floats are: 1. We can't change the struct fields in 2.4.x 2. The rationale that int based operations will "always" be faster than floating point 2.5.0 doesn't suffer from #1. We can break API/ABI if there's a good reason. And #2

Re: svn commit: r1813167 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy_balancer.c

2017-10-25 Thread Yann Ylavic
On Tue, Oct 24, 2017 at 11:58 PM, Jim Jagielski wrote: > As you said, the external representation as a float is syntactic sugar. > But the patch breaks that. Someone enters in, for example, 2.50 > and what's displayed in 250, instead of 2.50. > > Since all this is normalized by

Re: svn commit: r1813167 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy_balancer.c

2017-10-24 Thread Jim Jagielski
> On Oct 24, 2017, at 4:16 PM, Yann Ylavic wrote: > > > Meaning that we now have a granularity of 10KB (instead of previous > 100B, max) before a balancer member can take over the previous one (I > wondered why several successive small requests were always reaching > the

Re: svn commit: r1813167 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy_balancer.c

2017-10-24 Thread Jim Jagielski
As you said, the external representation as a float is syntactic sugar. But the patch breaks that. Someone enters in, for example, 2.50 and what's displayed in 250, instead of 2.50. Since all this is normalized by how ldfactor is USED, the algos still work, but are now more granular, which is

Re: svn commit: r1813167 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy_balancer.c

2017-10-24 Thread Yann Ylavic
On Tue, Oct 24, 2017 at 3:28 PM, Jim Jagielski wrote: > I don't understand this patch. It looks like we are no lingering externally > representing ldfactor as a float (e.g.: 2.50). Is that right? If so, > I'm not sure why... It seems to me that ldfactor expressed as "float" is

AW: svn commit: r1813167 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy_balancer.c

2017-10-24 Thread Plüm , Rüdiger , Vodafone Group
eck below). Regards Rüdiger > -Ursprüngliche Nachricht- > Von: Jim Jagielski [mailto:j...@jagunet.com] > Gesendet: Dienstag, 24. Oktober 2017 15:29 > An: dev@httpd.apache.org > Cc: c...@httpd.apache.org > Betreff: Re: svn commit: r1813167 - in /httpd/httpd/trunk: CH