Re: AW: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On 06/27/2019 10:45 PM, William A Rowe Jr wrote: > On Thu, Jun 27, 2019 at 2:06 PM Ruediger Pluem > wrote: > > > On 06/25/2019 10:39 AM, Plüm, Rüdiger, Vodafone Group wrote: > > > > Another related question: Do you think it would be beneficial if we >

Re: AW: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On Thu, Jun 27, 2019 at 2:06 PM Ruediger Pluem wrote: > > On 06/25/2019 10:39 AM, Plüm, Rüdiger, Vodafone Group wrote: > > > > Another related question: Do you think it would be beneficial if we > replace > > the apr_psprintf with apr_pstrcat in props.c as long as they only concat > strings

Re: AW: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On 06/25/2019 10:39 AM, Plüm, Rüdiger, Vodafone Group wrote: > > > > > Another related question: Do you think it would be beneficial if we replace > the apr_psprintf with apr_pstrcat in props.c as long as they only concat > strings without > further formatting? > > Anyone any opinion

AW: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

C2 General > -Ursprüngliche Nachricht- > Von: Joe Orton > Gesendet: Dienstag, 25. Juni 2019 13:59 > An: dev@httpd.apache.org > Betreff: Re: svn commit: r1841225 - > /httpd/httpd/trunk/modules/dav/main/props.c > > On Tue, Jun 25, 2019 at 09:06:42AM +, Plüm,

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On Tue, Jun 25, 2019 at 09:06:42AM +, Plüm, Rüdiger, Vodafone Group wrote: > > On Tue, Jun 25, 2019 at 08:49:08AM +0100, Joe Orton wrote: > > > Unless I am missing something the apr_dir_open/apr_dir_read API design > > > is always going to have memory use proportional to directory size > > >

AW: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

C2 General > -Ursprüngliche Nachricht- > Von: Joe Orton > Gesendet: Dienstag, 25. Juni 2019 10:45 > An: dev@httpd.apache.org > Betreff: Re: svn commit: r1841225 - > /httpd/httpd/trunk/modules/dav/main/props.c > > On Tue, Jun 25, 2019 at 08:49:08AM +0100, Joe O

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

Nice work! > Am 25.06.2019 um 10:44 schrieb Joe Orton : > >

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On Tue, Jun 25, 2019 at 08:49:08AM +0100, Joe Orton wrote: > Unless I am missing something the apr_dir_open/apr_dir_read API design > is always going to have memory use proportional to directory size > because apr_dir_read() duplicates the filename into the directory's > pool. We need an

AW: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

C2 General > -Ursprüngliche Nachricht- > Von: Joe Orton > Gesendet: Dienstag, 25. Juni 2019 09:49 > An: dev@httpd.apache.org > Betreff: Re: svn commit: r1841225 - > /httpd/httpd/trunk/modules/dav/main/props.c > > On Mon, Jun 24, 2019 at 09:54:21PM +02

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On Mon, Jun 24, 2019 at 09:54:21PM +0200, Ruediger Pluem wrote: > On 06/24/2019 07:04 PM, Joe Orton wrote: > > #11 0x7f8110ce6448 in dav_do_prop_subreq (propdb=0x100cfc0) at > > props.c:331 > > What if you go here and do a > > dump_all_pools propdb->p > > and do it again when you hit the

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On 06/24/2019 07:04 PM, Joe Orton wrote: > On Fri, Feb 08, 2019 at 08:07:57AM +0100, Ruediger Pluem wrote: >> On 11/13/2018 10:26 AM, Joe Orton wrote: >>> On Mon, Nov 12, 2018 at 08:26:48AM +0100, Ruediger Pluem wrote: The discussion died a little bit, because of the other issue (frequent

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On 06/24/2019 07:04 PM, Joe Orton wrote: > On Fri, Feb 08, 2019 at 08:07:57AM +0100, Ruediger Pluem wrote: >> On 11/13/2018 10:26 AM, Joe Orton wrote: >>> On Mon, Nov 12, 2018 at 08:26:48AM +0100, Ruediger Pluem wrote: The discussion died a little bit, because of the other issue (frequent

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On Fri, Feb 08, 2019 at 08:07:57AM +0100, Ruediger Pluem wrote: > On 11/13/2018 10:26 AM, Joe Orton wrote: > > On Mon, Nov 12, 2018 at 08:26:48AM +0100, Ruediger Pluem wrote: > >> The discussion died a little bit, because of the other issue (frequent > >> writeev calls). I know that the liveprops

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On 11/13/2018 10:26 AM, Joe Orton wrote: > On Mon, Nov 12, 2018 at 08:26:48AM +0100, Ruediger Pluem wrote: >> The discussion died a little bit, because of the other issue (frequent >> writeev calls). I know that the liveprops issue is not fixed yet, but >> I guess it makes sense if you commit

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On Mon, Nov 12, 2018 at 08:26:48AM +0100, Ruediger Pluem wrote: > The discussion died a little bit, because of the other issue (frequent > writeev calls). I know that the liveprops issue is not fixed yet, but > I guess it makes sense if you commit the patch you posted here > already. Sorry, I

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On Mon, Nov 12, 2018 at 1:26 AM Ruediger Pluem wrote: >... > The discussion died a little bit, because of the other issue (frequent > writeev calls). > I know that the liveprops issue is not fixed yet, but I guess it makes > sense > if you commit the patch you posted here already. > My time has

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On 10/18/2018 01:45 PM, Joe Orton wrote: > On Thu, Oct 18, 2018 at 11:09:13AM +0200, Ruediger Pluem wrote: >> On 10/17/2018 07:47 PM, Joe Orton wrote: >>> On Wed, Oct 17, 2018 at 03:32:34PM +0100, Joe Orton wrote: I see constant memory use for a simple PROPFIND/depth:1 for the

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On Thu, Oct 18, 2018 at 11:09:13AM +0200, Ruediger Pluem wrote: > On 10/17/2018 07:47 PM, Joe Orton wrote: > > On Wed, Oct 17, 2018 at 03:32:34PM +0100, Joe Orton wrote: > >> I see constant memory use for a simple PROPFIND/depth:1 for the > >> attached, though I'm not sure this is sufficient to

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On Thu, Oct 18, 2018 at 11:29 AM Ruediger Pluem wrote: > > > > The reason is ap_request_core_filter. It iterates over the brigade and > > hands over each bucket alone to > > ap_core_output_filter. IMHO a bug. > > How about the attached patch for fixing? +1, nice way to address it! Thanks,

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On 10/18/2018 11:29 AM, Ruediger Pluem wrote: > > > On 10/18/2018 11:09 AM, Ruediger Pluem wrote: >> >> >> On 10/17/2018 07:47 PM, Joe Orton wrote: >>> On Wed, Oct 17, 2018 at 03:32:34PM +0100, Joe Orton wrote: I see constant memory use for a simple PROPFIND/depth:1 for the

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On 10/18/2018 11:09 AM, Ruediger Pluem wrote: > > > On 10/17/2018 07:47 PM, Joe Orton wrote: >> On Wed, Oct 17, 2018 at 03:32:34PM +0100, Joe Orton wrote: >>> I see constant memory use for a simple PROPFIND/depth:1 for the >>> attached, though I'm not sure this is sufficient to repro the

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On 10/17/2018 07:47 PM, Joe Orton wrote: > On Wed, Oct 17, 2018 at 03:32:34PM +0100, Joe Orton wrote: >> I see constant memory use for a simple PROPFIND/depth:1 for the >> attached, though I'm not sure this is sufficient to repro the problem >> you saw before. Thanks for having a look. My

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On Wed, Oct 17, 2018 at 03:32:34PM +0100, Joe Orton wrote: > I see constant memory use for a simple PROPFIND/depth:1 for the > attached, though I'm not sure this is sufficient to repro the problem > you saw before. I needed to also remove the new apr_pool_clear() there. Is the repro case for

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On Tue, Oct 16, 2018 at 02:28:06PM +0200, Ruediger Pluem wrote: > Gentle ping :-). Did you find some time to have a look? "I'm not Greg, but..." This seems to be duplicating the ctx->scratchpool which was added for use in dav_propfind_walker specifically to solve this kind of problem, I think?

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

Gentle ping :-). Did you find some time to have a look? Regards Rüdiger On 09/25/2018 06:37 PM, Greg Stein wrote: > We learned a lot about pool handling while writing Subversion, after I wrote > that mod_dav code. There are definite some > improvements to be made. I'm not surprised that a

AW: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

r1842010 Regards Rüdiger > -Ursprüngliche Nachricht- > Von: Joe Orton > Gesendet: Mittwoch, 26. September 2018 11:41 > An: dev@httpd.apache.org > Betreff: Re: svn commit: r1841225 - > /httpd/httpd/trunk/modules/dav/main/props.c > > On Wed, Sep 26, 2018 a

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On Wed, Sep 26, 2018 at 09:30:25AM +, Plüm, Rüdiger, Vodafone Group wrote: > Thanks for reporting. Does the below patch cause the crash to go away? Yes, works for me!

AW: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

che.org > Betreff: Re: svn commit: r1841225 - > /httpd/httpd/trunk/modules/dav/main/props.c > > On Tue, Sep 18, 2018 at 03:04:13PM +0200, Ruediger Pluem wrote: > > Pools are very tricky in mod_dav. Hence additional eyeballs are very > much welcome here. > > As I only did

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

On Tue, Sep 18, 2018 at 03:04:13PM +0200, Ruediger Pluem wrote: > Pools are very tricky in mod_dav. Hence additional eyeballs are very much > welcome here. > As I only did testing with mod_dav_fs I would be keen to know if things still > work with Subversion. > So if someone from the Subversion

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

We learned a lot about pool handling while writing Subversion, after I wrote that mod_dav code. There are definite some improvements to be made. I'm not surprised that a propfind can go nuts like that ... I'll review the change and take a look generally. h/t to DanielR for the pointer to this

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

Pools are very tricky in mod_dav. Hence additional eyeballs are very much welcome here. As I only did testing with mod_dav_fs I would be keen to know if things still work with Subversion. So if someone from the Subversion guys is listening here: Having this tested with Subversion would be very