Re: svn commit: r1879401 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h mod_proxy_http.c mod_proxy_wstunnel.c proxy_util.c

2020-07-23 Thread Yann Ylavic
On Wed, Jul 22, 2020 at 9:15 PM Ruediger Pluem wrote: > > Will you commit? r1880200, wider change aiming at addressing this issue and anything POLLERR related. Regards; Yann.

Re: svn commit: r1879401 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h mod_proxy_http.c mod_proxy_wstunnel.c proxy_util.c

2020-07-22 Thread Ruediger Pluem
On 7/14/20 9:11 PM, Ruediger Pluem wrote: > > > On 7/10/20 6:15 PM, Ruediger Pluem wrote: >> >> >> On 7/10/20 5:05 PM, Yann Ylavic wrote: >> >> This was the reason why I did not commit anything yet, because I had the >> feeling that I don't understand everything completely :_) >> >>> >>>

Re: svn commit: r1879401 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h mod_proxy_http.c mod_proxy_wstunnel.c proxy_util.c

2020-07-14 Thread Ruediger Pluem
On 7/10/20 6:15 PM, Ruediger Pluem wrote: > > > On 7/10/20 5:05 PM, Yann Ylavic wrote: >> On Fri, Jul 10, 2020 at 12:25 PM Ruediger Pluem wrote: >>> >>> I observed 36 which 0x24 or POLLHUP | POLLOUT for rtnevents and >>> 52 which is 0x34 or POLLHUP | POLLOUT | POLLERR for rtnevents >> >>

Re: svn commit: r1879401 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h mod_proxy_http.c mod_proxy_wstunnel.c proxy_util.c

2020-07-10 Thread Ruediger Pluem
On 7/10/20 5:05 PM, Yann Ylavic wrote: > On Fri, Jul 10, 2020 at 12:25 PM Ruediger Pluem wrote: >> >> I observed 36 which 0x24 or POLLHUP | POLLOUT for rtnevents and >> 52 which is 0x34 or POLLHUP | POLLOUT | POLLERR for rtnevents > > Thanks, so POLLHUP|POLLERR while POSIX says they are

Re: svn commit: r1879401 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h mod_proxy_http.c mod_proxy_wstunnel.c proxy_util.c

2020-07-10 Thread Yann Ylavic
On Fri, Jul 10, 2020 at 12:25 PM Ruediger Pluem wrote: > > I observed 36 which 0x24 or POLLHUP | POLLOUT for rtnevents and > 52 which is 0x34 or POLLHUP | POLLOUT | POLLERR for rtnevents Thanks, so POLLHUP|POLLERR while POSIX says they are mutually exclusive.. I'd rather fix it with the below

Re: svn commit: r1879401 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h mod_proxy_http.c mod_proxy_wstunnel.c proxy_util.c

2020-07-10 Thread Ruediger Pluem
On 7/10/20 11:54 AM, Yann Ylavic wrote: > On Fri, Jul 10, 2020 at 9:55 AM Ruediger Pluem wrote: >> >> On 7/1/20 6:35 PM, yla...@apache.org wrote: >>> Author: ylavic >>> Date: Wed Jul 1 16:35:48 2020 >>> New Revision: 1879401 >>> >>> for (i = 0; i < nresults; i++) { >>> -

Re: svn commit: r1879401 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h mod_proxy_http.c mod_proxy_wstunnel.c proxy_util.c

2020-07-10 Thread Yann Ylavic
On Fri, Jul 10, 2020 at 9:55 AM Ruediger Pluem wrote: > > On 7/1/20 6:35 PM, yla...@apache.org wrote: > > Author: ylavic > > Date: Wed Jul 1 16:35:48 2020 > > New Revision: 1879401 > > > > for (i = 0; i < nresults; i++) { > > -const apr_pollfd_t *cur = [i]; > > -

Re: svn commit: r1879401 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h mod_proxy_http.c mod_proxy_wstunnel.c proxy_util.c

2020-07-10 Thread Ruediger Pluem
On 7/10/20 9:55 AM, Ruediger Pluem wrote: > > > On 7/1/20 6:35 PM, yla...@apache.org wrote: >> Author: ylavic >> Date: Wed Jul 1 16:35:48 2020 >> New Revision: 1879401 >> >> URL: http://svn.apache.org/viewvc?rev=1879401=rev >> Log: >> mod_proxy: improved and reentrant tunneling loop. >> >>

Re: svn commit: r1879401 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h mod_proxy_http.c mod_proxy_wstunnel.c proxy_util.c

2020-07-10 Thread Ruediger Pluem
On 7/1/20 6:35 PM, yla...@apache.org wrote: > Author: ylavic > Date: Wed Jul 1 16:35:48 2020 > New Revision: 1879401 > > URL: http://svn.apache.org/viewvc?rev=1879401=rev > Log: > mod_proxy: improved and reentrant tunneling loop. > > modules/proxy/mod_proxy.h: > Rename