Re: svn commit: r321449 - in /httpd/mod_mbox/trunk/module-2.0: mod_mbox_file.c mod_mbox_index.c

2005-10-15 Thread André Malo
* [EMAIL PROTECTED] wrote: - if (r-header_only) - status = OK; + if (r-header_only) { + return OK; +} Actually I think, any code that checks for header_only is wrong. The core will take care of it. Not treating HEAD requests special ensures, that the RFC

Re: svn commit: r321449 - in /httpd/mod_mbox/trunk/module-2.0: mod_mbox_file.c mod_mbox_index.c

2005-10-15 Thread Paul Querna
André Malo wrote: * [EMAIL PROTECTED] wrote: - if (r-header_only) - status = OK; + if (r-header_only) { + return OK; +} Actually I think, any code that checks for header_only is wrong. The core will take care of it. Not treating HEAD requests special

Re: svn commit: r321449 - in /httpd/mod_mbox/trunk/module-2.0: mod_mbox_file.c mod_mbox_index.c

2005-10-15 Thread Justin Erenkrantz
On Sat, Oct 15, 2005 at 12:08:15PM -0700, Paul Querna wrote: Except when we get a HEAD request, r-path_info is filled with bogus data, which causes mod_mbox to crash way deep inside itself. Why isn't r-path_info filled out correctly? If the request's path_info itself is bogus, that should be

Re: svn commit: r321449 - in /httpd/mod_mbox/trunk/module-2.0: mod_mbox_file.c mod_mbox_index.c

2005-10-15 Thread Paul Querna
Justin Erenkrantz wrote: On Sat, Oct 15, 2005 at 12:08:15PM -0700, Paul Querna wrote: Except when we get a HEAD request, r-path_info is filled with bogus data, which causes mod_mbox to crash way deep inside itself. Why isn't r-path_info filled out correctly? If the request's path_info itself