On Wed, Sep 27, 2006 at 02:41:11PM +0200, Graham Leggett wrote:
> On Wed, September 27, 2006 2:31 pm, Joe Orton wrote:
>
> > The new approach is exactly the same for other bucket types, FILE should
> > not be treated as special just to avoid that. Other bucket types will
> > cause the same memory
On Wed, September 27, 2006 2:31 pm, Joe Orton wrote:
> The new approach is exactly the same for other bucket types, FILE should
> not be treated as special just to avoid that. Other bucket types will
> cause the same memory consumption issue (notably CGI/PIPE).
I looked at this issue, but I coul
On Wed, Sep 27, 2006 at 01:31:05PM +0200, Graham Leggett wrote:
> On Wed, September 27, 2006 11:37 am, Joe Orton wrote:
>
> > I don't get it - as discussed, this approach is completely unsound.
> > There is no reason to assume it's possible to copy the entire content
> > into the cache before send
On Wed, September 27, 2006 11:37 am, Joe Orton wrote:
> I don't get it - as discussed, this approach is completely unsound.
> There is no reason to assume it's possible to copy the entire content
> into the cache before sending anything to the client just because it
> happens to be a FILE bucket (
On Wed, 27 Sep 2006, Joe Orton wrote:
I don't get it - as discussed, this approach is completely unsound.
There is no reason to assume it's possible to copy the entire content
into the cache before sending anything to the client just because it
happens to be a FILE bucket (think slow NFS servers
On Tue, Sep 26, 2006 at 04:26:57PM -, Graham Leggett wrote:
> Author: minfrin
> Date: Tue Sep 26 09:26:56 2006
> New Revision: 450105
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=450105
> Log:
> mod_disk_cache: Make caching of large files possible on 32bit machines
> by determining wheth
Ruediger Pluem wrote:
+#define CACHE_BUF_SIZE 65536
+
Is it really a got idea to store 64k on the stack? Shouldn't we get this memory
from a pool?
+1.
Regards,
Graham
--
On 09/26/2006 06:26 PM, wrote:
> Author: minfrin
> Date: Tue Sep 26 09:26:56 2006
> New Revision: 450105
>
> Modified: httpd/httpd/trunk/modules/cache/mod_disk_cache.c
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cache/mod_disk_cache.c?view=diff&rev=450105&r1=450104&r2=450105
