Re: t/ssl/ocsp.t

Am 05.02.2019 um 11:33 schrieb Joe Orton: On Thu, Jan 17, 2019 at 09:02:02PM +0100, Christophe JAILLET wrote: Hi, I see test errors in #1 and #3 in t/ssl/ocsp.t. Does anyone else see it? I see it too. I changed it as you suggested in r1852984, maybe Rainer will comment if it breaks things

Re: t/ssl/ocsp.t

On Thu, Jan 17, 2019 at 09:02:02PM +0100, Christophe JAILLET wrote: > Hi, > > I see test errors in #1 and #3 in t/ssl/ocsp.t. > > Does anyone else see it? I see it too. I changed it as you suggested in r1852984, maybe Rainer will comment if it breaks things for for him again

t/ssl/ocsp.t

Hi, I see test errors in #1 and #3 in t/ssl/ocsp.t. Does anyone else see it? Looking deeper at the output (i.e. --verbose), it looks like the issue is in the test itself. All conditions seem to be there, but I need to turn:    my $message = $r->message(); into:    my $message = $r->c

Re: svn commit: r1844286 - /httpd/test/framework/trunk/t/ssl/ocsp.t

/trunk/t/ssl/ocsp.t Modified: httpd/test/framework/trunk/t/ssl/ocsp.t URL: http://svn.apache.org/viewvc/httpd/test/framework/trunk/t/ssl/ocsp.t?rev=1844286=1844285=1844286=diff == --- httpd/test/framework/trunk/t/ssl/ocsp.t

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

> On Oct 16, 2018, at 11:36 AM, William A Rowe Jr wrote: > > To button this issue up, it's clear to me that Jim had transposed the meaning > of result values from posix commands, and that was the origin of > irrationality in this discussion. > Actually, I did not. But thanks for playing.

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

To button this issue up, it's clear to me that Jim had transposed the meaning of result values from posix commands, and that was the origin of irrationality in this discussion. Beyond the misunderstanding, the actual behavior of openssl in 1.0.x and prior was inane, and led to Jim's confusion,

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

On 10/15/2018 01:25 PM, William A Rowe Jr wrote: On Sun, Oct 14, 2018 at 4:38 PM Dennis Clarke > wrote: As a red herring that illustrates how oddball the situation could get : $ /usr/sfw/bin/openssl version 2>&1 | cut -f1 -d\( OpenSSL 0.9.7d 17 Mar

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

On Sun, Oct 14, 2018 at 4:38 PM Dennis Clarke wrote: > > As a red herring that illustrates how oddball the situation could get : > > $ /usr/sfw/bin/openssl version 2>&1 | cut -f1 -d\( > OpenSSL 0.9.7d 17 Mar 2004 > [...] > Segmentation Fault(coredump) > I think we can safely ignore OpenSSL

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

On Wed, Oct 10, 2018 at 12:27 PM wrote: > Author: jim > Date: Wed Oct 10 17:27:33 2018 > New Revision: 1843478 > > @@ -21,7 +21,7 @@ Apache::TestRequest::module('ssl_ocsp'); > # support in earlier versions without messing around with stderr > my $openssl = Apache::TestSSLCA::openssl(); > if

Re: svn commit: r1843917 - /httpd/test/framework/trunk/t/ssl/ocsp.t

t; > > Author: wrowe > > Date: Mon Oct 15 14:55:27 2018 > > New Revision: 1843917 > > > > URL: http://svn.apache.org/viewvc?rev=1843917=rev > > Log: > > Revert r1832567, r1843476, r1843478 > > > > Restore jorton's detection from r1831398, and p

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

On Mon, Oct 15, 2018 at 10:10 AM Jim Jagielski wrote: > -1 (veto). > Correct. Your three commits against jorton's implementation are vetoed. They were incorrect. > 'list' is not a valid command. > You are wrong. The list-standard-commands feature was dropped from OpenSSL 1.1.0 and onwards.

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

Forget this. My patch works and is correct and handles the specific situation which is noted in the test case itself related to older versions. It is an IMPROVEMENT over what we currently have. The sole reason why Bill doesn't like it is because *I* committed it. Whatever. I have no desire or

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

-1 (veto). 'list' is not a valid command. > On Oct 15, 2018, at 11:04 AM, William A Rowe Jr wrote: > > On Mon, Oct 15, 2018 at 7:52 AM Jim Jagielski > wrote: > > And lest we forget, the orig version used: > > $openssl list -commands > > I have no idea what

Re: svn commit: r1843917 - /httpd/test/framework/trunk/t/ssl/ocsp.t

; Log: > Revert r1832567, r1843476, r1843478 > > Restore jorton's detection from r1831398, and portably redirect stderr > to capture and evaluate the available command list, > from either stdout (1.1.0 and later) or stderr (1.0.2 and prior). > > > Modified: >httpd/test/fra

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

On Mon, Oct 15, 2018 at 7:52 AM Jim Jagielski wrote: > > And lest we forget, the orig version used: > > $openssl list -commands > > I have no idea what version of openssl supports 'list'. The result > of which was that the ocsp testing was ALWAYS SKIPPED. > No, it wasn't skipped. We weren't

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

> On Oct 14, 2018, at 3:59 PM, William A Rowe Jr wrote: > > $ openssl xyz >/dev/null > Invalid command 'xyz'; type "help" for a list. > $ echo $? > 1 > $ openssl version > OpenSSL 1.1.0i-fips 14 Aug 2018 > > I have no idea which bastardization of the openssl command line tool you are >

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

On 10/14/2018 05:45 PM, William A Rowe Jr wrote: Dennis, just to confirm ...  is this build ocsp enabled.. Enabled and broken. At least on Solaris 10 sparc with recent patches. OpenSSL 1.1.1 works just fine. See below. OpenSSL 1.0.2n also blows up : $ /usr/bin/openssl version OpenSSL

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

Dennis, just to confirm ... is this build ocsp enabled, or entirely absent and yet presenting the ocsp help in absence of the feature? On Sun, Oct 14, 2018 at 4:38 PM Dennis Clarke wrote: > On 10/14/2018 05:14 PM, Rainer Jung wrote: > > Am 14.10.2018 um 22:58 schrieb William A Rowe Jr: > >> On

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

Am 14.10.2018 um 22:58 schrieb William A Rowe Jr: On Sun, Oct 14, 2018 at 3:50 PM Rainer Jung > wrote: And Jim already set "With 1.1.1, both return 1, but so what, we know that it has oscp." That, of course, is nonsense. OpenSSL is malleable... with

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

On Sun, Oct 14, 2018 at 3:50 PM Rainer Jung wrote: > > And Jim already set "With 1.1.1, both return 1, but so what, we know > that it has oscp." > That, of course, is nonsense. OpenSSL is malleable... with numerous no-{feature} choice, we really shouldn't presume presence of features by

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

Am 14.10.2018 um 21:59 schrieb William A Rowe Jr: On Sun, Oct 14, 2018 at 8:32 AM Jim Jagielski > wrote: All we are checking is the error code. Nothing else.    % openssl version    OpenSSL 1.0.2p  14 Aug 2018    % openssl ocsp 2>/dev/null    %

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

Copy paste missed a stderr line; $ openssl ocsp >/dev/null ocsp: Use -help for summary. $ echo $? 1 $ openssl xyz >/dev/null Invalid command 'xyz'; type "help" for a list. $ echo $? 1 $ openssl version OpenSSL 1.1.0i-fips 14 Aug 2018 This is from # dnf list openssl Installed Packages

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

On Sun, Oct 14, 2018 at 8:32 AM Jim Jagielski wrote: > All we are checking is the error code. Nothing else. > >% openssl version >OpenSSL 1.0.2p 14 Aug 2018 >% openssl ocsp 2>/dev/null >% print $? >1 >% openssl foo 2>/dev/null >% print $? >0 > > With 1.1.1, both

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

//svn.apache.org/viewvc?rev=1843478=rev > <http://svn.apache.org/viewvc?rev=1843478=rev> > Log: > Better method... just check return status > > Modified: > httpd/test/framework/trunk/t/ssl/ocsp.t > > Modified: httpd/test/framework/trunk/t/ssl/ocsp.t > URL: &g

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

t;> Better method... just check return status >> >> Modified: >> httpd/test/framework/trunk/t/ssl/ocsp.t >> >> Modified: httpd/test/framework/trunk/t/ssl/ocsp.t >> URL: >> http://svn.

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

On Wed, Oct 10, 2018 at 12:27 PM wrote: > Author: jim > Date: Wed Oct 10 17:27:33 2018 > New Revision: 1843478 > > URL: http://svn.apache.org/viewvc?rev=1843478=rev > Log: > Better method... just check return status > > Modified: > httpd/test/framework/trunk/t/

Re: svn commit: r1843476 - /httpd/test/framework/trunk/t/ssl/ocsp.t

43476 > > URL: http://svn.apache.org/viewvc?rev=1843476=rev > Log: > Use this cli command > > Modified: > httpd/test/framework/trunk/t/ssl/ocsp.t > > Modified: httpd/test/framework/trunk/t/ssl/ocsp.t > URL: > http://svn.apache.org/viewvc/httpd/test/framework