Re: Re: [DISCUSS] New Flink Writer Proposal

2021-01-07 Thread Danny Chan
> We can maintain one or two, although, we both try to find a good way to maintain one app (entry-point). Yes, after some offline discussion, we can have only one app there. For both Flink version 1.11 + or lower version. >Hudi has a rich set of table services already built out (cleaning,

Re: Re: [DISCUSS] New Flink Writer Proposal

2021-01-07 Thread vino yang
+1 on Gary's opinion, Yes, the public APIs that come from AbstractHoodieWriteClient should be able to reuse. We could try to make the HoodieFlinkWriteClient a common implementation. IIUC, there is a mapping like this: SparkRDDWriteClient -> HoodieFlinkWriteClient HoodieDeltaStreamer ->

Re: Re: [DISCUSS] New Flink Writer Proposal

2021-01-07 Thread Vinoth Chandar
+1 on Gary's comment. I would like for us to integrate as a Sink into Flink as well, i.e you can write custom code and then sink data into hudi. In addition to the app, that we have going. I have not spent enough time on this myself. So I'll spend some time understanding the tradeoffs here fully,

Re: Re: [DISCUSS] New Flink Writer Proposal

2021-01-07 Thread Gary Li
Hi all, IIUC the current flink writer is like an app, just like the delta streamer. If we want to build another Flink writer, we can still share the same flink client right? Does the flink client also have to use the new feature only available on Flink 1.12? Thanks, Gary Li